From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OHrlF9HgKGO3awAAbAwnHQ (envelope-from ) for ; Mon, 19 Sep 2022 23:36:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id sHnNF9HgKGNF7AAAauVa8A (envelope-from ) for ; Mon, 19 Sep 2022 23:36:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F222138B35 for ; Mon, 19 Sep 2022 23:36:16 +0200 (CEST) Received: from localhost ([::1]:46014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaOR5-0000Kr-Ck for larch@yhetil.org; Mon, 19 Sep 2022 17:36:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaOQs-0000Kh-Gm for guix-patches@gnu.org; Mon, 19 Sep 2022 17:36:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56407) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaOQs-0002Xy-6Q for guix-patches@gnu.org; Mon, 19 Sep 2022 17:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaOQr-00040h-Mi for guix-patches@gnu.org; Mon, 19 Sep 2022 17:36:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57757] [PATCH] gnu: Add sbcl-stumpwm-pamixer Resent-From: Trev Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Sep 2022 21:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57757 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 57757@debbugs.gnu.org Received: via spool by 57757-submit@debbugs.gnu.org id=B57757.166362330515318 (code B ref 57757); Mon, 19 Sep 2022 21:36:01 +0000 Received: (at 57757) by debbugs.gnu.org; 19 Sep 2022 21:35:05 +0000 Received: from localhost ([127.0.0.1]:55485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaOPw-0003yz-K3 for submit@debbugs.gnu.org; Mon, 19 Sep 2022 17:35:05 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:57059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaOPt-0003yO-RH for 57757@debbugs.gnu.org; Mon, 19 Sep 2022 17:35:03 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id CEF0932000F9; Mon, 19 Sep 2022 17:34:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 19 Sep 2022 17:34:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trevdev.ca; h=cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1663623295; x=1663709695; bh=OKL9pU2ooh SbTLiBUUgh4EOm2f3jmN/A+t7ioWvXJRM=; b=IIMcNn6fSxC/sa80mazEH/yJoQ k+xeDregvoR5WEsKIwQf1Ex1LiUagYPymOuWSApfearXM7BMH660Q91HafNqgI8K kqn3neqqcr/111OZnaLCY0svhXJX6/KG6ZJ3XuSPatrVnPJ+NOXweCrvyDRdSPcr 4cTa3acYkSqiiURVHhMvBIkjoxlFOmx9RhRbTzgyVHqFdBeP5kwzkM4sadNsDaxD Tg3BKo/8QB74F/8CPOch/4x/ct5XxLOehJajmgPnT/AX8cLXCqCdOGY2svNplRN6 3oNtA0oglaxp0kounWzniLYMluMrZ+3sx6S9PP77pgxny/1+BPJPKiaeA7wQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663623295; x=1663709695; bh=OKL9pU2oohSbTLiBUUgh4EOm2f3j mN/A+t7ioWvXJRM=; b=YgwPxyVMlmFqgOBk34yIXrVDRwK8Q4+ciWOczWHe6SmX 0MQrnDENsEuyDC/2z1iLKFdDyE3n8sihawmuufwwW+DxGwe0n2OmBcLEZ/YOyHZK 8wHKYqtWskAV7cHW3uHiWma2QpBjuZ+E4piTU7flWr+8hBZRnuNy8upwUym1C3Pq MOIgp0/R3oFcbKHhORIqmuYO8yThDohrpXU1Hbrn+XvDK3501a0aftgX5DOUdd4T 4+iFtpkh85Kq1/QEL/vV6Bcx/R5I+UJEwuL3QQVvfJbHMrpVwpyMUFyT5gkSo4sH UVI22/NKOXQFLcDfnIRKZY9jgtaJyYTf0Jjc8lgViw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedvjedgudeihecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepvfhrvghv uceothhrvghvsehtrhgvvhguvghvrdgtrgeqnecuggftrfgrthhtvghrnhephfelffegue eikeefhfdttdffjeffleegvdevfeffheeugfdvjefftddvffeikeehnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhrvghvsehtrhgvvhguvg hvrdgtrg X-ME-Proxy: Feedback-ID: i762946f9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 19 Sep 2022 17:34:54 -0400 (EDT) From: Trev In-Reply-To: <37a6bd56-c9d9-f269-0df6-3eaec651a871@telenet.be> References: <87h713jkbn.fsf@codinator.mail-host-address-is-not-set> <37a6bd56-c9d9-f269-0df6-3eaec651a871@telenet.be> User-Agent: Notmuch/0.36 (https://notmuchmail.org) Emacs/28.1 (x86_64-pc-linux-gnu) Date: Mon, 19 Sep 2022 14:34:53 -0700 Message-ID: <8735cn9hfm.fsf@codinator.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663623377; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=OKL9pU2oohSbTLiBUUgh4EOm2f3jmN/A+t7ioWvXJRM=; b=WvaiXxZSrcqtmP4GE4xy0wIl2uki7B7NXzvKTlkLovFb6u6mNrEIziBLyoTQqEntDL0tA9 B33HUrS7Ikk8nFSTL5DUIGG64Tl8OP0tTsEqMS4ltkgbDaVgQ8IDR94ogMuuCzrHARg02o NzV773chZxYd2PFoDu7nX/l6UMJYj3C/6WJgA/qh07pQO7Zz7BH4qpSTOAzipR93LlFfjM zezspPzLMP1YiIW9oTI3kiWmvsSfUmbgW2mEaVcG/TUSOLjKg7Kd4Jnu7Qkgq8qUABP5Iu R1L18nOphs0SNLZ8hsnsUJFvZ4+6t57qRNPtDlc/MzD8hu0QacLmzI7ja2Hd8g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663623377; a=rsa-sha256; cv=none; b=QKqgszLsihWa6g94KvQExxn4Lkp4+qYZJohQESVqakDVmt51Aehg/xmfmTViTD48N4RRYh PJyyU4kFrz8nMx5O5viusjARycnjoYO6M7R6khcMD5WBMtvSDixNU/oEoeqkwvnJYlNA1x nQ8NpsHeyop6fOgUiiJHLdGnTVLeksDxIQAyBHg6sCEpGugVgqGSaPajO+F2T01cGrys8J gXhgMATNqsHahDaezDg1f8Pjm59lL3nOm5ZS9XMY2WRRNFVjdoblNmFAO8C0NST/swtGd0 lhFBr8qf7Hbv7McLv0EM3fke/BQd3sZEchhjlEhiUsZPetGFW3+USD7S3Hb4NQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trevdev.ca header.s=fm3 header.b=IIMcNn6f; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=YgwPxyVM; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 0.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trevdev.ca header.s=fm3 header.b=IIMcNn6f; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=YgwPxyVM; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F222138B35 X-Spam-Score: 0.96 X-Migadu-Scanner: scn1.migadu.com X-TUID: qzUSsJyFbnPY --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Maxime Devos writes: > On 19-09-2022 20:22, Trev wrote: >> Maxime Devos writes: >>=20 >>> On 19-09-2022 19:47, Trevor Richards wrote: >>>> + (arguments >>>> + `(#:asd-systems '(:pamixer) >>>> + #:phases >>>> + ,#~(modify-phases %standard-phases >>>> + (add-after 'unpack 'patch-pamixer >>>> + (lambda _ >>>> + (substitute* "pamixer.lisp" >>>> + (("\"pamixer \"") >>>> + (string-append >>>> + "\"" #$pamixer "/bin/pamixer \"")))))))) >>> >>> To support --with-input transformations, you can't do #$input, you have >>> to do #$(this-package-input "pamixer") instead -- or better, don't >>> depend on input labels, by using (search-input-file inputs >>> "bin/pamixer") instead. >>> >>=20 >> Thanks for the feedback. It's hard to tell when a gexp is appropriate >> and where it's not, or how to properly evaluate it all at the right >> time. The current patch builds. Is this problematic in the sense that >> it's using some reference to #$pamixer that is not actually a part of >> the build environment? > > It is inappropriate in the sense that '--with-input' rewrites the=20 > 'inputs', 'native-inputs' and 'propagated-inputs' fields, but not the=20 > contents of the G-exp. > I see. I am not yet familiar with the --with-input flag. I will explore this feature, thank you. >> Note I had to use a quasiqote and unquote for the `gexp` to work. >> Transforming the arguments into a list so I would not have to do this >> breaks the #:asd-systems keyword value somehow. > > How about: > > (arguments > (list #:asd-systems ''(:pa-mixers) > #:phases > #~(modify-phases [...]))) > > (i.e., you are removing a layer of quoting by turning the quasiquote=20 > into a quote, so it needs to be readded for the #:asd-systems). > I see a double-quote there with ~''(:pamixer)~ - which is not something I have ever tried to do before. Is this a typo? I had tried (list #:asd-systems '(:pamixer) #:phases #~([...])) and the build failed due '(:pamixer) somehow not returning anything from a (car) function. Sometimes errors elsewhere cause nebulous tracebacks. I will try this agai= n. >>=20 >> When I observe the source code it's kinda all over the place when it >> comes to using gexps in some way or when not to. >>=20 >> I will patch this again and document a note about this but if there's >> any clarifying documentation I would happily read it. Apologies in >> advance if I have missed existing documentation. > > I'm not aware of any, though I'd like to note that G-exps are new-ish=20 > and hence the 'all over the place' is more "guix style doesn't know how=20 > to transform this kind of old thing yet" than "we chose for s-exps=20 > instead of G-exps". I like the new way of using gexps. They are more terse than needing to assoc reference inputs/outputs. The thought of as slow transition happening had occured to me. I appreciate your insight. =2D-=20 Trev : 0FB7 D06B 4A2A F07E AD5B 1169 183B 6306 8AA1 D206 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIYEARYIAC4WIQTXT7EGCbVt/Iwh9m+FRs+EoT3V7wUCYyjgfRAcdHJldkB0cmV2 ZGV2LmNhAAoJEIVGz4ShPdXvvFUBALGYCyaCuw2TSuFOefPqiJqfae43HHhPw3ry npF6OKlxAP9OyjkwLGGZ+ESVSFPVvForWOd4IO6eycT98fgwMeFeAQ== =df3y -----END PGP SIGNATURE----- --=-=-=--