From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UEXZCfy5YmNjHgAAbAwnHQ (envelope-from ) for ; Wed, 02 Nov 2022 19:42:04 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yOPrCPy5YmN8fgEAG6o9tA (envelope-from ) for ; Wed, 02 Nov 2022 19:42:04 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC0B323D for ; Wed, 2 Nov 2022 19:42:03 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqIfi-0004tM-Ts; Wed, 02 Nov 2022 14:41:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqIff-0004q8-To for guix-patches@gnu.org; Wed, 02 Nov 2022 14:41:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqIff-00045b-K2 for guix-patches@gnu.org; Wed, 02 Nov 2022 14:41:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqIR9-00067n-17 for guix-patches@gnu.org; Wed, 02 Nov 2022 14:26:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58623] [PATCH 0/3] import/cran: Parameterize for guix-cran. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Nov 2022 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58623 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun , 58623@debbugs.gnu.org Cc: Ricardo Wurmus , Mathieu Othacehe , ludo@gnu.org, Christopher Baines , Josselin Poiret Received: via spool by 58623-submit@debbugs.gnu.org id=B58623.166741354823508 (code B ref 58623); Wed, 02 Nov 2022 18:26:02 +0000 Received: (at 58623) by debbugs.gnu.org; 2 Nov 2022 18:25:48 +0000 Received: from localhost ([127.0.0.1]:47175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqIQt-00066z-IK for submit@debbugs.gnu.org; Wed, 02 Nov 2022 14:25:47 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:44587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqIQq-00066E-Sg for 58623@debbugs.gnu.org; Wed, 02 Nov 2022 14:25:45 -0400 Received: by mail-wr1-f41.google.com with SMTP id v1so25743729wrt.11 for <58623@debbugs.gnu.org>; Wed, 02 Nov 2022 11:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3LcV3TfT5aknrMYNBTeAXX09JaVgRf0yTS/T5uKDfPg=; b=Y7yYDik/qxMF/EyOIBaPTQodmiqfPkBmXzTVhxXtfZllvJgSvAf9JEI6JE5KyzUivE YzF5pyamLxJZ9dgEdYtmbi8SDpwM3KFCYTI0fPCkYd0lXM+lynYxSKGVbVOIL70dfPKc +uUB4qPHx1sRYN/Q7GlIp3P5QzWQ7wq3vTIZIO4g115nHZFTgu1QvDzH7sl8y5WqSdt8 /3cGsKieEieQpgDHXkk/rHFG2bjxO9XZ0h05UcgWzvq8uh9M626Ak7p87BmitMdr0V3r 6rUiGE5t6eu4h2O37cRYEj4mxxwFf67blvzXwzeFJmIR66adbmWI70/VBsTa+Qugx0yX o67A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3LcV3TfT5aknrMYNBTeAXX09JaVgRf0yTS/T5uKDfPg=; b=3nqJhMqu4cmi034dslbP+icIYRRFzLl7Tvu0ApoNN01FmuHwdT1IYCJaLQ+lvpD/CJ cq7EOlAQGs3p6e3V7DkgGOyUzKx1iXe494e16AhcbYUttahF9IMYfT+ENLqmSYXMVAJ1 0LnZ+PeXG5CG9N1xaGAoa40VkLxSOcuhQngcMJrxF0stIFsZuwElidDPpXBoH5Pv6hxC neqJu/Ju6zupT1CnAkHUv72Mi3HB2G2s1uLPjKyBgJvRvFtFrryjrVxlCmn/XazVCgcz pEOdj1vDPF4nnWdN9lV85tIcdJSX+qqX11GbTcTmalqUryq2p+iocR8BdGfURhzKn+q2 IStg== X-Gm-Message-State: ACrzQf30JaZhPS3ybr20/F0J3Zfna9uCa4URvLUNCC4/HVUjoCGOwP3h acfNxOMGW1lQ4MLhlgsDggKMYdjeDmw= X-Google-Smtp-Source: AMsMyM6m0Drc3LMP1PUw+EM0dV2w/nCBVtA5QvCx3DN14JHAplbN0WFACLalQQv2r3QVFaaLnhS72A== X-Received: by 2002:a5d:6a81:0:b0:236:65a0:e7d9 with SMTP id s1-20020a5d6a81000000b0023665a0e7d9mr16177983wru.327.1667413539190; Wed, 02 Nov 2022 11:25:39 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id f7-20020adff987000000b00236722ebe66sm13184480wrr.75.2022.11.02.11.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 11:25:38 -0700 (PDT) From: zimoun In-Reply-To: References: Date: Wed, 02 Nov 2022 19:25:23 +0100 Message-ID: <8735b1b4do.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667414523; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3LcV3TfT5aknrMYNBTeAXX09JaVgRf0yTS/T5uKDfPg=; b=p9eNFY+LyPBIDZffjuOdiXwN5ysBVDihKikiCuRv3eqXvQ+xGy4JV5BitfCwNllscQ/DuG ha0Da6jzNWUb2tHv+v5WtBiWZ4gNjP+6uAljSh9l/hCNjNDYC5JfuRB8u9z2xMfTyjIoul psCW+ozsuwtMWMYewzE2OlN09zsmMmvNpCWlBhVMu/PI67HWiVZW92E6ayICKwAGZ7NCxB 7TAe/CyUR8/8LT7hMlZHQ7qf1IpqbrwFA/GzSdQtix8sF5zCedRx5V4ATm63p7X8PkI8dn 3+XxS8glV6d67qtWFdua1jWIU4ZF8QCZZ1iZsaxyCRAoqkxKs58tx1NvkHwmyg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667414523; a=rsa-sha256; cv=none; b=gYl9Lg343zqo3vNUBcsx8Yn0OGLehjhQFnyYaGwPxPmTFe9zwLm7GUIFJLtoX11HpxjxxG b4al+uRNvqmkoKc8Cs62qf0+ElOKrqlgjWR9koyKiVNm5jNKQKcn5fRsbct7qP+FRl5a9c BfEJYqyADgVU37gk+7EFqnODlQVoK2fWSj41T9Bpfmz+VhYnIysHfv2GCtRqJ/wnYBYZMo VP1JyscS2tbdqP5KqXbTTl7ZsdgRfTyg++vVjF0AjpYGM2H5DNJ15lFghiQS442M900o9e dCEFvRrVxKe+CsiFjpdxOUd/+0ztijtQZ25DBce0ic6SxeKJRasdgSjxyjp86Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="Y7yYDik/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.21 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="Y7yYDik/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BC0B323D X-Spam-Score: 5.21 X-Migadu-Scanner: scn0.migadu.com X-TUID: 96zwlkJ+k/EF Hi Lars, On mer., 19 oct. 2022 at 11:28, Lars-Dominik Braun wrote: > the attached patches are required for guix-cran > (https://github.com/guix-science/guix-cran). import/cran already has the > ability to add a prefix to licenses, but it was not exposed. Additionally > I need to parameterize fetch/download functions, so I can cache the > tarballs/DESCRIPTION files. This is really cool! Thanks for working on that. > Subject: [PATCH 1/3] import/cran: Allow custom license prefix. > X-Debbugs-Cc: zimon.toutoune@gmail.com > X-Debbugs-Cc: dev@jpoiret.xyz > X-Debbugs-Cc: mail@cbaines.net > X-Debbugs-Cc: rekado@elephly.net > X-Debbugs-Cc: othacehe@gnu.org > X-Debbugs-Cc: ludo@gnu.org Because the patch had been sent as attachment, I have not received this X-Debbugs-CC, IIRC. Well, I have added these CC. > * guix/import/cran.scm (%license-prefix): New parameter. > (string->license): Use it. > * guix/scripts/import/cran.scm (%options): Add new parameter -p/--license= -prefix. > (show-help): Document it. > (parse-options): Pass it as a parameter to importer. LGTM. Maybe a line in the manual could help. > Subject: [PATCH 2/3] import/cran: Allow overriding description fetch func= tion. > > * guix/import/cran.scm (%fetch-description): New parameter. > (cran->guix-package): Use it. > (upstream-name): Use it. [...] > Subject: [PATCH 3/3] import/cran: Allow overriding tarball download. > > * guix/import/cran.scm (%download-source): New parameter. > (description->package): Use it. > --- > guix/import/cran.scm | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) Well, I miss what it changes =E2=80=93 I have nothing special to comment, so LGTM. :-) Cheers, simon