unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Aljosha Papsch <ep@stern-data.com>, 49155-done@debbugs.gnu.org
Cc: Ellen Papsch <ep@stern-data.com>
Subject: bug#49155: [PATCH] gnu: mysql: Support custom data dir.
Date: Sun, 20 Nov 2022 17:56:12 +0100	[thread overview]
Message-ID: <8735ad1s5v.fsf@gnu.org> (raw)
In-Reply-To: <20210621132750.49528-1-ep@stern-data.com>

[-- Attachment #1: Type: text/plain, Size: 1516 bytes --]

Hi!

Thanks for the patch, and sorry for the slooow response...

Aljosha Papsch <ep@stern-data.com> skriver:

> From: Ellen Papsch <ep@stern-data.com>
>
> * gnu/services/databases.scm (mysql-configuration): Add datadir property.
> * gnu/services/databases.scm (mysql-configuration-file): Replace hard coded
> data dir with property from config.
> * gnu/services/databases.scm (%mysql-activation): Remove activation, it runs
> before PID 1. The data dir may reside on a file system not mounted at this
> time.
> * gnu/services/databases.scm (mysql-install-shepherd-service): Create service
> which replaces the activation. Provide mysql-install.
> * gnu/services/databases.scm (mysql-shepherd-service): Move invocation of
> mysqld to mysql-start program-file, because the invocation gotten more
> complex. Require mysql-install.
> * gnu/services/databases.scm (mysql-start): Invoke mysqld only if a lock file
> appears.
> * gnu/services/databases.scm (mysql-shepherd-services): Prepend the install
> service before the normal service.
> * gnu/services/databases.scm (mysql-upgrade-wrapper): Increase timeout to
>   20s to let the mysql install procedure finish.

I have finally applied this patch, along with a follow-up commit to make
the mysql-upgrade service also work with a custom datadir.

I also ended up dropping the 'mysql-install' service in favor of a
mysqld wrapper script that calls the mysql-install script at startup
when the "mysql" DB is missing.

Pushed in c7b266fdf2754c139803c156677bf2828c78d072.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

      reply	other threads:[~2022-11-20 16:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 13:27 [bug#49155] [PATCH] gnu: mysql: Support custom data dir Aljosha Papsch
2022-11-20 16:56 ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8735ad1s5v.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=49155-done@debbugs.gnu.org \
    --cc=ep@stern-data.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).