From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EDooH8H3wmMpmgAAbAwnHQ (envelope-from ) for ; Sat, 14 Jan 2023 19:43:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mMsTH8H3wmMIwwAAauVa8A (envelope-from ) for ; Sat, 14 Jan 2023 19:43:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 40AAF3BA12 for ; Sat, 14 Jan 2023 19:43:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGlUe-0008L4-4v; Sat, 14 Jan 2023 13:43:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGlUc-0008Kb-Bj for guix-patches@gnu.org; Sat, 14 Jan 2023 13:43:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGlUc-00048J-3K for guix-patches@gnu.org; Sat, 14 Jan 2023 13:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pGlUb-0005mO-Tw for guix-patches@gnu.org; Sat, 14 Jan 2023 13:43:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52555] [RFC PATCH 0/3] Decentralized substitute distribution with ERIS Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 14 Jan 2023 18:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52555 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: pukkamustard Cc: 52555@debbugs.gnu.org Received: via spool by 52555-submit@debbugs.gnu.org id=B52555.167372177322201 (code B ref 52555); Sat, 14 Jan 2023 18:43:01 +0000 Received: (at 52555) by debbugs.gnu.org; 14 Jan 2023 18:42:53 +0000 Received: from localhost ([127.0.0.1]:55545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGlUT-0005m0-Av for submit@debbugs.gnu.org; Sat, 14 Jan 2023 13:42:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGlUR-0005lo-OL for 52555@debbugs.gnu.org; Sat, 14 Jan 2023 13:42:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGlUM-00046e-FY; Sat, 14 Jan 2023 13:42:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=HiZHAUGDgjvZ1UwzLZGZ2RORjTX56178hpofcCl1u3c=; b=jHEb//KYGaR3711uySbq Dv6zz65GGk1kArGmcpoWs0ZKnYFsk9trw+ziwxRXBgDTmUE57vNaRnNASTWdBEh02tufvUPdDlPnt /vXep4iR23XsubvQ/eDAfQ9fnyh4bq94Ovo9Far8NIwnw5iTP7SKIAvyCWD7Ao2mNh37Ozvzl3+sO ccqP1UIxpmx1XVheh8HT9wLpmHoeGPKGitDTLD6pdgHCIbHPQpY08SOPV3oRDaJYU1R6E01q0fY1T X+UUa/E3D+YD9Wyzk6Nn7jNVgyqkfQRFh0DNwR811Z/tNmgox1Xn0QAKPzfkbyknQTZzGz15E5tB4 LGOTwxiA+CpmSg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGlUL-0002YC-5j; Sat, 14 Jan 2023 13:42:46 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221229181327.758-1-pukkamustard@posteo.net> <20221229181327.758-3-pukkamustard@posteo.net> Date: Sat, 14 Jan 2023 19:42:43 +0100 In-Reply-To: <20221229181327.758-3-pukkamustard@posteo.net> (pukkamustard@posteo.net's message of "Thu, 29 Dec 2022 18:13:21 +0000") Message-ID: <87358d7yak.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="jHEb//KY"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673721793; a=rsa-sha256; cv=none; b=md1XEUcqQjMx4lfQgaDocc4bAUU4BWIY+wRQigValurZ50YvP8akK90PRTHQoMG7a+FoiP 7IgNNIiTWoKEPuUWFwnIqRlQunOeDdsimpu3sglPrZL9QDOWOlKj1yPQ0wKo1rMg1iAZ8J nhjwpZk5kZRDSNWxxrxAmxhsrylEHHG71rw6uN8B9vmfYWqWfeQDSOU1ht+uQqE+bsmaei uZKRVaZsaNDUywHCmopwYwXp48t2LxPiPOs1wM+whWeK13BPP1Sa47I33eNEadebNCExD0 8WPUE2IXRY4pouWD2RF/zuQF0YhmEW4XPiGKzl9pvJYrOi3XqN+/+cH+EjC5Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673721793; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HiZHAUGDgjvZ1UwzLZGZ2RORjTX56178hpofcCl1u3c=; b=XiGLNBeeDS0Bu82g5KHg62umv0s6zhzIApuVK7asSDOQFhfO798CpUCpj7FSxb4Ji9iGQK GQXeUk2KduueAf43tlq4KERGHODYFpvlDJ5+ucKnHQLoQzU1mytxwPdsuIlH4kDRy386Lf QUlJUIvP7YU+3uY21jGVFDEXiENsH82RfGHxzsbH7AVug6Hq6jeaCF86R6pLA7mxRjiwjW +e9bm/HNgi57C5OrR8gihYUUqIGwfr7y105m/m+8KDZiPH0u2gSCuaz7GMfVT2pdf0TCpz oaRI1EUpK3DPWGU/GsdvfD19MWTOoDa9v3BYcx6KU5HCNB9wawu7VgeNLVbJZQ== X-Migadu-Queue-Id: 40AAF3BA12 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="jHEb//KY"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -4.31 X-Spam-Score: -4.31 X-TUID: 4VcxjtfcZKIr pukkamustard skribis: > * guix/eris.scm: New file. > * guix/eris/fs-store.scm: New file. > * Makefile.am (MODULES): Add new files. > * guix/scripts/publish.scm (bake-narinfo+nar): Use guix-eris-block-reduce= r. [...] > +(define %eris-block-store-directory > + (make-parameter > + (or (getenv "GUIX_ERIS_BLOCK_STORE_DIRECTORY") > + (string-append %state-directory "/eris")))) > + > +(define (guix-eris-block-reducer) > + "Returns a block reducer that stores blocks of ERIS encoded content." > + (eris-fs-store-reducer (%eris-block-store-directory))) Maybe this should be private to (guix scripts publish)? Also, the store directory should be /var/cache/guix/publish/eris by default IMO. > +(define (eris-fs-store-reducer store-directory) > + (case-lambda > + (() (mkdir-p store-directory)) > + > + ((result) result) > + > + ((_ ref-block) > + (let* ((ref (car ref-block)) > + (b32 (base32-encode ref)) > + (pre (substring b32 0 2)) > + (suf (substring b32 2)) > + (pre-dir (string-append store-directory "/" pre)) > + (path (string-append pre-dir "/" suf)) > + (block (cdr ref-block))) > + > + (mkdir-p pre-dir) > + > + (unless (file-exists? path) > + (call-with-output-file path > + (lambda (port) (put-bytevector port block)) > + #:binary #t)) > + > + #t)))) > + > +(define (eris-fs-store-ref store-directory) > + (lambda (ref) > + (let* ((b32 (base32-encode ref)) > + (pre (substring b32 0 2)) > + (suf (substring b32 2)) > + (path (string-append store-directory "/" pre "/" suf))) > + (if (file-exists? path) > + (call-with-input-file path > + (lambda (port) (get-bytevector-all port)) > + #:binary #t) > + #f)))) Could you add docstrings, remove tabs, and use (ice-9 match) instead of car/cdr? :-) Whole files (blocks, right?) get loaded in memory. Is that OK or should it be avoided? There are time-of-check-to-time-of-use race conditions with those =E2=80=98file-exists?=E2=80=99 calls. In the case of =E2=80=98ref=E2=80=99= , you can instead write: (catch 'system-error (lambda () (call-with-input-file =E2=80=A6)) (lambda args (if (=3D ENOENT (system-error-errno args)) #f (apply throw args)))) In the case of =E2=80=98reducer=E2=80=99, perhaps it=E2=80=99d be safer to = write the block atomically with =E2=80=98with-atomic-file-output=E2=80=99? (And remove the =E2=80=98file-exists?=E2=80=99 check too?) Write =E2=80=9Cfile=E2=80=9D rather than =E2=80=9Cpath=E2=80=9D (the latter= is used to refer to =E2=80=9Csearch paths=E2=80=9D). :-) Ludo=E2=80=99.