From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SHtiIJoa1WPmhQEAbAwnHQ (envelope-from ) for ; Sat, 28 Jan 2023 13:52:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kNw7IJoa1WN7ZwAAauVa8A (envelope-from ) for ; Sat, 28 Jan 2023 13:52:42 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0D1453CFC8 for ; Sat, 28 Jan 2023 13:52:41 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLkgg-0002cW-6i; Sat, 28 Jan 2023 07:52:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLkgd-0002bh-Eh for guix-patches@gnu.org; Sat, 28 Jan 2023 07:52:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLkgd-0004BN-6J for guix-patches@gnu.org; Sat, 28 Jan 2023 07:52:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLkgd-00043G-2X for guix-patches@gnu.org; Sat, 28 Jan 2023 07:52:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61117] Update svtplay-dl to 4.18 Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 Jan 2023 12:52:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61117 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Jessica Tallon Cc: 61117@debbugs.gnu.org X-Debbugs-Original-Cc: 61117@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 61117-submit@debbugs.gnu.org id=B61117.167491026915465 (code B ref 61117); Sat, 28 Jan 2023 12:52:03 +0000 Received: (at 61117) by debbugs.gnu.org; 28 Jan 2023 12:51:09 +0000 Received: from localhost ([127.0.0.1]:39815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkfl-00041N-By for submit@debbugs.gnu.org; Sat, 28 Jan 2023 07:51:09 -0500 Received: from tobias.gr ([80.241.217.52]:60090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkfg-00041C-Ky for 61117@debbugs.gnu.org; Sat, 28 Jan 2023 07:51:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=yUe+T3KQmoHl6 /pRJLZORC0iItP8MThm8yre3rrp4QA=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=EFIxRgUb7bOikbt9LWVKmK90Bx0UXPuA6aXJiU khzNqKFniVGu7HkDDoCmZrY0+oYVZ8Rhi5j5X/DLVLc9qOQbpv8W/Aobc6E9yg9ao7l9Eq 0ipv2ZIOWJUw2oY/4KuEp6H2SFgDXQO3icBvBHNSJm90vG1emXvMOUl/nF++g6RlFh9qDZ 4kbAj4WTXrtodDR4wraFrHhCsGbQPstNv1NCEMA0uKlW+giH8LOwSa8DMLpnzJHS99lHkr 3G2o43n4+gNE8SQQ6lyafu5iMCv5kK56AyBB0CdLpKnJYxM5wb/s8+YKX+pUbjPq8/CzRn f6qDIIyuLyNVat7cPFjeZWIQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 473c57e0 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 28 Jan 2023 12:51:02 +0000 (UTC) References: <5646122.DvuYhMxLoT@localhost.localdomain> Date: Sat, 28 Jan 2023 13:33:44 +0100 In-reply-to: <5646122.DvuYhMxLoT@localhost.localdomain> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87357ult1k.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674910362; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=yUe+T3KQmoHl6/pRJLZORC0iItP8MThm8yre3rrp4QA=; b=sc6wCsIj/Bqi0pIXetKdYVCpKLDkAbU3z2syewhBWQ4GXMTQn2RRXRFxMy5MEaaD+YZJvi x//EEe07SgSvzZfLJXgnqFXkQ4MdOcteqqsQvCczS2qH69ucFLclJYALpWluWbGB7lYKec 50it3YVSuU5a66bfW/w1smZENBMCE7MSdJcSKdE0cS08wBSnFP3VNePr6hvnLuhMkJuVqa +SqQnGdw7krVqpr3jzsgRPDL2RcaqtjMS3vdda14bM6PNZ/qV8HGzaOwN5adu4IjParqLU Mf7iLMjH/GC4YT/jxhzUZtZWV4+YjmYRZNz1WTnl8rtHmbQyJoh22LgBSQZeCw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=EFIxRgUb; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674910362; a=rsa-sha256; cv=none; b=HiGoFO+bkI2ar88NcnmA1CD557vE+9qpBY1Bi4GGyusHQ6k1pT3dQB1Nx3tW482DDuGgg+ QFKDqs+fl0F5wWgFlhWM6c2RSbfTaXzGmrBNkqAs58V6MbNsDQIx9Oqkcd5cweWMgU8Tt0 LO4aHwXj5NZuJC2rUSoDej1FQqM56ZH4barU8SizKjELeOb3qwyl8+6UfzG1E+jI/KD3/V d8/WR59sHYOAMZCid0Dsr74/x4J6wh4WvIniheTF8r7Eqrv7DFsnccs7zmdO3GI+jBxivQ KZ11eRCNTGbc/nZmG4fBhL6fYFYD9YcN2k/i09M/wg8w5PGwVX6BcNPGWSpatw== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=EFIxRgUb; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -4.27 X-Spam-Score: -4.27 X-Migadu-Queue-Id: 0D1453CFC8 X-TUID: R2T1NjlSp3N9 --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Jessica, Jessica Tallon =E5=86=99=E9=81=93=EF=BC=9A > I've attached a patch to upgrade svtplay-dl from 4.17 to 4.18. Thanks! > I've also moved ffmpeg form inputs to propagated-inputs Please avoid propagation whenever possible; it breaks all kinds of=20 nice things. Propagating A from B means that Guix will effectively =E2=80=98install=E2= =80=99 A=20 alongside B when the user installs only B. Or how classical=20 package managers bluntly handle =E2=80=98dependencies=E2=80=99. Not good! Here's what I'd do instead [untested]: (arguments (list #:phases #~(modify-phases %standard-phases (add-after 'wrap 'wrap-harder (lambda* (#:key inputs outputs=20 #:allow-other-keys) (wrap-script (string-append (assoc-ref outputs=20 "out") "/bin/svtplay-dl") `("PATH" ":" prefix (,(dirname (search-input-file inputs "bin/ffmpeg")))))))))) (native-inputs (list guile-3.0)) ; for wrap-script > it's needed while the program is=20 > running to merge two files, not while building. So 4.17 did not need or use ffmpeg this way? Otherwise, put each unrelated changes into a separate commit: one=20 to improve the ffmpeg situation, and one to update svtplay-dl.=20 You can send multiple related commits as one patch series to one=20 bug number, though. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY9Uatw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15XMoBALYlzpK/UWBrpMt7maGd+CLzb6LvgptO6VTTc4mw FvaIAQDFWKaUlXwtYyqLb9z6wI8kO0rpHlyG0bQd/6IcFyJbCQ== =HBip -----END PGP SIGNATURE----- --=-=-=--