From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uDyxMceP4mPQZQAAbAwnHQ (envelope-from ) for ; Tue, 07 Feb 2023 18:52:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eMWVMceP4mPS7gAAauVa8A (envelope-from ) for ; Tue, 07 Feb 2023 18:52:07 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 73A86967A for ; Tue, 7 Feb 2023 18:52:07 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPS8T-0007fH-3n; Tue, 07 Feb 2023 12:52:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPS8R-0007ZC-5P for guix-patches@gnu.org; Tue, 07 Feb 2023 12:52:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPS8Q-0007Ma-SV for guix-patches@gnu.org; Tue, 07 Feb 2023 12:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPS8Q-0003Fs-Op for guix-patches@gnu.org; Tue, 07 Feb 2023 12:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60910] [PATCH 12/25] gnu: Add xurls. Resent-From: Katherine Cox-Buday Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Feb 2023 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60910 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60910@debbugs.gnu.org Cc: paren@disroot.org X-Debbugs-Original-To: "( via Guix-patches" via X-Debbugs-Original-Cc: "\(" , 60910@debbugs.gnu.org Received: via spool by 60910-submit@debbugs.gnu.org id=B60910.167579228412453 (code B ref 60910); Tue, 07 Feb 2023 17:52:02 +0000 Received: (at 60910) by debbugs.gnu.org; 7 Feb 2023 17:51:24 +0000 Received: from localhost ([127.0.0.1]:53961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPS7o-0003Ei-Av for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:51:24 -0500 Received: from mail-il1-f179.google.com ([209.85.166.179]:37515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPS7l-0003EI-3m for 60910@debbugs.gnu.org; Tue, 07 Feb 2023 12:51:22 -0500 Received: by mail-il1-f179.google.com with SMTP id o13so2514223ilt.4 for <60910@debbugs.gnu.org>; Tue, 07 Feb 2023 09:51:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=IpM/X8Q2hmkzb4pCP3AueEVB5pSNSRpezQ3X3GMl9dc=; b=St7hhdZQKpIoKJfPNs+oVFRh4B+Gzvtxk1J6w6MnYLdHLvn3PS3W9yb7h5bDmWh50p NNSE7QzYlXR1EaXRs43vU1OOrZBB6dRCScnpwrpiFHmGCR8sM2CSp78z1hV9cKUP5Juj 6y/RMNQWH0cH4mKJEvQQryL/yDpXiL68O7yoB4GaabGZ6jKsIbuDrwMCaL1tvlSzlFqu MA/dhixv0hOyDt03BHVNW/SIhRutgoI3JphSQ/Dc+vWNORfepkxrkErbciD7pzZBIoSn 39DfYGeiHzFI+OTpNqOnpY6v4lykNY4GWGQpoBHsE9HXowSC2gZgqZ/alWAfimVv1EpW hHAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IpM/X8Q2hmkzb4pCP3AueEVB5pSNSRpezQ3X3GMl9dc=; b=V4FRt/QVuL7nt516rfUaQiDEAfNzVbs9ZG18oiBiPuuKXyEAnKMc6oIxDCh+FXv2hh X5EKAVfD9Vy6R/WvhBY0Qgkakn4JZ189kke/7MrmJqHI9zYhVxihQciJe0lYFSwCbP8z 8hO75/WDZpLFCsOamsZT+XLLPaEVGTXBxo6hiwbYMvWw6FRpOQe5zY+YFKpzBFWvdYLK w79dBGarWmJbg2hwnnTIL7T4hYGTBJPtSBd4Mf2k2vT8v/xBQ3R/w51uf2jGpP2I4k+x +yIiBvxdHtspAjdyWK7IKywQS5c0EyKm+6mt/CK9T16fkqKFUFqxFbfuP3En2+elQdmt Z38Q== X-Gm-Message-State: AO0yUKWPoYl/9M097cohNM1W5co5EBrJS3tfZ3Jt8VY+zedvGlAgwvlj 3cpqH2oWrckK2UYIfqoPLrI= X-Google-Smtp-Source: AK7set+xdmRQry1C7yj2MSiocC5t04FSLz1Tgvo/AvgVgOjPMIfa5y9vRb9s/lsw+m5EZy9dvJ28xg== X-Received: by 2002:a05:6e02:1be8:b0:313:cd79:adcb with SMTP id y8-20020a056e021be800b00313cd79adcbmr4850699ilv.18.1675792275392; Tue, 07 Feb 2023 09:51:15 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id b7-20020a056638150700b00363c4307bb2sm4579024jat.79.2023.02.07.09.51.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 09:51:14 -0800 (PST) From: Katherine Cox-Buday References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-13-cox.katherine.e@gmail.com> Date: Tue, 07 Feb 2023 10:51:14 -0700 In-Reply-To: (guix-patches@gnu.org's message of "Mon, 06 Feb 2023 22:32:55 +0000") Message-ID: <87357hxt2l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=St7hhdZQ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675792327; a=rsa-sha256; cv=none; b=Zb7GbAA9UYV6pQ7MDhysCrzf8aWar3j2apwKDDh606wo3x590E03/AKpRIAjDSnHRpr2GY qAtBdDM+36NfhXeNRAFHq/j15fTR8AGGwQTi/YOhnxiCmaLQ6ydIa1R67uKVA0kH117ydq detEhpaYBaXfL/egpjCTo0QnecbQknY9DpOwgV1QY/pLkkH7tYfKWq5IJM1BJCtPb7l3oM BWnms0Djt7Uk+BcKq2acieaddGWc/J5FUFi3CHzB1JvnxwdB+jbwtO/CDUHzxN5g9eV+t0 CkEeyEszp/DWncXzQuA0Hpxko20qJwXgJPY4Heid1P9Ljjb48ovMlgFjUrkULQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675792327; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=IpM/X8Q2hmkzb4pCP3AueEVB5pSNSRpezQ3X3GMl9dc=; b=OMuran/1ujxsGPPfqOhOec3f9Cn7g9EvA6svZQTa3hyz9A/hHxtYjcch/NwLf1EhXtXHmu QFY0zbK6jey/cbRVWntcqcSio6qSLeI6KTGzchzMkyfljqu/qbrXGeA1PebsMyPzBS7BDh 8b8Ymop7TV6OsRDAParnLqPUdr0xq6/tB4LSoRjO5BxH817p2tFllBDZVoZI9MZSXfzlJS +BjRaf8P2QIBmRGdnp3igxK/Ynqz7aPjzoiboz8TxpSKXA4j7l+BdTTYBxNmAtdOR+8Q8q ptCLfenDzlHl8N27scGXcmWkUjWPLRxBVPKFc8FxNhMK7dGc+QudygFwMQUe6w== X-Migadu-Spam-Score: -1.99 X-Spam-Score: -1.99 X-Migadu-Queue-Id: 73A86967A X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=St7hhdZQ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: w/liDeASck+j "( via Guix-patches" via writes: > * gnu/packages/golang.scm (xurls): New variable. > >> --- a/gnu/packages/golang.scm >> +++ b/gnu/packages/golang.scm > >> @@ -9760,6 +9760,38 @@ (define-public go-go-uber-org-multierr > >> + (arguments >> + `(#:import-path "mvdan.cc/xurls/v2" >> + #:unpack-path "mvdan.cc/xurls/v2" >> + #:phases (modify-phases %standard-phases >> + (replace 'build >> + (lambda arguments >> + (apply (assoc-ref %standard-phases >> + 'build) >> + `(,@arguments #:import-path >> + "mvdan.cc/xurls/v2/cmd/xurls"))))))) > > I'm not certain what you're trying to accomplish here, but would you be a= ble > to replace this with: > > (arguments > `(#:import-path "mvdan.cc/xurls/v2" > #:unpack-path "mvdan.cc/xurls/v2/cmd/xurls")) > > ? Hm, I'm sure I would have tried that, but I'll check and see if I can condense this per your suggestion. Thanks! >> + (inputs (list go-golang-org-x-sync go-github-com-rogpeppe-go-intern= al)) > > Add newlines after the ``inputs'' symbol and between the inputs :) Why wouldn't `guix style` and `guix lint` correct this? I want to meet the style guidelines, and I don't mean this as a contrarian statement, but I'll never get this right unless a tool tells me it's wrong (or ideally fixes it for me). >> + (description >> + "Xurls extracts urls from plain text using regular expressions. I= t can >> +be used as both a binary and a library.") > > s/Xurls extracts/This package provides a Go library for extracting/ https://guix.gnu.org/en/manual/devel/en/guix.html#Synopses-and-Descriptions: [Synopses] must not start with =E2=80=9Ca=E2=80=9D or =E2=80=9Cthe=E2= =80=9D, which usually does not bring anything; for instance, prefer =E2=80=9CFile-frobbing tool=E2=80= =9D over =E2=80=9CA tool that frobs files=E2=80=9D. The synopsis should say what the package is=E2=80=94e.g., =E2=80=9CCore GNU utilities (file, text, shell)=E2=80= =9D=E2=80=94or what it is used for=E2=80=94e.g., the synopsis for GNU grep is =E2=80=9CPrint lines mat= ching a pattern=E2=80=9D. The manual is speaking of synopses, but does it apply to descriptions too? It seems to me like beginning the description with the name of the binary is more correct than a self-referential "This package", which I think meets the manual's qualifier for "does not bring anything". Also, `Xurls` is both a library and an executable. This package is for the executable, and a separate one was provided for the library. I think it's probably better to keep it in the style of "$BINARY (thing that it does)". WDYT? These are just my opinions, and I'm open to learning! Please include the "why" so I can have better judgment in the future. --=20 Katherine