From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YNnsKThq5GOZtgAAbAwnHQ (envelope-from ) for ; Thu, 09 Feb 2023 04:36:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id YGAbKThq5GNzIAAAG6o9tA (envelope-from ) for ; Thu, 09 Feb 2023 04:36:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 28C4F1625F for ; Thu, 9 Feb 2023 04:36:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPxjA-00021V-Bw; Wed, 08 Feb 2023 22:36:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPxj8-000216-Gu for guix-patches@gnu.org; Wed, 08 Feb 2023 22:36:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPxj8-0004gx-8R for guix-patches@gnu.org; Wed, 08 Feb 2023 22:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPxj7-00061m-R3 for guix-patches@gnu.org; Wed, 08 Feb 2023 22:36:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60788] [PATCH] services: Add vnstat-service-type. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Feb 2023 03:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60788 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 60788@debbugs.gnu.org Received: via spool by 60788-submit@debbugs.gnu.org id=B60788.167591370323081 (code B ref 60788); Thu, 09 Feb 2023 03:36:01 +0000 Received: (at 60788) by debbugs.gnu.org; 9 Feb 2023 03:35:03 +0000 Received: from localhost ([127.0.0.1]:57103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPxiB-00060B-9L for submit@debbugs.gnu.org; Wed, 08 Feb 2023 22:35:03 -0500 Received: from mail-qv1-f49.google.com ([209.85.219.49]:46938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPxi6-0005zc-E2 for 60788@debbugs.gnu.org; Wed, 08 Feb 2023 22:35:02 -0500 Received: by mail-qv1-f49.google.com with SMTP id l6so178567qvl.13 for <60788@debbugs.gnu.org>; Wed, 08 Feb 2023 19:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zM64E3OtC+1XlCBdr5msDSAmX58h1+QOjhm7HXRdcjE=; b=Eb3Wz6Cl5HYUs9J3pVnh3CSWKS5lLSLTOdunAv7HwlngNJOWx4EPLBwfWP2Yz5eKpz f92ztD5Uxz1l0iRj6wyyKYRsC86wcgEZ0tRWNLUHpLXp4kPqQhX9EicGWHJoZrvmhW8D /hAFoZDoJubmBLJBE8OJ7iIQ8kPe8ecwPQm0toV91FHq0WCLKXKHQxTEE4VS/OMauX+0 Ldi7Lcukibzk3LjtMlkcEnEj3OAHiicSlSULfeC2tBALDRqF4KSqfOs+uJzBEiuCnkiL yrrQF7RZGgVkqL/iXYkyanDezA0noC/xwl18Ds2k7KFl1fS5QHDB6Bpp/Fwk7gKJ9OJD zHJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zM64E3OtC+1XlCBdr5msDSAmX58h1+QOjhm7HXRdcjE=; b=ePX+Y5urZGPW7pkorf7bbh/foAyrhaeLOvw0BUPMAHINcQOctwQ2jKyGLGYc5WzsD1 bxCx5k1unEuZEErXgmb4m0035sLFB2fJaG4xdrgEJNRbnRXNBszU5CEmDaEcjstX0UwT RHHf1c0bg5MbSVnoVL7ItqX3mQO8UKhZDGlaUhu/PxtCAz2mRX8DMFW9kpSAGyZidbXp INm4EEKQBz3MYYhje3KlzXS1xMYpsNq+dOfgRLznFjx8bqaG9Tf5knuMFVpSN4H5L0xM g3AB3V1nt4roQh+ukCtTIGhQLQh/XV6dM0jje7GpwjHVtSkHEL5vN3JKgdF/EXtTBTCp 0lTg== X-Gm-Message-State: AO0yUKUtC24pjcLePAIS4J7Gbj0bbk9QocWumUVDydu4wN0AzXMhbhR3 LQpjN3Q29M3janvc/DIMrIqxgVE6kW++1w== X-Google-Smtp-Source: AK7set8QiBAyaMyhWB3Mxv6fSs73zUKHoWeMh9scBL+2Xdqi/9cw7ATG0fwRS3eIPHtd0W2QrAH8Rg== X-Received: by 2002:a05:6214:e85:b0:567:d345:1019 with SMTP id hf5-20020a0562140e8500b00567d3451019mr16722780qvb.42.1675913692808; Wed, 08 Feb 2023 19:34:52 -0800 (PST) Received: from hurd (dsl-151-105.b2b2c.ca. [66.158.151.105]) by smtp.gmail.com with ESMTPSA id 2-20020a05620a040200b006fbb4b98a25sm484501qkp.109.2023.02.08.19.34.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 19:34:52 -0800 (PST) From: Maxim Cournoyer References: <95b646eb6b23dec213cba43b6e4e7ddc4a601d0f.1673640404.git.mirai@makinata.eu> <8b62c1b5643a09163b53af4bf03bb12862770b50.1675779899.git.mirai@makinata.eu> Date: Wed, 08 Feb 2023 22:34:51 -0500 In-Reply-To: <8b62c1b5643a09163b53af4bf03bb12862770b50.1675779899.git.mirai@makinata.eu> (Bruno Victal's message of "Tue, 7 Feb 2023 14:25:23 +0000") Message-ID: <87357fjyuc.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675913784; a=rsa-sha256; cv=none; b=MdcQ43pLly2epp3eIgcVRxA23GUgvUJoy1XpxtGU0ubZW0in2t+xFZPshy96qhiUle8Eg3 yGm4O+DcIVtyA8KjICF7qoDj9PLN6mUqgWQF7FC7ZOU7wHhg/LeFyUrDc3IP7VCWOGB0a2 IXzMU4UHqdFYVwT5ekAeA5klfkWWst5KQ3/iWCEifyF05zbTjtHi4NhyuJmgyC05b9a7ut ISZk8w8CNpxtZ9012ZRuSrxwnkAxgxqIu1+RhKfcZp/ieQ0daTfyF3SdTqPZf0NY/K2I7S FS1CTUhnQiZyOTHk4Uk4WZmV4wFhnmEu675Ya5U+Z3LQGpSizYEtsfKoDMchuQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Eb3Wz6Cl; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675913784; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=zM64E3OtC+1XlCBdr5msDSAmX58h1+QOjhm7HXRdcjE=; b=MBVy8Dq8BAQOwL19mrqJN5fxsAtrcXFVVQmTPwFZcisW/XmLvDzAVEJsZ/QwMEuWVmku2N jny4PI2fe+vcpXYYb2f7EYaH7eKA5LIG8vB54dcvd1NfyeJ5slW2iNo9c5vCZj+252lsM4 2GWyuhDWLr6zcXfwg9ND4xEqlsVu4gVBPoiTU48edAlXZD/RMwjHaqnnPJNVsqJGrv7ybf 0zQdSqUGGo3zgUEXissMRQvEjLHgLxCst3wXEQFqEue2JAKSkDVB8QVHtsfFVvIQthCpT1 sI/q45ErtulGjUorOrXbU/X4Qb93JG7oZ1WBhjbbGQ3zueGsAo7yM8f3qws49A== X-Migadu-Queue-Id: 28C4F1625F X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Eb3Wz6Cl; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: -2.00 X-Spam-Score: -2.00 X-TUID: yuWE//KySAzQ Hi Bruno, Bruno Victal writes: > * gnu/services/monitoring.scm (vnstat-service-type): New variable. > * doc/guix.texi (Monitoring Services): Document it. > --- > doc/guix.texi | 240 ++++++++++++++++++- > gnu/services/monitoring.scm | 451 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 689 insertions(+), 2 deletions(-) Two remaining comments from me: 1. I'd normalize all the configuration field names to lowercase, so max-BW and use-UTC? would become max-bw and use-utc?, for example. 2. I'd add a simple example vnstat usage example to the manual. With this done, I think it should be good to go! -- Thanks, Maxim