From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UM0KBTceHmRBGgAASxT56A (envelope-from ) for ; Fri, 24 Mar 2023 23:03:35 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id r0PwBDceHmQUSwAA9RJhRA (envelope-from ) for ; Fri, 24 Mar 2023 23:03:35 +0100 Received: from lists.gnu.org (unknown [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E1876178FB for ; Fri, 24 Mar 2023 23:03:34 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=KDPCc0s5; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679695414; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=9xVl7GoIP1fXZ7mz7+y9yQrwaCaxnuWrTF/yaqC3Gg8=; b=knwfRMUGp3UOehsEc32sGOIW35NtvCG5YKYDQdJKhk4Ty360XZ+ziGh+19sA3PbVPHGN7P nZ1gC3N5q6oHRKuytYueJQWlhIGhpMBiMfS3OkJ0L7U1s7rpX0UyNESQFR/A+zbFK+my6v YWdtFeZnu5UKb5clN3Qdf3pxYYQKTCcJltuqR22+5U79PSUzN2FAJu9dhHQ/u9K+BTuxeX zhxO5e0dvrMwmV1WleJqFFuJ65dwhhwuhuwPN15G2RUZvabPZn1Qx8UZ2Sa5GHCxKOF8So cUzVzo98PlxHcrad0kRzGlAvaAeXrO/eOtGF3UATH5ruHTVLZhmE01hBvMbs6A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679695414; a=rsa-sha256; cv=none; b=XISSKJzZ8xXB0k4Cj6fHnrwDClVo3IHXL2Qk+eRb4jLqjPyP+6jtsyCduXwmHqD9JO5DzF d9y+d6ekDLCGdlGz0JmgLI9ZwTavANK0c49EQoU4+JJG++sVJCWa1vEU+8xaO/HAjef7uU 9QtzEFJvmM6bCHX3feyaT0ZChwTxqSuGqIfGxwaTvGVMGxDM8D5PaWl6iMEWtuNASAc0QM blKYJalIbW1hgBomhVUMSrRZC8Rw5WKnB0xXZ0+bEMlcTotcOUnWVgkX347gzzjObA67xS SUp9/7sn/eo3ZCs3xFD9GbM/gQrM0TqqsDVwgpSl65/GHLCXe2Zz7KuDK8gvyg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=KDPCc0s5; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfpTE-00044M-2G; Fri, 24 Mar 2023 18:01:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfpT8-0003xe-T3 for guix-patches@gnu.org; Fri, 24 Mar 2023 18:01:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfpT8-0000eY-IG for guix-patches@gnu.org; Fri, 24 Mar 2023 18:01:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfnFd-0003Gn-PS for guix-patches@gnu.org; Fri, 24 Mar 2023 15:39:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with native compilation. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Mar 2023 19:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62314 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 62314@debbugs.gnu.org X-Debbugs-Original-Cc: 62314@debbugs.gnu.org, John Kehayias via Guix-patches via Received: via spool by 62314-submit@debbugs.gnu.org id=B62314.167968673512556 (code B ref 62314); Fri, 24 Mar 2023 19:39:01 +0000 Received: (at 62314) by debbugs.gnu.org; 24 Mar 2023 19:38:55 +0000 Received: from localhost ([127.0.0.1]:41401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfnFX-0003GR-8M for submit@debbugs.gnu.org; Fri, 24 Mar 2023 15:38:55 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:44973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfnFV-0003GE-CE for 62314@debbugs.gnu.org; Fri, 24 Mar 2023 15:38:54 -0400 Date: Fri, 24 Mar 2023 19:38:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1679686726; x=1679945926; bh=9xVl7GoIP1fXZ7mz7+y9yQrwaCaxnuWrTF/yaqC3Gg8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=KDPCc0s58Yol2MomV5wtQ/TmuEEh9bXvgjyABvdA00iflNeXFo3HoMA+e/E2l2eBa FE15Ztp5BWaLjcn8GmeQJNmrMaJgzfacdDbb1W7xyFkCuWqK1WRMrz8RCTd+/QzGbf q0QT25cdoT5iqYynDa9XSKHajeQ3BHlvPfZrQUuDzOIN74jsZPstWdTnyzQVWPki1q Dr6C77314XqI6pXWa0y3xBYShsWPZdVhWt4eXgHhmbvN4WS1yyekfrTeppAZEPXWyq gf8BOPVJOTWW/Vo4zzfTEknEyF0cx1Ti58lp0NKuRfOH6Vtl3j+R9bbTl3grGQijJr J1kYlL/UDBDJQ== Message-ID: <87355uaqip.fsf@protonmail.com> In-Reply-To: <87355y30so.fsf@nicolasgoaziou.fr> References: <87a606c00u.fsf@protonmail.com> <87355y30so.fsf@nicolasgoaziou.fr> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: John Kehayias X-Migadu-Queue-Id: E1876178FB X-Spam-Score: -0.54 X-Migadu-Spam-Score: -0.54 X-Migadu-Scanner: scn0.migadu.com X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: Jl9bApYnreAC Hi, On Tue, Mar 21, 2023 at 10:34 AM, Nicolas Goaziou wrote: > Hello, > > John Kehayias via Guix-patches via writes: > >> Subject: [PATCH] gnu: emacs-buttercup: Fix build with native >> compilation. > > Thank you. > >> + (add-after 'unpack 'fix-spy-on-test >> + (lambda _ >> + (substitute* "buttercup.el" >> + ;; The spy-on test fails with native compilation, which= was >> + ;; fixed in v1.30 but with a variable name for Emacs ne= wer >> + ;; than 28.2. Add in the same fix with the current var= iable >> + ;; name. Upstream bug and fix: >> + ;; >> + (("61880") "61880\n(comp-enable-subr-trampolines nil)\n= ")))) > > Nitpick: I'm surprised by the choice of your anchor: 61880 is at the end > of a comment. Wouldn't > > (("\\(native-comp-enable-subr-trampolines nil\\)" all) > (string-append all "\n(comp-enable-subr-trampolines nil)")) > > be more explicit? TIL what the second part of the first form for substitute is...thanks for t= hat! Yes, that is better and something I will use in the future. Thanks als= o for pushing! John