unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "宋文武 via Guix-patches via" <guix-patches@gnu.org>
To: Theofilos Pechlivanis <theofilos.pechlivanis@gmail.com>
Cc: 62582@debbugs.gnu.org
Subject: [bug#62582] [PATCH] gnu: rizin: Update to 0.5.2.
Date: Sat, 01 Apr 2023 16:39:53 +0800	[thread overview]
Message-ID: <87355kf12e.fsf@envs.net> (raw)
In-Reply-To: <8f3583db6764235cfbbc697c070860a7c0803192.1680302781.git.theofilos.pechlivanis@gmail.com> (Theofilos Pechlivanis's message of "Sat, 1 Apr 2023 01:46:53 +0300")

Theofilos Pechlivanis <theofilos.pechlivanis@gmail.com> writes:

> ---
>  gnu/packages/engineering.scm | 71 ++++++++++++++++++++++--------------
>  1 file changed, 43 insertions(+), 28 deletions(-)

Hello, there should also be files changes (for update, arguments and
inputs) description in commit message.

> +     (list #:configure-flags #~(list "-Dpackager=guix"
> +                                     (string-append "-Dpackager_version="
> +                                                    #$version)
> +                                     "-Duse_sys_capstone=enabled"

Please keep the original indention, so we can easily see what changes in
this new patch.

> +                            ;; Also skip unit tests for the same reason.
> +                            (substitute* "test/meson.build"
> +                              (("subdir\\('integration'\\)")
> +                               "")
> +                              (("subdir\\('unit'\\)")
> +                               "")))))))

Um, does all the unit tests also require testbins now?  If there are
few unit tests require testbins, I think it better to patch them out
instead of skip all tests.


Could you send an update patch, thank you!




  reply	other threads:[~2023-04-01  8:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 22:46 [bug#62582] [PATCH] gnu: rizin: Update to 0.5.2 Theofilos Pechlivanis
2023-04-01  8:39 ` 宋文武 via Guix-patches via [this message]
2023-04-01 12:19 ` [bug#62582] [PATCH v2] " Theofilos Pechlivanis
2023-04-06 15:48   ` bug#62582: [PATCH] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87355kf12e.fsf@envs.net \
    --to=guix-patches@gnu.org \
    --cc=62582@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=theofilos.pechlivanis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).