From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UMiiEr34PmTe+AAASxT56A (envelope-from ) for ; Tue, 18 Apr 2023 22:08:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CPDHEr34PmSOxwAA9RJhRA (envelope-from ) for ; Tue, 18 Apr 2023 22:08:29 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 23C9932EC4 for ; Tue, 18 Apr 2023 22:08:29 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1porcT-0007y5-Kx; Tue, 18 Apr 2023 16:08:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1porcR-0007xc-Ew for guix-patches@gnu.org; Tue, 18 Apr 2023 16:08:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1porcR-00037V-6A for guix-patches@gnu.org; Tue, 18 Apr 2023 16:08:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1porcR-000638-1y for guix-patches@gnu.org; Tue, 18 Apr 2023 16:08:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62473] [PATCH 0/4] OpenFoam update to version 10 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Apr 2023 20:08:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62473 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: reza Cc: 62473@debbugs.gnu.org, Reza Housseini Received: via spool by 62473-submit@debbugs.gnu.org id=B62473.168184843823156 (code B ref 62473); Tue, 18 Apr 2023 20:08:03 +0000 Received: (at 62473) by debbugs.gnu.org; 18 Apr 2023 20:07:18 +0000 Received: from localhost ([127.0.0.1]:60450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1porbi-00061Q-Fa for submit@debbugs.gnu.org; Tue, 18 Apr 2023 16:07:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1porbf-000615-Cj for 62473@debbugs.gnu.org; Tue, 18 Apr 2023 16:07:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1porbY-000318-7J; Tue, 18 Apr 2023 16:07:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=UWUpp1iezqmsF65txd6NGBJedcoAOWB/HzfQBCeNLQ4=; b=WUxxMIv5YFHkIaqAbm4n 1Gf+bIVJMpqIlMmpCrH7qx2ar7s47aIfswneD+G0W3j/vw+2bPBZpTjz73K4bOT+1J2I5XGkMYv66 kSbzCmrwbROC5gRNiHudp8sBfESc/ZuOecTvyJL5FBvfdEwGOBcM2v3PbOhcKUhxETWBdOiEcuTAK 3FYCE7gZoFxcFCmhRfRHz56h+EI8ihLxRcW8R595oxl23cEwK1NCBRXOZvfw/WUuxERU2Gh9JEIgA QKYOrRVjHq1it0Q/AIqRRD3Syj/VSGwOTGsOwKShJMy4F7PAZEzCzDy7YJ+9tmRz0iHqpSMlA2+nY H06qSGaJz9lmiA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1porbJ-0003AF-Dg; Tue, 18 Apr 2023 16:07:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <8e459feaf2d6a3d0f8720e72299e81259b9e6168.1680707361.git.reza@housseini.me> <0102018752a6c638-f104e797-04c3-4e5e-914e-5997a66b2c46-000000@eu-west-1.amazonses.com> <875ya9krsk.fsf_-_@gnu.org> <72de2b1c-2a2d-c640-6246-caaf71e62263@housseini.me> <010201875704d850-c6c0a8e1-e1a1-436c-8793-2d6b27bc2364-000000@eu-west-1.amazonses.com> Date: Tue, 18 Apr 2023 22:06:51 +0200 In-Reply-To: <010201875704d850-c6c0a8e1-e1a1-436c-8793-2d6b27bc2364-000000@eu-west-1.amazonses.com> (reza@housseini.me's message of "Thu, 6 Apr 2023 14:42:28 +0000") Message-ID: <87354xhs4k.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=WUxxMIv5; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681848509; a=rsa-sha256; cv=none; b=rvFXXwJ24Ghoc9FQ9IHRXdmeEZp3o83ytKKQxQuFoAn60sXpqEvkV7iuR1lGxitr1KZr+i 1y8tY9jD0PIygG34FXblJRE+PceZmt5ifSatpdKxN7j5hOpmLK2X/HrdmRbVp7MdjOoONn +tz8qlEadv5pNs0GsH1uVAEUV+dHjBS2yK599YuIQLHdAt61AVhPVD47ka3lub1+DFNxwU WQbSAy83P31tKuc23WTqMr0NNqxms+zYqnheTs5UArb14FPB3+9ScLjydh3xTtQ5MJxei0 EkeJ2ld0hkXUfzrwJ+8hSbhN1RGUbT8EbkA6zHcot0XcjWzwn7ZH2GfVxTHQhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681848509; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UWUpp1iezqmsF65txd6NGBJedcoAOWB/HzfQBCeNLQ4=; b=nv9gjFgusWqvkeCorX2kbLN8PwS++sKV07imcbxvKchO1tcbTHXJ9FWyQxCA+CIylkUI2u BXtZAvkfEiNFEBejTASEcJeJE+6Tq8EMulTQ9eompwF06UwSymSwKsWEkrBD4AZ9klYrs2 V5FqiGSOH00Xa9Jh5Ch6zCdvH9RPcioKiWlR/zakxoRG/0o0KytoGoIBTaG19vTnEJ6dvc yvnFRZFM/Y6f687jrQf9DJk6Z5H/nK6CGVa8AY/cBgpUDbn9H425fJjvr1E0yg/zZC2BCV TMIsdyttMyouJN4kYBZderFHzVL0cTQhWH3Ocko4rxv8wS7wRmmFGtkpILWiwA== X-Migadu-Spam-Score: -4.01 X-Spam-Score: -4.01 X-Migadu-Queue-Id: 23C9932EC4 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=WUxxMIv5; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: WJ5F2vUMiIx6 Hi, reza skribis: >>> +(define-public ftest >>> + (package >>> + (name "ftest") >>> + (version "bf75576064fce2e07f52cd63a3e410f12358728b") >>=20 >> That=E2=80=99s not a reasonable version string; see >> >> on how to derive version strings for Git checkouts. >>=20 >> Furthermore, when packaging a snapshot (as opposed to a tagged release), >> please add a short comment explaining why we=E2=80=99re not providing a = release. > > I'm not sure how to proceed here, there aren't any releases and it looks= =20 > more like a small side project. I included it for completness but maybe=20 > we should drop it and skip the tests for utfcpp? You can keep it; just add a comment with the explanation you wrote above, and make sure the version string is built as show in the manual page above. >>> + (build-system copy-build-system) >>> + (native-inputs (list cmake-minimal)) >>=20 >> Perhaps use =E2=80=98cmake-build-system=E2=80=99? > > There is only a CMakeLists.txt file for the tests but not for the=20 > source, shall I provide one? Oh, weird. Then just add a comment stating that and keep it this way. Thanks, Ludo=E2=80=99.