From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kP3YOddiXWRvIQAASxT56A (envelope-from ) for ; Thu, 11 May 2023 23:49:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OJTrONdiXWRJ9gAAG6o9tA (envelope-from ) for ; Thu, 11 May 2023 23:49:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 88DC83AD75 for ; Thu, 11 May 2023 23:49:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxE9p-0002Rq-Oj; Thu, 11 May 2023 17:49:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxE9m-0002Rd-Qf for guix-patches@gnu.org; Thu, 11 May 2023 17:49:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxE9m-0005ts-IL for guix-patches@gnu.org; Thu, 11 May 2023 17:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxE9m-0000po-E7 for guix-patches@gnu.org; Thu, 11 May 2023 17:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63435] Add vcmi 1.2.1 to games.scm Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 May 2023 21:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63435 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Liliana Marie Prikler , 63435@debbugs.gnu.org Cc: iyzsong@envs.net Received: via spool by 63435-submit@debbugs.gnu.org id=B63435.16838417043111 (code B ref 63435); Thu, 11 May 2023 21:49:02 +0000 Received: (at 63435) by debbugs.gnu.org; 11 May 2023 21:48:24 +0000 Received: from localhost ([127.0.0.1]:53589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxE99-0000o5-JJ for submit@debbugs.gnu.org; Thu, 11 May 2023 17:48:23 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:41184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxE97-0000nI-EH for 63435@debbugs.gnu.org; Thu, 11 May 2023 17:48:22 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id E002F1ACAB; Thu, 11 May 2023 14:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1683841692; bh=uXS5xUW1Oq4ryHEMoZkpkFHYzaB6W65re8x/3dgcPa4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=alzZFxjtcVijdauTbefHR9BNTkFO2LuewkbSmsM+BoOd8aJ0gG7iYmCaN1fF2oeo3 p0kxtHAW74TCzjhmN8HgwBB+Yd7t/oMp//yy8m9OhH9zTR73FWPawynYNTU1pK9uOZ px85fzcDOvQOk9sQh5cxMhDF0CBBPKwXNtoFi1phb5/k48K9Tau/Xb8scU5sSprMsQ 4qxiO9ha8cM/FtBtVL8NwgJYWPgc3Z+MfS9Ru7PZnzm1SoK6ouDKqY/Kwvs+VbgWW5 Zve/M0wDVHbNBFcFRI1WBzU9aL5VBU2mNYkxCT+esad/NLQ+mTvT5mPV3pA5rsqEGZ FIzvAzCJlqk3g== From: Vagrant Cascadian In-Reply-To: <51be2fdd711bf490e3a925334e571ff7871d6cbb.camel@gmail.com> References: <87a5yb4e41.fsf@wireframe> <51be2fdd711bf490e3a925334e571ff7871d6cbb.camel@gmail.com> Date: Thu, 11 May 2023 14:48:05 -0700 Message-ID: <873542o7ze.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683841751; a=rsa-sha256; cv=none; b=EIOIJvXDluB2UcqigS3J2ced7x+uO4oCGZzwBBW1U/quLuMbrVU+NCP/zc6puKPSGJLYhA lhWfD9/VS5nTqRYoVCJqU8HHyMV3tl3BNPgZrZ3uIFCVDvPsnf0BcyqfoqMQ2iVoKeBUxR yyJ7HHziyfT6OQhSQRSQKVxT12A0gq9IUqMBuDqHyBPRZbbCHhPgPSNNyjZCIt/Fwh9++3 XQvYsUHEGwgIy20cPUgIEoGVJg9FStAzPF5QL8+esfdrRP9kLzD+pzJeMDvIpe0a1MWzlC SXoLEj5WcwDLB1i1Z1wl33JMrMnYgoWZSEniRObjbRF6iKnuPC7O7ChMmFUsKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=alzZFxjt; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683841751; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=O7lkRGrn0cKu83xNgC54mPunAJ1TD+o1p2gufGGCPTQ=; b=qxFqLPo2ho85fgq+UHtRwjP2t3Ew1WPbNeyJn0xoDhX0flnPRswqaBRCVczFL/r8fopMwB TjSc7XlKd0DhFEzr867kEcX1GHPv+5XxgRn352YlbI3YCh1K+F7WnjQCZa74u8Skp1boPP qZnKM7Gi8G7hMJeoo2bDVVEIaWxm73ElrZajxIEZxF+2IcdykmrIJLo90vMMYEUi+P2s7n 65ZqOZDrMjG1EQ4oOPE65riP22wJpNKcg0er/BErTvIwJBY7OHKEX/YROH7HpgO0x7OXEN Rv+7KsynH5wzmU9BZXxGKNPdLDaalivo9m8uUom2JXji+xoapRF94HZP9qL0Kw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=alzZFxjt; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.28 X-Spam-Score: -0.28 X-Migadu-Queue-Id: 88DC83AD75 X-TUID: tBjCQNOv8U3e --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2023-05-11, Liliana Marie Prikler wrote: > Am Mittwoch, dem 10.05.2023 um 22:43 -0700 schrieb Vagrant Cascadian: >> I had successfully built with various qt*@6 packages, but they are >> not currently building; it seems to support qt*@5 too. >>=20 >> Some things failed to build with gcc-11, so I tried gcc-12 and it >> worked! > Can you elaborate what things? I doubt it makes elaborate use of > C++20/23 features, does it? Well, just retried with the default gcc, and it worked this time! so I guess I will just switch the next patch iteration back to the default gcc... >> We probably want to try to apply Debian's "privacy-breach" patch to >> disable phoning home, as well as the reproducible builds patch and >> some additional reproducibility patches I am working on, but figured >> I would submit the package to guix for review now, in case anyone >> else wants to join me down this rabbit hole... > Well, it won't be added to Guix without such patches, so someone needs > to go down this rabbit hole. Will try applying some of those patches now... >> + (native-inputs (list boost > The following lines get very long, consider breaking before (list >> + ffmpeg >> + ;; Build errors with gcc-11 >> + gcc-12 >> + ;; googletest ; needed for tests, but tests ... >> + zlib)) While I share your opinion, I tried changing it in various ways, and "guix style" changed it right back. I do not really want to fight with "guix style" too much... even if I disagree a bit with the results. >> + "@code{vcmi} is an implementation of Heroes of Might and >> +Magic III (aka HOMM3) game engine. It requires assets and game >> resources to >> +play; it will look for them at @file{~/.local/share/vcmi} folder.") > Use an @acronym or just spell it out. Presuming you mean "(aka HOMM3)" ... honestly, maybe best to just drop it entirely; I am not sure it adds much. Thanks for the review! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZF1ilQAKCRDcUY/If5cW qvMdAP4xLMP/VSGL4aO+LUBgTUOx6VgwSCQyQVo8JMoU9Sf17QEA6wC9dCnbQVGi me7o5ch+bZXp6Ov/enRDGc+V3GfiCQo= =oGY7 -----END PGP SIGNATURE----- --=-=-=--