From: "Ludovic Courtès" <ludo@gnu.org>
To: Brian Cully <bjc@spork.org>
Cc: glv@posteo.net, 62699@debbugs.gnu.org
Subject: [bug#62699] [PATCH] services: add pam-mount-volume-service-type
Date: Sun, 18 Jun 2023 23:20:22 +0200 [thread overview]
Message-ID: <87352opiw9.fsf_-_@gnu.org> (raw)
In-Reply-To: <bae7498fef43f01aa278bda4f39c298062f122c3.1680800257.git.bjc@spork.org> (Brian Cully's message of "Thu, 6 Apr 2023 12:57:43 -0400")
Hi!
Brian Cully <bjc@spork.org> skribis:
> The `pam-mount-volumes-service-type' adds additional volumes to the
> pam-mount-service-type in addition to any that are already specified in
> `pam-mount-rules'.
>
> * doc/guix.texi (PAM Mount Volume Service): add documentation for
> `pam-mount-service-type'.
> * gnu/services/pam-mount.scm (extend-pam-mount-configuration): new procedure
> (pam-mount-service-type): allow extension by other service-types
> (field-name->tag): new procedure
> (serialize-string): new procedure
> (integer-or-range?): new procedure
> (serialize-integer-or-range): new procedure
> (serialize-boolean): new procedure
> (pam-mount-volume): new configuration
> (pam-mount-volume->sxml): new procedure
> (pam-mount-volume-rules): new procedure
> (pam-mount-volume-service-type): new procedure
> * Makefile.am: add pam-mount tests
> * tests/services/pam-mount.scm: new tests
This looks useful!
Nitpick: for new files like ‘pam-mount.scm’ in this case, it’s enough to
write “New file” (relief :-)).
I’ve never used PAM mount before so I can only comment on the
implementation and doc (maybe Guillaume is more familiar with it?).
> Copyright @copyright{} 2022 Antero Mejr@*
> Copyright @copyright{} 2023 Karl Hallsby
> +Copyright @copyright{} 2023 Brian Cully
Please add @* on the previous line to insert a line break.
> +@item @code{user-id} (type: maybe-integer-or-range)
> +Mount the volume for the user with this ID. This field may also be
> +specified as a cons cell of @code{(start . end)} indicating a range of
Use the term “pair” rather than “cons cell” (throughout the section),
for consistency with the rest of the manual and to make it more
approachable.
> +(test-end "services-pam-mount")
Neat.
How hard would it be to also have a system tests under (gnu tests …)?
Seems like it would better cover functionality.
Thanks!
Ludo’.
next prev parent reply other threads:[~2023-06-18 21:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 16:43 [bug#62699] [PATCH] services: add pam-mount-volume-service-type Brian Cully via Guix-patches via
2023-04-06 16:57 ` [bug#62699] [PATCH] services: pam-mount: " Brian Cully via Guix-patches via
2023-06-18 21:20 ` Ludovic Courtès [this message]
2023-06-20 14:14 ` [bug#62699] [PATCH] services: " Brian Cully via Guix-patches via
2023-07-18 14:01 ` Brian Cully via Guix-patches via
2023-07-18 14:06 ` [bug#62699] [PATCH v2] " Brian Cully via Guix-patches via
2023-08-09 10:30 ` bug#62699: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87352opiw9.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=62699@debbugs.gnu.org \
--cc=bjc@spork.org \
--cc=glv@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).