From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2IU4LUSpmGRj5gAASxT56A (envelope-from ) for ; Sun, 25 Jun 2023 22:53:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2LpKLESpmGRISAEAG6o9tA (envelope-from ) for ; Sun, 25 Jun 2023 22:53:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 76CD1D363 for ; Sun, 25 Jun 2023 22:53:24 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDWjJ-0000LX-Ig; Sun, 25 Jun 2023 16:53:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDWjG-0000LM-Lr for guix-patches@gnu.org; Sun, 25 Jun 2023 16:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDWjG-000310-Ci for guix-patches@gnu.org; Sun, 25 Jun 2023 16:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qDWjF-0003pT-TZ for guix-patches@gnu.org; Sun, 25 Jun 2023 16:53:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64188] [PATCH 0/8] More package tuning Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 25 Jun 2023 20:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64188 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: Josselin Poiret , Tobias Geerinckx-Rice , Simon Tournier , Mathieu Othacehe , Christopher Baines , 64188@debbugs.gnu.org, Ricardo Wurmus Received: via spool by 64188-submit@debbugs.gnu.org id=B64188.168772634914676 (code B ref 64188); Sun, 25 Jun 2023 20:53:01 +0000 Received: (at 64188) by debbugs.gnu.org; 25 Jun 2023 20:52:29 +0000 Received: from localhost ([127.0.0.1]:43745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDWij-0003oe-Bq for submit@debbugs.gnu.org; Sun, 25 Jun 2023 16:52:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDWih-0003oP-Lj for 64188@debbugs.gnu.org; Sun, 25 Jun 2023 16:52:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDWic-0002sF-3J; Sun, 25 Jun 2023 16:52:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=M1L32cT6ZaHKEJdfXR/jhULyibHCwF4GcerEhGF4BZI=; b=ZLAKmcDVDDBwoYuYtuLu iyWT30r/XB6ZJENiSNaK+TUA3vOki2WmtsxW9dNCukw4tng7wZio20D/vQC63dkxrnuoTu1nEerik PolXZfALyWwY8ouJJS7Y2jjTZZWyArhYR4Dv7vVj1RCx9ik/wLN76Z70/+DOuzC5ggg18CJl6vsT8 zgrYWdZWaHMMY2x5d1bXTZtoVt19QGqnVfv7mwcZPBxTCBycby6hDuntfLnOuCMLJpcP5GhL26JtN 6sN0/1JSPt8VOEkCfsyeUfEP1R0hCr8HkdMk3lukQpxLwScqGsnT9oQ1eH+S8Zeu/9u6NeUoIzDrZ DdEFKd+QNybQvQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDWib-0001gq-LL; Sun, 25 Jun 2023 16:52:21 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Sun, 25 Jun 2023 22:52:14 +0200 In-Reply-To: (Efraim Flashner's message of "Tue, 20 Jun 2023 10:51:07 +0300") Message-ID: <87352fz2m9.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687726404; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=M1L32cT6ZaHKEJdfXR/jhULyibHCwF4GcerEhGF4BZI=; b=lwFC9oOKBnMqUQVIGay4gvXhRaiPFDErc36YRlwSdaGir7IHqY4H8Jt+3J9tIQoLa27+08 6fga9f9QrfFeOAtPkwjduuWWQtzXhm0B4ATrrnlD3N+Bh01ZpMJlryO1QMDXMoh9Ustb+H QsRbyXf52SAga3KCy213AO73hJlsT01tKMZPcGLhkT027NnsesmwjLLj1S+QjZY/8qOi/V n+nSvp3t2r/xYPzrqBbhlEMWk/E+smMSMcz+B9+e6ekuhnTQMC8Ez+vk3TmCvIUD9QDaRI WMZknMyAW2DPXEB24b9HLpTKGyL8QcIHPUbh8nmm961PeibBZm2bHlbTR+iEOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ZLAKmcDV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687726404; a=rsa-sha256; cv=none; b=Vw148FwN/ar3xhrex1v/S/Qa2BOE0p14dkSjEYHDxbXFO1fT2a2QjUwvbcwPMl5Z6N7eQT oNGyseT+AsWP2mJOpmpXm/T0exnotinsohBHwNDaNOINbPgmDZzWVwXOC45OSM//60Ktzf e3VhE4tsmIwFa23m5h6dbG6ntZihUBTCLEEGoQahfOt7nlCfp+TTTNhIr0gRVuUXStf7DP jFZ61t48IcPe24ONSv6QM7j/iaH5MECClMMPCXqI5b06Q3hZ78q8uxrv9in1aqFXxYdIEj hLW1Q8eDGoP3fmWgeBbLbtqRB4x2uhOTUlAs0HF8LpFFgrv8ChlhSrqV27+3GQ== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ZLAKmcDV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 76CD1D363 X-Spam-Score: -2.65 X-TUID: ymCJ7PcrE8Zp Efraim Flashner skribis: > * guix/transformations.scm (tuned-package)[build-system]: Don't replace > the build-system if inheriting from the go-build-system. > [arguments]: If using the go-build-system add a phase to set the > micro-architecture for Go. [...] > @@ -570,14 +571,42 @@ (define (tuned-package p micro-architecture) > (package > (inherit p) > (build-system > - (build-system-with-tuning-compiler (package-build-system p) > - micro-architecture)) > + ;; The go compiler doesn't need to be wrapped. > + ;; XXX: This is where we check for supported micro-architectures. > + (if (eq? (build-system-name (package-build-system p)) > + 'go) > + (package-build-system p) > + (build-system-with-tuning-compiler (package-build-system p) > + micro-architecture))) > (arguments > ;; The machine building this package may or may not be able to run = code > ;; for MICRO-ARCHITECTURE. Because of that, skip tests; they are r= un for > ;; the "baseline" variant anyway. > (substitute-keyword-arguments (package-arguments p) > - ((#:tests? _ #f) #f))) > + ((#:tests? _ #f) #f) > + ;; We add the tuning parameter after the default GO flags are set. > + ((#:phases phases '%standard-phases) > + (if (eq? (build-system-name (package-build-system p)) > + 'go) > + #~(modify-phases #$phases > + (add-after 'setup-go-environment 'set-microarchitecture Can we use the same approach as before with =E2=80=98build-system-with-tuning-compiler=E2=80=99? That seems more robus= t to me and it=E2=80=99d be more consistent. Ludo=E2=80=99.