From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0O0gF2h9tmQYJwEASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 13:54:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id cLCbFmh9tmR4bAEAauVa8A (envelope-from ) for ; Tue, 18 Jul 2023 13:54:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1C90B4F969 for ; Tue, 18 Jul 2023 13:54:16 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="IQraT8F/"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689681256; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WZt5ZlLh6ixpNZdFLGIMfaAm70KZuYSm+afiY8ceTlU=; b=qH0LAzKO0c+w7YUGNGQxFsAV08jpB3mArxChvSRAXsvpUWXSUpfVhN5S+UhFH59ecELnpY /oZhQE7ubbHqow9ZFxNvTTy29/822fY3XM8su/ax8GLqXPNbPwQ7Z60FRzGTsk5d0XZ+Xe gwTfeIUwPuJ2/gFAgX4TF8Cpx739YuQaFbm7taVe/qQ8NrudWPLmw43PBQNyy3BpMwKxmO GZqRgwo5L09U4Lrafph4IBhCptIWK/8ExgJTyEMnd31dzAdQ6nguXFdI+zkJ0cJvT23qjC T1CcYVDeZsgpOFqbZcjIFkQKF8rUhdBAAxGZjcbmtoN2oQ4rktI6ybtrMhRIcA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689681256; a=rsa-sha256; cv=none; b=jNS9y63i6+n34HR4/RMY1TmJt1p/n6sYGgrIPJ4Bll91f7Yy1S+XuuHRvaMv607aynvlD4 rrw+9hJ/1vvzvzCLvy1Eq0ScZiZF14EuojzqanS9XWsisNu4iggaoqHHDtIbo9EjNPd3EC Y5Jm+d7PktEEJPexKlVsH/cR/CcW1STGKs/S5R5XQ6RWSXbJ5jRu5Bpx7Ulag5+q+5CblL YoLlJAaW7Vhv9Yq6iaytDlt49E5YN8n47eyMpVIBN8YE/zfmvzxja7ACeWBLd4cMzuI8Vr bc5x61pnxlKpTBkUrVM9XeYXNumSeJtpcQKjwC5WQunZXC3eziedZHWVjDnsDA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="IQraT8F/"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLjHJ-0003ky-5I; Tue, 18 Jul 2023 07:54:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLjHH-0003kA-1G for guix-patches@gnu.org; Tue, 18 Jul 2023 07:54:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLjHG-00075R-Mm for guix-patches@gnu.org; Tue, 18 Jul 2023 07:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLjHG-0001UU-96 for guix-patches@gnu.org; Tue, 18 Jul 2023 07:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64209] [PATCH 00/14] Add ocaml-lsp-server and its dependencies Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 11:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64209 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Benjamin Cc: pukkamustard , Julien Lepiller , 64209@debbugs.gnu.org Received: via spool by 64209-submit@debbugs.gnu.org id=B64209.16896812055679 (code B ref 64209); Tue, 18 Jul 2023 11:54:02 +0000 Received: (at 64209) by debbugs.gnu.org; 18 Jul 2023 11:53:25 +0000 Received: from localhost ([127.0.0.1]:51819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLjGf-0001TW-9k for submit@debbugs.gnu.org; Tue, 18 Jul 2023 07:53:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLjGd-0001TH-9P for 64209@debbugs.gnu.org; Tue, 18 Jul 2023 07:53:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLjGW-0006vQ-Rb; Tue, 18 Jul 2023 07:53:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=WZt5ZlLh6ixpNZdFLGIMfaAm70KZuYSm+afiY8ceTlU=; b=IQraT8F/PzeK/S4hsulX 92bJUCdDQaEQvoL1BJh5OhJ/gA2LMHiLVePwosjC0gzhhBXdN6hKytvF+A82pPtfCT597JI0lzNYR kgpV8ZjOpM62Qw5OzqlRrj3Jvbi8rAGcT/ctHDAOXZL8h6D6BgAWogcfIt137PVUq2XMNc8JSqy9/ dM/NYCWrC4i1HQcXjbDQwabxj8ISE0OZv4utA6hcXbdFl9EK65Zv1jU9wTrnG8JrM3MaYahFRMTKn NrbSPE7ocpu8ek6GHzP13DisZMZ91EjlZvQFu99eyvtu8wUe8V/SDjhlNayrk/XUAYZCas4FbC1BO 68D2eG+vwqnlrw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLjGG-00071K-73; Tue, 18 Jul 2023 07:53:14 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Tue, 18 Jul 2023 13:52:56 +0200 In-Reply-To: (benjamin@uvy.fr's message of "Wed, 21 Jun 2023 17:45:41 +0200") Message-ID: <87351ll9lz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.14 X-Spam-Score: -5.14 X-Migadu-Queue-Id: 1C90B4F969 X-Migadu-Scanner: mx1.migadu.com X-TUID: GRisdGwfOJ48 Hi, Benjamin skribis: > A lot of dependencies were required, but for most of them, this is just=20 > a dune subpackage. > For ocaml-dune-build-info, note that I included the patch from [0] > and I used the same technique for other dune packages. > > The latest version of ocaml-lsp-server depends on ocaml-merlin-lib. > I added a compatible version as a new package instead of upgrading > current ocaml-merlin-lib as I was not sure if it would be safe to do so. > > Finally, the version 1.6.1 is supporting ocaml 5.0 and 5.1 [1] but I only > tested for 5.0. > Also, as 4.14 is not compatible with it, I only made public version 5.0 > of it. I do not no either if was the good thing to be done. > > I tested lsp server localy and it has been working fine with neovim for > my usage. > > [0] https://issues.guix.gnu.org/63947 > [1] https://github.com/ocaml/ocaml-lsp/blob/master/CHANGES.md#1161 I=E2=80=99m not on the OCaml team, so I=E2=80=99ll let Julien and pukkamust= ard comment. One issue: could you work on improving synopses and descriptions a bit and submit a v2, as per ? Don=E2=80=99t spend hours on this, but at least try to have sentences with a bit of context in =E2=80=98description=E2=80=99. Thanks in advance! Ludo=E2=80=99.