From: "Ludovic Courtès" <ludo@gnu.org>
To: peter@polidoro.io
Cc: 64384@debbugs.gnu.org, 64375@debbugs.gnu.org
Subject: [bug#64375] bug#64384: [PATCH 5/8] gnu: python-aiofiles: Update to 23.1.0.
Date: Mon, 02 Oct 2023 17:08:25 +0200 [thread overview]
Message-ID: <8734ythxjq.fsf_-_@gnu.org> (raw)
In-Reply-To: <b3551fe1b17622516e115dbe404ab37803c3e877.1693317569.git.peter@polidoro.io> (peter@polidoro.io's message of "Tue, 29 Aug 2023 10:01:50 -0400")
Hi Peter,
Overall the patch series LGTM, with one nitpick:
peter@polidoro.io skribis:
[...]
> + (build-system pyproject-build-system)
> + (arguments
> + `(#:tests? #f)) ; FIXME: PermissionError: [Errno 13] Permission denied: '/homeless-shelter'
Consider adding a phase that does (setenv "HOME" (getcwd)) or similar to
address this issue so you can run the test. Shipping an untested
package is something we try to avoid.
> + (home-page "https://platformio.org")
> + (synopsis
> + "Your Gateway to Embedded Software Development Excellence. Unlock the true potential of embedded software development with PlatformIO's collaborative ecosystem, embracing declarative principles, test-driven methodologies, and modern toolchains for unrivaled success.")
> + (description
> + "Your Gateway to Embedded Software Development Excellence. Unlock the true
> +potential of embedded software development with @code{PlatformIO's}
> +collaborative ecosystem, embracing declarative principles, test-driven
> +methodologies, and modern toolchains for unrivaled success.")
> + (license license:asl2.0)))
Please replace the marketing language with an actual synopsis and a
description, following the guidelines at:
https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html
‘guix lint’ may also diagnose obvious issues.
> - (url "https://github.com/john30/ebusd")
> - (commit version)))
> + (url "https://github.com/john30/ebusd")
> + (commit version)))
> (file-name (string-append name "-" version "-checkout"))
> (sha256
> (base32
> @@ -1491,14 +1529,14 @@ (define-public ebusd
> ("autoconf" ,autoconf)
> ("config"
> ,(origin
> - (method git-fetch)
> - (uri (git-reference
> - (url "https://github.com/john30/ebusd-configuration")
> - (commit "666c0f6b9c4d7545eff7f43ab28a1c7baeab7913")))
> - (file-name "config-checkout")
> - (sha256
> - (base32
> - "0yxnx8p4lbk614l16854r9s9d8s9c7ixgczfs8mph94xz0wkda7x"))))))
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/john30/ebusd-configuration")
> + (commit "666c0f6b9c4d7545eff7f43ab28a1c7baeab7913")))
> + (file-name "config-checkout")
> + (sha256
> + (base32
> + "0yxnx8p4lbk614l16854r9s9d8s9c7ixgczfs8mph94xz0wkda7x"))))))
Looks like these were unintended changes.
Could you please send an updated patch series?
Thanks,
Ludo’.
next prev parent reply other threads:[~2023-10-02 15:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 20:02 [bug#64375] [PATCH 0/8] Add python-platformio plus dependency updates peter
2023-06-30 20:02 ` [bug#64379] [PATCH 1/8] gnu: python-pyelftools: Update to 0.29 peter
2023-06-30 20:02 ` [bug#64382] [PATCH 2/8] gnu: python-sanic: Update to 21.12.2 peter
2023-06-30 20:02 ` [bug#64378] [PATCH 3/8] gnu: python-uvicorn: Update to 0.22.0 peter
2023-06-30 20:02 ` [bug#64383] [PATCH 4/8] gnu: python-starlette: Update to 0.26.0 peter
2023-06-30 20:02 ` [bug#64384] [PATCH 5/8] gnu: python-aiofiles: Update to 23.1.0 peter
2023-06-30 20:02 ` [bug#64380] [PATCH 6/8] gnu: python-tabulate: Update to 0.9.0 peter
2023-06-30 20:02 ` [bug#64377] [PATCH 7/8] gnu: python-semantic-version: Update to 2.10.0 peter
2023-06-30 20:02 ` [bug#64381] [PATCH 8/8] gnu: Add python-platformio peter
2023-08-29 14:01 ` [bug#64375] [PATCH 1/4] gnu: python-semantic-version: Update to 2.10.0 peter
2023-08-29 14:01 ` [bug#64375] [PATCH 2/4] gnu: python-sanic: Update to 21.12.2 peter
2023-08-29 14:01 ` [bug#64375] [PATCH 3/4] gnu: python-quart: Update to 0.18.4 peter
2023-08-29 14:01 ` [bug#64375] [PATCH 4/4] gnu: Add platformio peter
2023-10-02 15:08 ` Ludovic Courtès [this message]
2023-10-04 13:57 ` [bug#64375] bug#64384: [PATCH 5/8] gnu: python-aiofiles: Update to 23.1.0 Peter Polidoro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734ythxjq.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=64375@debbugs.gnu.org \
--cc=64384@debbugs.gnu.org \
--cc=peter@polidoro.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).