From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id qKSiM0ifMmUiDQEA9RJhRA:P1 (envelope-from ) for ; Fri, 20 Oct 2023 17:39:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qKSiM0ifMmUiDQEA9RJhRA (envelope-from ) for ; Fri, 20 Oct 2023 17:39:52 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8951A521B8 for ; Fri, 20 Oct 2023 17:39:52 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=cufi3Zip; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697816392; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=F3SxY+yyDTuA7OsgScSzM199hGmcfhJYuYfLKzt67FQ=; b=eWi8OYTv3rNeq6w3iDmTXu8HCalB3zwXWidDxjl6SxPRzE4oqTqICioQ2LhT2CzOL/iRR5 f0JCfelvuWgpw9+GyCQnClmtSc8iaAmLJJ+LYGEiyJ86BxxJMYv3RQz9qhds/JRYfBBzuZ G7yTVS2puqiMMlM6jGVB85KTJJdmZz+EhLAAy8cSRxFQF90bnvwRoft3USGY3TLtSuX55Y p/FDPK/nA5IjXRWPTVkWdl33BAVvEfCLjRUuBvI0mUnegdF8/6F1qMuMjrs+PHOfHBHj2N 8vTa9C8gA/Q9/N3nf1BRqpBy/T2w6lLm7bH/gMePXLYxejQ3BPuq54fTprZgeg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=cufi3Zip; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697816392; a=rsa-sha256; cv=none; b=eNB4p8HYQUNpO9IIajXI8MfSUUgLdOitoz6MqocRcMfteXwKEu6R6AHO4xjSld9Quw6p5W 9UL1i07y7QngnG2375cwlj1/bmxDg0m99f6BJAuNA9KDuJ00oS95cRQMMgOCX1n7hY3cTx 72/SbzAec9TxGYEvejYK13MU4d5ttEnCqX49mps863u4E/MqxT+ugIL1mPJexNtv7Tnbkz DDds5t+F6trBsl5oI+CZfqz6qvC2j5JAVLiq3o2lw62ir36c6MamrWBqMGHudvXu1k4cwy bWWZi6SCKDV9peGRvp5pvHpfwDKGpPvgTb11Q6Te8+sHxtkCwLFkI+uN6a8d6w== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtrb5-0004uf-KX; Fri, 20 Oct 2023 11:39:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtrb4-0004uN-VP for guix-patches@gnu.org; Fri, 20 Oct 2023 11:39:34 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtrb4-0002U3-Mp for guix-patches@gnu.org; Fri, 20 Oct 2023 11:39:34 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtrbV-0000ua-Tr for guix-patches@gnu.org; Fri, 20 Oct 2023 11:40:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42146] [PATCH core-updates 1/?] build: substitute: Don't fail silently. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2023 15:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42146 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= , Ludovic =?UTF-8?Q?Court=C3=A8s?= , 42146@debbugs.gnu.org Received: via spool by 42146-submit@debbugs.gnu.org id=B42146.16978163813474 (code B ref 42146); Fri, 20 Oct 2023 15:40:01 +0000 Received: (at 42146) by debbugs.gnu.org; 20 Oct 2023 15:39:41 +0000 Received: from localhost ([127.0.0.1]:41238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtrbB-0000ty-Bd for submit@debbugs.gnu.org; Fri, 20 Oct 2023 11:39:41 -0400 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]:54370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtrb9-0000th-7A for 42146@debbugs.gnu.org; Fri, 20 Oct 2023 11:39:39 -0400 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-7789a4c01easo59274685a.0 for <42146@debbugs.gnu.org>; Fri, 20 Oct 2023 08:39:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697816346; x=1698421146; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F3SxY+yyDTuA7OsgScSzM199hGmcfhJYuYfLKzt67FQ=; b=cufi3ZipZqp27gh/vy1VccyQgZrcynUh6ifKn1rIUNFe3ADMlKoiscPWDnO8+ZGHbA 8xh02rpb8KI91awPsoX0PhkTzvQ+qzYdgXkrP60WEhZdqfKWzfOE+E04CKOgSxRwSosz veWPmUi57J+BYVFLtRKXPJ4JdZYnDbbcKHnskWxqwLG4mEfc1m+nHDNK3xKz/608GJjq Lks4MmZWtRrf8aSLLsFK9mRfkXK6TnS85HVRtaBu35fHWeJRmDbaOIh4D6qLhQmh+s3t GH6HUu9l9165sfGcZaPeQk7QskiYmeo5uC75jfyNpfI8Vyx+q1C31m6FlcwEbDhpzGGy FAvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697816346; x=1698421146; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F3SxY+yyDTuA7OsgScSzM199hGmcfhJYuYfLKzt67FQ=; b=KcDbWKN+NlvQzuIpSBNDC6GAQm7i99QJ5kpUPvQ8GWUeGfuaAi+uUeYJHnXKYTpsfD nlcMLCkVox7pP20cQ5Tit978H1Ws0YmjV+DE9DJ9htztHKvoMENa1TYij7tbY+x+h2/M ey0nxAGq4PoU22u+ChGV3iPWzM+z99msu7s/elkPxG6ADikVcSeMtsC0gCN2xpHPecje FsI3QKmK1L/Zh3sgiupPf2Wx6l/6QfoCdWrG4nwKJEwLteVU+ujxkkHUBkiN6hjfzrnJ skePE8qPlIm/rcR+j7cWzcBeY8P35gOqPaglLi9oxA8qDqdtcuJjmviLRgajIbZOYMa8 1E5Q== X-Gm-Message-State: AOJu0Yz0x9egm4E6YJrl+dEmuuWIyyiFEpx2CR3xHYUz3cPOeuU5mOUt Lcdh/hDlwAFrr7GyK5oi4jT/C7xuv20= X-Google-Smtp-Source: AGHT+IHelFMBTH9UQ0OdAnaITOiMmu/lvjVWtsq46WxR/3LTMDiKJeZ62U1/aCrnxYESiGIeFSD3wA== X-Received: by 2002:a05:6214:2aa4:b0:66d:4d2c:b0d3 with SMTP id js4-20020a0562142aa400b0066d4d2cb0d3mr2499970qvb.4.1697816346230; Fri, 20 Oct 2023 08:39:06 -0700 (PDT) Received: from hurd (dsl-156-111.b2b2c.ca. [66.158.156.111]) by smtp.gmail.com with ESMTPSA id d9-20020a0cf0c9000000b0066d12d1351fsm751108qvl.143.2023.10.20.08.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 08:39:05 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <874jilmira.fsf@gmail.com> (Simon Tournier's message of "Fri, 20 Oct 2023 17:11:05 +0200") References: <20200630220913.14665-1-kuba@kadziolka.net> <87lebyxs4y.fsf_-_@gnu.org> <874jilmira.fsf@gmail.com> Date: Fri, 20 Oct 2023 11:39:04 -0400 Message-ID: <8734y5i9rb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 4.38 X-Spam-Score: 4.38 X-Migadu-Queue-Id: 8951A521B8 X-Migadu-Scanner: mx2.migadu.com X-TUID: J2gU0GDWJrjP Hi, Simon Tournier writes: > Hi Ludo, > > On Thu, 19 Oct 2023 at 22:40, Ludovic Court=C3=A8s wrote: > >>> +;;; >>> +;;; Extend regexp objects with a pattern field. >>> +;;; >>> +(define-record-type >>> + (%make-regexp* pat flag rx) >>> + regexp*? >>> + (pat regexp*-pattern) ;the regexp pattern, a string >>> + (flag regexp*-flag) ;regexp flags >>> + (rx regexp*-rx)) ;the compiled regexp object >>> + >>> +;;; Work around regexp implementation. >>> +;;; This record allows to track the regexp pattern and then display it. >>> +(define* (make-regexp* pat #:optional (flag regexp/extended)) >> >> I=E2=80=99m skeptical about the concrete benefits. I would not include = it in >> (guix build utils), or at least not in this patch series. >> >> (I tend to be super conservative about (guix build utils) because we >> rarely get a chance to change it.) > > If I remember correctly, the record was introduced in #58660 [1]. > Basically, if you have, > > (make-regexp "^gnu/packages/python(-.+|)\\.scm$") > > then you only have access to some #. Other said, > you lost the human-readable "^gnu/packages/python(-.+|)\\.scm$" regexp > pattern. The workaround just stores this human-readable regexp pattern. > Later, it is thus possible to display it; for debugging or else. > > For the location of such feature, I do not have an opinion. For the > concrete benefits, I have one. :-) > > Well, maybe the feature =E2=80=93 keep an access to the human-readable re= gexp > pattern =E2=80=93 could be implemented on Guile-side. Agreed, for the long haul (as with many cool bits that are Guix specific currently). --=20 Thanks, Maxim