unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: Felix Lechner <felix.lechner@lease-up.com>,
	Bruno Victal <mirai@makinata.eu>
Cc: 67497@debbugs.gnu.org
Subject: [bug#67497] [PATCH] Multiple deploy hooks in certbot service
Date: Tue, 19 Dec 2023 06:29:55 +0000	[thread overview]
Message-ID: <8734vyu2l8.fsf@systemreboot.net> (raw)
In-Reply-To: <875y0wrabr.fsf@lease-up.com>


Hi Felix,

You make good points. Having multiple deploy hooks is probably in the
spirit of the certbot project and makes for more declarative
configuration. However, I still feel that combining multiple deploy
hooks into one is better /composition/, more schemy and less complexity
for the Guix certbot service. But, if others feel that multiple deploy
hooks make sense, I am very happy to accept that.

> Your blanket opposition to this patch is incomprehensible to me from
> several angles:

And, I am not in blanket opposition to this patch. :-) I was just
contributing my two cents to the discussion. I suggested the alternative
of combining hooks just in case you had not already thought of it. I am
not invested in the certbot service. I don't even use it myself.

Regards,
Arun




      reply	other threads:[~2023-12-19  6:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87zfyzkkt4.fsf@lease-up.com>
2023-11-27 21:20 ` [bug#67497] [PATCH 1/4] In documentation, rename %certbot-deploy-hook back to %nginx-deploy-hook Felix Lechner via Guix-patches via
2023-11-27 21:20   ` [bug#67497] [PATCH 2/4] In certbot documentation, call environment variables by their proper name Felix Lechner via Guix-patches via
2023-12-16 20:58     ` Bruno Victal
2023-11-27 21:20   ` [bug#67497] [PATCH 3/4] In certbot service, reduce code duplication Felix Lechner via Guix-patches via
2023-11-27 21:20   ` [bug#67497] [PATCH 4/4] In certbot's client configuration, offer multiple deploy-hooks Felix Lechner via Guix-patches via
2023-11-28  0:24 ` [bug#67497] [PATCH] Multiple deploy hooks in certbot service Arun Isaac
2023-12-16 20:50   ` Bruno Victal
2023-12-17 17:46     ` Felix Lechner via Guix-patches via
2023-12-19  6:29       ` Arun Isaac [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734vyu2l8.fsf@systemreboot.net \
    --to=arunisaac@systemreboot.net \
    --cc=67497@debbugs.gnu.org \
    --cc=felix.lechner@lease-up.com \
    --cc=mirai@makinata.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).