unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 68488-done@debbugs.gnu.org
Subject: bug#68488: [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader.
Date: Wed, 17 Jan 2024 10:53:23 +0100	[thread overview]
Message-ID: <8734uwl20c.fsf@gnu.org> (raw)
In-Reply-To: <8591c1022344b09e865048d2c20fbb8ee3375654.1705355855.git.~@wolfsden.cz> (Tomas Volf's message of "Mon, 15 Jan 2024 22:57:35 +0100")


Hey,

> Without this change, trying to create a system image with efi-raw type while
> using grub-efi-removable-bootloader fails with fairly confusing message:
>
>     EFI bootloader required with GPT partitioning
>
> * gnu/system/image.scm (system-disk-image): Consider
> grub-efi-removable-bootloader to be EFI bootloader.

Looks good, applied. I agree the error message is misleading. Would you
like to give a try at rewording it? The goal is to prevent the failing
combination GPT + non-EFI bootloader.

Thanks,

Mathieu




      reply	other threads:[~2024-01-17  9:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 21:57 [bug#68488] [PATCH] image: Consider grub-efi-removable-bootloader to be EFI bootloader Tomas Volf
2024-01-17  9:53 ` Mathieu Othacehe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734uwl20c.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=68488-done@debbugs.gnu.org \
    --cc=~@wolfsden.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).