unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Vivien Kraus <vivien@planete-kraus.eu>, Dariqq <dariqq@posteo.net>
Cc: 68937@debbugs.gnu.org
Subject: [bug#68937] QA review for 68937
Date: Sat, 10 Feb 2024 11:11:44 +0000	[thread overview]
Message-ID: <8734u0d12b.fsf@cbaines.net> (raw)
In-Reply-To: <14bda2dd47fc43c425538d529f298a000d405f4e.camel@planete-kraus.eu>

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]


Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:

> user guix
> usertag 68937 + reviewed-looks-good
> thanks
>
> Guix QA review form submission:
> The new lint warning is Guix’ fault I think.
>
> I checked orca and it still reads the screen correctly. I’m not a
> regular user of orca.
>
> I’m not a maintainer, I’m not a committer. I’m a relatively new member
> of the GNOME team.
>
> I’ve been involved as I asked for the patches to be rebased on gnome-
> team.
>
> Items marked as checked: Package builds, Commit messages

Thanks both, unfortunately QA is not very useful for gnome-team at the
moment since it hasn't started building it. The builds for this issue
were also blocked by builtin:git-download related
failures.

The changes look fine to me though, so I've pushed both patches to
gnome-team as 952c691b51f8f5d56df69686c2785414709c7949.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2024-02-10 11:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05 15:44 [bug#68937] [PATCH 0/3] Orca fixes Dariqq
2024-02-05 15:48 ` [bug#68937] [PATCH 1/3] gnu: orca: Fix invocation errors Dariqq
2024-02-05 15:48 ` [bug#68937] [PATCH 2/3] gnu: brltty: Fix python package install Dariqq
2024-02-05 15:48 ` [bug#68937] [PATCH 3/3] gnu: orca: Add more optional dependencies Dariqq
2024-02-05 16:50 ` [bug#68937] [PATCH 0/3] Orca fixes Vivien Kraus via Guix-patches via
2024-02-05 18:32   ` Dariqq
2024-02-05 18:49 ` [bug#68937] [PATCH gnome-team v2 1/2] gnu: brltty: Fix python package install Dariqq
2024-02-05 18:49   ` [bug#68937] [PATCH gnome-team v2 2/2] gnu: orca: Add optional dependencies Dariqq
2024-02-16 19:49     ` Maxim Cournoyer
2024-02-10  8:12 ` [bug#68937] QA review for 68937 Vivien Kraus via Guix-patches via
2024-02-10 11:11   ` Christopher Baines [this message]
2024-02-10 11:15     ` bug#68937: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734u0d12b.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=68937@debbugs.gnu.org \
    --cc=dariqq@posteo.net \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).