From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id sPCAJEuI8WUiBAEAe85BDQ:P1 (envelope-from ) for ; Wed, 13 Mar 2024 12:04:43 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id sPCAJEuI8WUiBAEAe85BDQ (envelope-from ) for ; Wed, 13 Mar 2024 12:04:43 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1710327883; a=rsa-sha256; cv=none; b=Z9ZG85pLgfJ0o6jCAJYI6SjgJcnd+BzCZpwWvdQ+GrxqNpj1K58eS/fL98bkiulX9ntjbK dHdcbCdMFy6KWOGb4I68BSE2DmpBw48pOUktcnV0wkz0d53kRXoZZzqEkqG8kpNy1tC7R1 x6jGhPac+KPlkqDn2Y9sY9JH6eDR3M0FyeHjWgy9Tyi3I/96bbFFr1vY5uh25JKnVZR2WO qh8YMgc8rItCBG0lDT0Hj9Bl6stSmYNYL/pgXMHhFhHojEua3AgqLOIWjXYFGdSEdpT3xK rNW1ohXT51xgXafOK8V4SFWaB+aHHsM2jb+cqFA5ba1oLvTwO+sZIcEvMpPiog== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710327883; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=eKZ9TaRYfUIfppaS08M3OVnvkw3Pue8vWBY2TQcj1pY=; b=kPgy1I3tL8VrFutZEwfHNQmPWfcCnf8AJNeiHwEu2DGyaejIVkx0ghRXnJtNyIixijGO1p gjF+E6Cbf42yNNlEP75/EEd5Bdy6OFZPJEMQIWEada68XM+ih1gcJMuCE+01bpSqsTzTaY AAgPD39mZDWOxsO17NVM9f96QYQZSU3J8RDg4XXNiiigr669Zjcgg7/AMK/i4D6OW/Ad8y lKyqN+0Zy5ZAtTs1QU6naWcXEXDu65T1eYxWkEX8pQB1KrI29M3hyH8xfgn4JjXNLwYg2U mg5tHlmcSo6zGbR5vmh63ihyZTlAuo/q4lxExqppP0z57nFtEDRudz/9ASF/aA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F1437474D for ; Wed, 13 Mar 2024 12:04:43 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkMPQ-0007zP-Rw; Wed, 13 Mar 2024 07:04:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkMPO-0007yd-9z for guix-patches@gnu.org; Wed, 13 Mar 2024 07:04:30 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkMPL-0000Ni-4a for guix-patches@gnu.org; Wed, 13 Mar 2024 07:04:28 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rkMPu-0005Kc-4J for guix-patches@gnu.org; Wed, 13 Mar 2024 07:05:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#36451] [bug#69633] [PATCH v2] gnu: services: postgresql: Don't initdb when directory exists Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 13 Mar 2024 11:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36451 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dale Mellor Cc: 36451@debbugs.gnu.org, 69633@debbugs.gnu.org, rob@vllmrt.net X-Debbugs-Original-Cc: 36451@debbugs.gnu.org, guix-patches@gnu.org, 69633@debbugs.gnu.org, rob@vllmrt.net Received: via spool by 36451-submit@debbugs.gnu.org id=B36451.171032784520386 (code B ref 36451); Wed, 13 Mar 2024 11:05:02 +0000 Received: (at 36451) by debbugs.gnu.org; 13 Mar 2024 11:04:05 +0000 Received: from localhost ([127.0.0.1]:44774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkMOz-0005Ij-1B for submit@debbugs.gnu.org; Wed, 13 Mar 2024 07:04:05 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkMOw-0005Ia-Vr; Wed, 13 Mar 2024 07:04:04 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id C0E0927BBE2; Wed, 13 Mar 2024 11:02:56 +0000 (GMT) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 7fbaf9f9; Wed, 13 Mar 2024 11:02:56 +0000 (UTC) References: <20240308115101.2047407-1-guix-devel-0brg6b@rdmp.org> User-agent: mu4e 1.10.8; emacs 29.1 From: Christopher Baines Date: Wed, 13 Mar 2024 11:01:03 +0000 In-reply-to: <20240308115101.2047407-1-guix-devel-0brg6b@rdmp.org> Message-ID: <8734suwg0x.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -8.23 X-Spam-Score: -8.23 X-Migadu-Queue-Id: 5F1437474D X-TUID: dK2g1Nr1X+9j --=-=-= Content-Type: text/plain Dale Mellor writes: > From: Robert Vollmert > > * gnu/services/databases.scm (postgresql-activation): Check if > directory exists. > > -------------- > Dale Mellor: > > - Modified to make patch apply to head of current master branch. > - Verified working, does not break an existing system. > - Code change is clean. I think what I'm missing here is why this change is being made? I think the PostgreSQL service works at the moment, so what does this change mean? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmXxh95fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xe6TQ/9E3ToIgx8OI6xX1GUWo+bjaV+uEnyCEEu ZekVIba7Sj+mSNI0T9/8BXhboHVQMfyLeG+Z34KO4JxHIZ5XtC2E2r2iYRAQibln vfc0pV1rw/15CBPRVqLcgVS2HnOn7gPqVh0zEPA6QMc7DFqvpGVd2V8D444TPtWf j+9kTIh95cyJ7t99n2aJe4CEyef3hJVo2e+8iLJu8nVJyWwXSgjBA0X+AdDx/Gev XWeAMxlyORrBBdF6FB7U+9xbKRGHkqNznM08mDoVGsc2RxZYKNNrb5vR2XiLiDJ2 quOlrsdgG/eT//szvhZB4MKdoEMvI/9g7ExiHdxCRJCK9RpjeSgtK7nZaEWmL4ub KlI7AiO1rwFC/8q1RXvwT+IlURSRrQ+iGmupik0Gud09jyc1X5c1HAmyKMKSxXDY I53CPsibPZHO2lywtznMHf7aXgYS8Zvs+GX/jjbW+E/mawFA3acyVYxA8CYwMSzV klFz246WTeWE4mLY5pS8pPCq7+SQiUYx77By5fNCns4oQ4+Dg0FOkXFWMRCWyG48 xephCF5JG7oi9uCGjk17th2zywbriUDkD1xuYDahZy+Dcqz+uXwkIMGuFE8Mh1uH tfLgviqpC9fzif75Nv4b4vEIXb2Is5nCvSopmE+chNK+aF+M2kpH70hjhZ92bwvl eXM8jCR9F80= =eh2h -----END PGP SIGNATURE----- --=-=-=--