unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Fabio Natali <me@fabionatali.com>
Cc: 70390-done@debbugs.gnu.org, Nicolas Graves <ngraves@ngraves.fr>
Subject: bug#70390: QA review for 70390
Date: Mon, 13 May 2024 21:43:33 +0100	[thread overview]
Message-ID: <8734ql30ju.fsf@cbaines.net> (raw)
In-Reply-To: <877cfyayj7.fsf@ngraves.fr> (Nicolas Graves via Guix-patches via's message of "Mon, 13 May 2024 10:47:40 +0200")

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:

> On 2024-05-13 10:42, Nicolas Graves wrote:
>
>> user guix
>> usertag 70390 + reviewed-looks-good
>> thanks
>>
>> Guix QA review form submission:
>>
>> git should be rewritten to git-minimal and inserted a few lines down
>> instead.
>
> And probably git-minimal/pinned, see https://issues.guix.gnu.org/70656
> for instance.
>
>> Otherwise LGTM.
>>
>> Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests, New package synopsis and descriptions

Thanks both, I've tweaked the git input and pushed these patches to
master as b1de64812a0a9e30507fb1ea44611779149c32cc.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2024-05-13 20:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15  7:19 [bug#70390] [PATCH 0/2] Add s-exp support to Notmuch Fabio Natali via Guix-patches via
2024-04-15  7:25 ` [bug#70390] [PATCH 1/2] gnu: Add sfsexp Fabio Natali via Guix-patches via
2024-04-15  7:25 ` [bug#70390] [PATCH 2/2] gnu: notmuch: Add sfsexp dependency Fabio Natali via Guix-patches via
2024-05-13  8:32   ` Nicolas Graves via Guix-patches via
2024-05-13  8:38   ` Nicolas Graves via Guix-patches via
2024-05-13  8:42 ` [bug#70390] QA review for 70390 Nicolas Graves via Guix-patches via
2024-05-13  8:47   ` Nicolas Graves via Guix-patches via
2024-05-13 20:43     ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734ql30ju.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=70390-done@debbugs.gnu.org \
    --cc=me@fabionatali.com \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).