* [bug#54105] [PATCH] build-system/go: Use different default go on powerpc-linux.
@ 2022-02-22 11:08 Efraim Flashner
2024-09-12 14:43 ` Sharlatan Hellseher
0 siblings, 1 reply; 3+ messages in thread
From: Efraim Flashner @ 2022-02-22 11:08 UTC (permalink / raw)
To: 54105; +Cc: Efraim Flashner
* guix/build-system/go.scm (default-go): Return a different package
based on the target architecture.
---
guix/build-system/go.scm | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm
index 5e0e5bbad3..8330d3aa8e 100644
--- a/guix/build-system/go.scm
+++ b/guix/build-system/go.scm
@@ -3,7 +3,7 @@
;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net>
;;; Copyright © 2021-2022 Ludovic Courtès <ludo@gnu.org>
-;;; Copyright © 2021 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2021, 2022 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2021 Sarah Morgensen <iskarian@mgsn.dev>
;;;
;;; This file is part of GNU Guix.
@@ -110,8 +110,11 @@ (define %go-build-system-modules
(define (default-go)
;; Lazily resolve the binding to avoid a circular dependency.
- (let ((go (resolve-interface '(gnu packages golang))))
- (module-ref go 'go)))
+ (let ((gcc (resolve-interface '(gnu packages gcc)))
+ (golang (resolve-interface '(gnu packages golang))))
+ (if (target-ppc32?)
+ (module-ref gcc 'gccgo-11)
+ (module-ref golang 'go))))
(define (make-go-std)
(module-ref (resolve-interface '(gnu packages golang)) 'make-go-std))
base-commit: 7d72da6b07e99854751187d2694b067733fedda5
prerequisite-patch-id: 861786541b1231efceea28ba4d80d00c000a1b5e
prerequisite-patch-id: 7926cb990933a395cef6672939d171f8cd384170
--
2.34.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#54105] [PATCH] build-system/go: Use different default go on powerpc-linux.
2022-02-22 11:08 [bug#54105] [PATCH] build-system/go: Use different default go on powerpc-linux Efraim Flashner
@ 2024-09-12 14:43 ` Sharlatan Hellseher
2024-09-12 15:36 ` Efraim Flashner
0 siblings, 1 reply; 3+ messages in thread
From: Sharlatan Hellseher @ 2024-09-12 14:43 UTC (permalink / raw)
To: 54105; +Cc: Flashner
[-- Attachment #1: Type: text/plain, Size: 66 bytes --]
Hi Efraim,
Is this patch still actually to be applied?
--
Oleg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#54105] [PATCH] build-system/go: Use different default go on powerpc-linux.
2024-09-12 14:43 ` Sharlatan Hellseher
@ 2024-09-12 15:36 ` Efraim Flashner
0 siblings, 0 replies; 3+ messages in thread
From: Efraim Flashner @ 2024-09-12 15:36 UTC (permalink / raw)
To: Sharlatan Hellseher; +Cc: 54105
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Thu, Sep 12, 2024 at 03:43:21PM +0100, Sharlatan Hellseher wrote:
>
> Hi Efraim,
>
> Is this patch still actually to be applied?
Let me get back to you about that. I thought I had a newer version of
that patch somewhere. I'll have to double-check that x86_64 -> ppc32
and ppc32->x86_64 both use gccgo. I think I had to do something also
with go-std also, which isn't needed with gccgo.
--
Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-12 15:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-22 11:08 [bug#54105] [PATCH] build-system/go: Use different default go on powerpc-linux Efraim Flashner
2024-09-12 14:43 ` Sharlatan Hellseher
2024-09-12 15:36 ` Efraim Flashner
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).