unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: Rodrigo Morales <rodrigo-mailing-lists@morales.pe>,
	73111@debbugs.gnu.org
Subject: [bug#73111] [PATCH] add font-monocraft
Date: Thu, 19 Sep 2024 00:22:41 +0200	[thread overview]
Message-ID: <8734lwy53i.fsf@ngraves.fr> (raw)
In-Reply-To: <87y143xu4x.fsf@morales.pe>

On 2024-09-07 12:15, Rodrigo Morales wrote:

> This is one of my first contributions to the Guix project. If I have
> done something wrong, please let me know so that I don't make the same
> mistake in the future.

Hi Rodrigo,

Welcome !

>
> From 209787022655d89b2395e3d9c8bbd2b5417dfaf8 Mon Sep 17 00:00:00 2001
> From: Rodrigo Morales <rodrigo@morales.pe>
> Date: Sat, 7 Sep 2024 12:09:21 -0500
> Subject: [PATCH] gnu: Add font-monocraft
>
> ---
>  gnu/packages/fonts.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

A similar patch has been provide some time ago in
https://issues.guix.gnu.org/57637

At the time, it was discarded for probably being illegal software (in
the sense that Minecraft license probably doesn't allow such a
copy). This has not been researched enough to be proven, so feel free to
ask/enquire about the developper or Minecraft rights on this font.

Other than that, at first glance, your patch looks fine, except for the
lack of details in the description. It shouldn't be a copy of the
synopsis.

Closing, thanks for the patch, please open it once again if you have
good news on the license / legal subject.

-- 
Best regards,
Nicolas Graves




      reply	other threads:[~2024-09-18 22:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-07 17:15 [bug#73111] [PATCH] add font-monocraft Rodrigo Morales
2024-09-18 22:22 ` Nicolas Graves via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734lwy53i.fsf@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=73111@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    --cc=rodrigo-mailing-lists@morales.pe \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).