unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Arnaud Daby-Seesaram <ds-ac@nanein.fr>
Cc: "Hilton Chain" <hako@ultrarare.space>,
	"Ludovic Courtès" <ludo@gnu.org>,
	72714@debbugs.gnu.org
Subject: [bug#72714] [PATCH] home: services: Add 'home-sway-service-type'.
Date: Sun, 06 Oct 2024 10:15:33 +0200	[thread overview]
Message-ID: <8734l94pga.fsf@pelzflorian.de> (raw)
In-Reply-To: <877camv5yk.fsf@nanein.fr> (Arnaud Daby-Seesaram's message of "Sat, 05 Oct 2024 19:02:11 +0200")

Thank you Arnaud for this mountain of work.

Arnaud Daby-Seesaram <ds-ac@nanein.fr> writes:
> Also: given that you assisted me quite a lot, do you want me to add a
> line in the commit message to express that you helped me write the
> patch

Not for my review; this would be unusual.

Normally scm->go is probably unneeded here, because guile will find the compiled
.go file.  However program-file seems to add --no-auto-compile.  Not
sure now.

> NB: I think that the v8 can be the last version of the patch.

Otherwise yes, though I would prefer if another committer read it
again and pushed it.

Another more thing.  I try (bar (sway-bar)), but it prints an empty bar
configuration to .config/sway/config.  In patch 6, you added
no-serialization.  Did this break it?

Regards,
Florian




  reply	other threads:[~2024-10-06  8:16 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19 15:30 [bug#72714] [PATCH] home: services: Add 'home-sway-service-type' Arnaud Daby-Seesaram via Guix-patches via
2024-08-24 15:32 ` [bug#72714] [PATCH v2] " Arnaud Daby-Seesaram via Guix-patches via
2024-08-26 10:38 ` [bug#72714] [PATCH v3] " Arnaud Daby-Seesaram via Guix-patches via
2024-09-03  7:27 ` [bug#72714] [PATCH v4] " Arnaud Daby-Seesaram via Guix-patches via
2024-09-14 13:28   ` pelzflorian (Florian Pelz)
2024-09-14 14:06     ` pelzflorian (Florian Pelz)
2024-09-17  6:52     ` Arnaud Daby-Seesaram via Guix-patches via
2024-09-20 16:45       ` pelzflorian (Florian Pelz)
2024-09-22 13:43         ` Arnaud Daby-Seesaram via Guix-patches via
2024-09-25  6:58           ` pelzflorian (Florian Pelz)
2024-09-25  7:52             ` Arnaud Daby-Seesaram via Guix-patches via
2024-09-25 11:42             ` pelzflorian (Florian Pelz)
2024-09-18  8:15 ` [bug#72714] [PATCH v5] " Arnaud Daby-Seesaram via Guix-patches via
2024-09-18 18:56   ` Arnaud Daby-Seesaram via Guix-patches via
2024-09-22  8:14   ` Hilton Chain via Guix-patches via
2024-09-25  8:00 ` [bug#72714] [PATCH v6] " Arnaud Daby-Seesaram via Guix-patches via
2024-09-30 20:07   ` Ludovic Courtès
2024-10-01 22:12     ` [bug#72714] [PATCH] " Arnaud Daby-Seesaram via Guix-patches via
2024-10-02 14:08       ` pelzflorian (Florian Pelz)
2024-10-02 20:49         ` Arnaud Daby-Seesaram via Guix-patches via
2024-10-03 12:41           ` pelzflorian (Florian Pelz)
2024-10-03 20:53             ` Arnaud Daby-Seesaram via Guix-patches via
2024-10-04 20:17               ` pelzflorian (Florian Pelz)
2024-10-05 17:02                 ` Arnaud Daby-Seesaram via Guix-patches via
2024-10-06  8:15                   ` pelzflorian (Florian Pelz) [this message]
2024-10-06  9:05                     ` Arnaud Daby-Seesaram via Guix-patches via
2024-10-06  9:51                       ` pelzflorian (Florian Pelz)
2024-10-06 10:44                         ` Arnaud Daby-Seesaram via Guix-patches via
2024-10-08 16:39                           ` pelzflorian (Florian Pelz)
2024-10-08 22:33                             ` [bug#72714] [PATCH v8] " Arnaud Daby-Seesaram via Guix-patches via
2024-10-12 13:11                               ` bug#72714: " pelzflorian (Florian Pelz)
2024-10-01 22:30     ` [bug#72714] [PATCH v7] " Arnaud Daby-Seesaram via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734l94pga.fsf@pelzflorian.de \
    --to=pelzflorian@pelzflorian.de \
    --cc=72714@debbugs.gnu.org \
    --cc=ds-ac@nanein.fr \
    --cc=hako@ultrarare.space \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).