From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37364)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7zjd-0000eW-Fr
	for guix-patches@gnu.org; Tue, 09 May 2017 03:39:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7zja-0005yf-Ch
	for guix-patches@gnu.org; Tue, 09 May 2017 03:39:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:57898)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d7zja-0005yB-6j
	for guix-patches@gnu.org; Tue, 09 May 2017 03:39:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d7zjZ-0008Jl-Tu
	for guix-patches@gnu.org; Tue, 09 May 2017 03:39:01 -0400
Subject: bug#26339: [PATCH 02/18] system: Add extlinux support.
Resent-Message-ID: <handler.26339.B26339.149431550531930@debbugs.gnu.org>
References: <20170402135242.2958-1-m.othacehe@gmail.com>
	<20170402135242.2958-2-m.othacehe@gmail.com> <87mvanjepx.fsf@gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <87mvanjepx.fsf@gnu.org>
Date: Tue, 09 May 2017 09:38:11 +0200
Message-ID: <871sryqy3g.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 26339@debbugs.gnu.org, David Craven <david@craven.ch>


Hi Ludo,

> Sorry for the delay, and thanks for reminding me of this patch.

No problem :)

> The <bootloader> record would define the implementation (GRUB, extlinux,
> u-boot, etc.) while <bootloader-configuration> would be purely
> configuration.
>
> How does that sound?
>

I implemented most of this split between
bootloader-configuration/bootloader and it's waaay better !

I still have one small concern. In following patches, I added boot-type
(and boot-device) to parameters file. This allows to re-install the
correct bootloader (on the correct device) when using "guix system
switch-generation".

What field could we store in parameters to be able to restore the
correct bootloader ? 

My initial idea was to add every <bootloader> to a list, a look it up by
name to restore the correct bootloader. So we could store the bootloader
name in the parameters file. This sounds a bit hack, do you have a
better idea ?

Thanks !

Mathieu