From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46380)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d9XSn-0000ia-NF
	for guix-patches@gnu.org; Sat, 13 May 2017 09:52:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d9XSk-0003rA-IZ
	for guix-patches@gnu.org; Sat, 13 May 2017 09:52:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:39235)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d9XSk-0003qo-El
	for guix-patches@gnu.org; Sat, 13 May 2017 09:52:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d9XSk-00072C-5H
	for guix-patches@gnu.org; Sat, 13 May 2017 09:52:02 -0400
Subject: bug#26875: [v2] system: grub: Expose GRUB's interactive interface
	settings.
Resent-Message-ID: <handler.26875.B26875.149468350527018@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170511073626.GA4698@jasmine>
	<171600ab2ba65d5e2c4f730d7c1ca8aae40aa4ff.1494652860.git.leo@famulari.name>
Date: Sat, 13 May 2017 15:51:27 +0200
In-Reply-To: <171600ab2ba65d5e2c4f730d7c1ca8aae40aa4ff.1494652860.git.leo@famulari.name>
	(Leo Famulari's message of "Sat, 13 May 2017 01:21:02 -0400")
Message-ID: <871srs50gw.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 26875@debbugs.gnu.org

Hi Leo,

Leo Famulari <leo@famulari.name> skribis:

> * gnu/system/grub.scm (<grub-configuration>): Add new fields
> terminal-outputs, terminal-inputs, serial-unit, and serial-speed.
> (grub-setup-io, setup-gfxterm): New procedures.
> * doc/guix.texi (GRUB Configuration): Document the new fields.

Overall LGTM.  Nice to see it taking shape!

Some minor comments and suggestions:

> +@item @code{terminal-outputs} (default: @code{'gfxterm})
> +The output terminals used for the GRUB boot menu, as a list of symbols.
> +These values are accepted: console, serial, serial_@{0-3@}, gfxterm,
> +vga_text, mda_text, morse, spkmodem

Please use @code for the possible, add a final period, and a
cross-reference to the relevant part of the GRUB manual with
=E2=80=9C(@pxref{=E2=80=A6})=E2=80=9D if possible.

> +@item @code{terminal-inputs} (default: @code{'()})
> +The input terminals used for the GRUB boot menu, as a list of symbols.
> +The default is the native platform terminal as determined by GRUB at
> +run-time.  These values are accepted: console, serial, serial_@{0-3@},
> +at_keyboard, usb_keyboard.
> +
> +@item @code{serial-unit} (default: @code{#f})
> +The serial unit used by GRUB, as an integer from 0 to 3.  The default
> +value is chosen by GRUB at run-time; currently GRUB chooses 0, which
> +corresponds to COM1.

Likewise.

> +@item @code{serial-speed} (default: @code{#f})
> +The speed of the serial interface, as an integer.  The default value is
> +chosen by GRUB at run-time; currently GRUB chooses 9600bps.

9,600@tie{}bps.  :-)

Apart from that, as long as =E2=80=9Cmake check-system TESTS=3Dbasic=E2=80=
=9D and similar
pass, that=E2=80=99s all good for me!

Mathieu: is it OK to apply this before the patch series on non-GRUB
bootloaders?

Thanks,
Ludo=E2=80=99.