From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52378)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dAM86-0001GJ-S2
	for guix-patches@gnu.org; Mon, 15 May 2017 15:58:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dAM83-0003w6-0e
	for guix-patches@gnu.org; Mon, 15 May 2017 15:58:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:44286)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dAM82-0003vw-T8
	for guix-patches@gnu.org; Mon, 15 May 2017 15:58:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dAM82-00077T-KE
	for guix-patches@gnu.org; Mon, 15 May 2017 15:58:02 -0400
Subject: bug#26803: [PATCH 36/36] gnu: Add java-commons-compress.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.26803.D26803.149487823527311.done@debbugs.gnu.org>
References: <20170506153617.3074-1-rekado@elephly.net>
	<20170506153617.3074-36-rekado@elephly.net> <rbushkbpyea.fsf@gnu.org>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <rbushkbpyea.fsf@gnu.org>
Date: Mon, 15 May 2017 21:56:54 +0200
Message-ID: <871srp7v21.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: 26803-done@debbugs.gnu.org


Roel Janssen <roel@gnu.org> writes:

> Ricardo Wurmus writes:
>
>> * gnu/packages/java.scm (java-commons-compress): New variable.
>> ---
[…]
>> +    (arguments
>> +     `(#:jar-name "commons-compress.jar"
>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'delete-bad-tests
>> +           (lambda _
>> +             (with-directory-excursion "src/test/java/org/apache/commons/compress/"
>> +               ;; FIXME: These tests really should not fail.  Maybe they are
>> +               ;; indicative of problems with our Java packaging work.
>
> We should definitely take note of this.

Indeed.  This really looks like a problem with the ant-build-system as I
wrote in another email.

> I think this concludes the first batch of Java packages.
>
> Thanks a lot for this very important work!

Yay!  Thank you so much for taking the time to review this mess!
I’m closing this bug and will push the remaining packages in a moment.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net