From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPE5i-0002yd-87 for guix-patches@gnu.org; Sun, 25 Jun 2017 16:25:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPE5f-0000IS-37 for guix-patches@gnu.org; Sun, 25 Jun 2017 16:25:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34987) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dPE5e-0000II-Uy for guix-patches@gnu.org; Sun, 25 Jun 2017 16:25:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dPE5e-00046G-JD for guix-patches@gnu.org; Sun, 25 Jun 2017 16:25:02 -0400 Subject: [bug#27483] [PATCH] gnu: Add python-pass-git-helper. Resent-Message-ID: References: <20170625123947.5031-1-jlicht@fsfe.org> <1205d2af.AEEAMX9gutkAAAAAAAAAAAPFxFYAAAACwQwAAAAAAAW9WABZT_F4@mailjet.com> From: Jelle Licht In-reply-to: <1205d2af.AEEAMX9gutkAAAAAAAAAAAPFxFYAAAACwQwAAAAAAAW9WABZT_F4@mailjet.com> Date: Sun, 25 Jun 2017 19:56:57 +0200 Message-ID: <871sq83q8m.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 27483@debbugs.gnu.org --=-=-= Content-Type: text/plain Arun Isaac writes: > Thanks for the patch! > >> +(define-public python-pass-git-helper >> + (package >> + (name "python-pass-git-helper") > > Since, this is an application, not a python library, this package should > not have the "python-" prefix. It should just be called pass-git-helper. > >> + (version "0.3") > > The latest version is 0.3.1. However, this is only available on the > project's github releases page. Could you try with that? > > https://github.com/languitar/pass-git-helper/releases > >> + (description >> + "A git credential helper implementation which allows to use pass, the >> +standard unix password manager, as the credential backend for your git >> +repositories. This is achieved by explicitly defining mappings between hosts >> +and entries in the password store.") > > Descriptions should use full sentences. Could you rephrase the first > sentence to comply? > > https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html > >> + (license license:lgpl3))) > > The license is lgpl3+. Look at line 17 of setup.py. > > Everything else LGTM. Could you send an updated patch? Done! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-pass-git-helper.patch >From 9b818abc4d313f42efa6f052830050b0e376a073 Mon Sep 17 00:00:00 2001 From: Jelle Licht Date: Sun, 25 Jun 2017 14:38:40 +0200 Subject: [PATCH] gnu: Add pass-git-helper. * gnu/packages/password-utils.scm (pass-git-helper): New variable. --- gnu/packages/password-utils.scm | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm index 9cfacdb42..bad52dd22 100644 --- a/gnu/packages/password-utils.scm +++ b/gnu/packages/password-utils.scm @@ -37,6 +37,7 @@ #:use-module (gnu packages aidc) #:use-module (gnu packages base) #:use-module (gnu packages compression) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages glib) #:use-module (gnu packages gnupg) #:use-module (gnu packages gtk) @@ -410,3 +411,39 @@ Password Scheme\"} by Niels Provos and David Mazieres.") (define-public python2-bcrypt (package-with-python2 python-bcrypt)) + +(define-public pass-git-helper + (package + (name "pass-git-helper") + (version "0.3.1") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/languitar/pass-git-helper/" + "archive/release-" version ".tar.gz")) + (sha256 + (base32 + "0lz5ncy44pz7z1j2nnyildx8sq33zi3xvg5nkwg25n11nasqh2xn")))) + (build-system python-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'build 'patch-pass-path + (lambda* (#:key inputs #:allow-other-keys) + (let* ((password-store (assoc-ref inputs "password-store")) + (pass (string-append password-store + "/bin/pass"))) + (substitute* "pass-git-helper" + (("'pass'") (string-append "'" pass "'"))) + #t)))))) + (inputs + `(("python-pyxdg" ,python-pyxdg) + ("password-store" ,password-store))) + (home-page "https://github.com/languitar/pass-git-helper") + (synopsis "Git credential helper interfacing with pass") + (description + "pass-git-helper is a git credential helper which allows to use pass, the +standard unix password manager, as the credential backend for your git +repositories. This is achieved by explicitly defining mappings between hosts +and entries in the password store.") + (license license:lgpl3+))) -- 2.13.1 --=-=-=--