From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnPFS-0007GU-2B for guix-patches@gnu.org; Thu, 31 Aug 2017 09:11:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnPFO-0007Uk-2j for guix-patches@gnu.org; Thu, 31 Aug 2017 09:11:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56061) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnPFN-0007Ug-Vf for guix-patches@gnu.org; Thu, 31 Aug 2017 09:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dnPFN-00073i-Ps for guix-patches@gnu.org; Thu, 31 Aug 2017 09:11:01 -0400 Subject: [bug#28262] [PATCH] Handle the same HTTP redirects everywhere. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170828134610.30984-1-me@tobias.gr> Date: Thu, 31 Aug 2017 15:10:12 +0200 In-Reply-To: <20170828134610.30984-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Mon, 28 Aug 2017 15:46:10 +0200") Message-ID: <871snrsx1n.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 28262@debbugs.gnu.org Hey Tobias, Tobias Geerinckx-Rice skribis: > * guix/download.scm (http-fetch): Complete the hard-coded list of HTTP > redirect status codes. Actually guix/build/download.scm. > * guix/http-client.scm (http-fetch): Likewise. > * guix/scripts/lint.scm (probe-uri): Likewise. > --- > > Guix, > > There are three (that I know of) hard-coded lists of HTTP redirect status > codes in Guix. All were different, and all were incomplete. > > This patch doesn't address the duplication, but does add all missing > codes. Specifically the newer HTTP/1.1 codes, including 303 =E2=80=98See = Other=E2=80=99. > It's not strictly a plain redirect, but used as such in the wild[1], and > treating it as such is probably enough for our purposes. > > This allows at least lightdm-gtk-greeter to be built again. Why its > sources waren't mirrored to begin with I do not know, nor did I check. Good catch, go for it! As a followup, we should look into merging the two =E2=80=98http-fetch=E2= =80=99 procedures. I don=E2=80=99t think the initial motivation for having two separate implementations still holds. Thanks, Ludo=E2=80=99.