From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2vIE-0003Eo-33 for guix-patches@gnu.org; Fri, 13 Oct 2017 04:26:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2vIA-000458-2B for guix-patches@gnu.org; Fri, 13 Oct 2017 04:26:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56365) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2vI9-00044t-Uq for guix-patches@gnu.org; Fri, 13 Oct 2017 04:26:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e2vI9-0006NQ-Nd for guix-patches@gnu.org; Fri, 13 Oct 2017 04:26:01 -0400 Subject: [bug#27344] [PATCH v3 7/8] gnu: Add qucs. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87h8v4gur5.fsf@foradis.org> Date: Fri, 13 Oct 2017 10:25:00 +0200 In-Reply-To: <87h8v4gur5.fsf@foradis.org> (Theodoros Foradis's message of "Thu, 12 Oct 2017 20:07:26 +0300") Message-ID: <871sm7sbdv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Theodoros Foradis Cc: 27344@debbugs.gnu.org Theodoros Foradis skribis: > Ludovic Court=C3=A8s writes: > >> Hi, >> >> Theodoros Foradis skribis: >> >>> * gnu/packages/engineering.scm (qucs): New variable. >> >> [...] >> >>> + (propagated-inputs >>> + `(("gcc-toolchain" ,gcc-toolchain-5))) ; for freehdl >> >> What=E2=80=99s the reason for this? >> >> Propagated inputs should be used sparsely because they =E2=80=9Cpollute= =E2=80=9D user >> profiles. Here we=E2=80=99d be forcing a big package, and a specific ve= rsion of >> that, in user profiles, which is not OK. >> >> Apart from that the patch LGTM though, so if we can remove these two >> lines, we can commit. > > Freehdl is a VHDL to C compiler, so for qucs and qucs-s to be able to do > VHDL simulations, there should be a gcc toolchain and libtool in the > user environment (libtool should be propagated as well, after the phase > removal from the freehdl package). So does qucs invoke the C compiler? Or is it FreeHDL? Or the user? That one that invokes the C compiler should have its fine name hard-coded. Well, except if it=E2=80=99s the user. ;-) Hard-coding is preferable over propagation, to avoid =E2=80=9Cpolluting=E2= =80=9D user profiles. > I think it *should* be OK to remove gcc-toolchain from the > propagated-inputs, if we provide the user with some kind of message, > that they should add a gcc-toolchain and libtool in their environment if > they want to do VHDL simulations. > > Maybe it should be preferable to add a message along those lines in the > package descriptions of those 2 packages (qucs and qucs-s)? I think we shouldn=E2=80=99t abuse descriptions to give instructions. It s= hould Just Work, as much as possible. (Though I reckon that in some cases it would be nice to associate an message with packages that would be displayed upon installation.) Thanks, Ludo=E2=80=99.