From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGh9b-0003kz-Ru
	for guix-patches@gnu.org; Mon, 20 Nov 2017 03:10:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGh9V-0000xW-Uv
	for guix-patches@gnu.org; Mon, 20 Nov 2017 03:10:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:39533)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eGh9V-0000xM-SU
	for guix-patches@gnu.org; Mon, 20 Nov 2017 03:10:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGh9V-0004GN-Mo
	for guix-patches@gnu.org; Mon, 20 Nov 2017 03:10:01 -0500
Subject: [bug#29359] [PATCH 24/31] gnu: Add java-kxml2.
Resent-Message-ID: <handler.29359.B29359.151116536916341@debbugs.gnu.org>
References: <handler.29359.B.151111429223890.ack@debbugs.gnu.org>
	<20171119175805.902-1-julien@lepiller.eu>
	<20171119175805.902-24-julien@lepiller.eu>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20171119175805.902-24-julien@lepiller.eu>
Date: Mon, 20 Nov 2017 09:09:20 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID: <871sktxtfz.fsf@elephly.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 29359@debbugs.gnu.org


Hi Julien,

> * gnu/packages/java.scm (java-kxml2): New variable.

Add to (gnu packages xml) instead?

> +    (arguments
> +     `(#:jar-name "kxml2.jar"
> +       #:source-dir "src/main/java"
> +       #:test-include (list "TestWb.java")
> +       #:tests? #f)); Test fails

Is this a FIXME or something that cannot be fixed?

> +    (inputs
> +     `(("java-xpp3" ,java-xpp3)))
> +    (native-inputs
> +     `(("java-junit" ,java-junit)))
> +    (home-page "http://kxml.org")
> +    (synopsis "XML pull parser")
> +    (description "kXML is a small XML pull parser, specially designed fo=
r
> +constrained environments such as Applets, Personal Java or MIDP
> devices.")

Maybe expand =E2=80=9CMIDP=E2=80=9D to =E2=80=9Cdevices compliant with the =
Mobile Information
Device Profile=E2=80=9D?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net