From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59823)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eILej-0007gv-UO
	for guix-patches@gnu.org; Fri, 24 Nov 2017 16:37:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eILeg-0001Oa-R5
	for guix-patches@gnu.org; Fri, 24 Nov 2017 16:37:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:47836)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eILeg-0001OW-Mi
	for guix-patches@gnu.org; Fri, 24 Nov 2017 16:37:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eILeg-0001yD-Ef
	for guix-patches@gnu.org; Fri, 24 Nov 2017 16:37:02 -0500
Subject: [bug#29409] [PATCH] vm: Use os-defined initrd intead of base-initrd.
Resent-Message-ID: <handler.29409.B29409.15115594057545@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <877euhtjkj.fsf@gmail.com>
	<1511542178-13819-1-git-send-email-m.othacehe@gmail.com>
Date: Fri, 24 Nov 2017 22:36:42 +0100
In-Reply-To: <1511542178-13819-1-git-send-email-m.othacehe@gmail.com> (Mathieu
	Othacehe's message of "Fri, 24 Nov 2017 17:49:38 +0100")
Message-ID: <871skn8il1.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 29409@debbugs.gnu.org

Hello!

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * gnu/system/vm.scm (system-disk-image, system-qemu-image,
>   virtualized-operating-system): Replace base-initrd by
>   (operating-system-initrd os).
>
> The system produced were always using base-initrd even if the user had
> defined a custom initrd based on raw-initrd in the os declaration.

[...]

>      (initrd (lambda (file-systems . rest)
> -              (apply base-initrd file-systems
> +              (apply (operating-system-initrd os)
> +                     file-systems
>                       #:volatile-root? #t
>                       #:virtio? #t
>                       rest)))

A potential issue is that we don=E2=80=99t know whether the user-provided i=
nitrd
procedure honors #:volatile-root? et al.  Maybe that=E2=80=99s not much of a
problem in practice: we can assume that it=E2=80=99s up to the user to do t=
he
right thing.

I=E2=80=99d say go for it and we=E2=80=99ll adjust if/when it=E2=80=99s a p=
roblem.

Thoughts?

Thanks,
Ludo=E2=80=99.