[bug#29536] [PATCH] gnu: Add cava.

[bug#29536] [PATCH] gnu: Add cava.

[Oleg Pykhalov]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH] gnu: Add cava. --]
[-- Type: text/x-patch, Size: 2411 bytes --]

From 972835bcf71b67d2bc12c3d7a6bb80f51f0d0efa Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Sat, 2 Dec 2017 22:36:36 +0300
Subject: [PATCH] gnu: Add cava.

* gnu/packages/audio.scm (cava): New variable.
---
 gnu/packages/audio.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index da9314392..347f379e3 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3087,3 +3087,46 @@ mixers.")
 customized and extended using either the s7 Scheme implementation (included in
 the Snd sources), Ruby, or Forth.")
     (license (license:non-copyleft "file://COPYING"))))
+
+(define-public cava
+  (package
+    (name "cava")
+    (version "0.6.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/karlstav/cava/archive/"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1p24lz3h4d0h82ffylqr7mq8a8x1c66flm2r2bsv1liw51n1rma2"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)))
+    (inputs
+     `(("fftw"       ,fftw)
+       ("ncurses"    ,ncurses)
+       ("pulseaudio" ,pulseaudio)))
+    (arguments
+     `(#:configure-flags
+       (list (string-append "PREFIX=" %output)
+             (string-append "FONT_DIR=" %output "/usr/share/consolefonts"))
+       #:make-flags ; Add $libdir to the RUNPATH of all the executables.
+       (let ((lib (string-append %output "/lib")))
+         (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib)))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'bootstrap
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (zero? (system* "sh" "autogen.sh"))))
+         (add-before 'build 'make-cava-ldflags
+           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/lib")))))))
+    (home-page "https://karlstav.github.io/cava/")
+    (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio")
+    (description "@code{cava} provides a command line audio visualizer for
+MPD, Alsa and Pulseaudio.")
+    (license license:expat)))
-- 
2.15.0

[bug#29536] [PATCH] squash! gnu: Add cava.

[Oleg Pykhalov]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH] squash! gnu: Add cava. --]
[-- Type: text/x-patch, Size: 1169 bytes --]

From a9d052f3ef8abcb830f279a09d99c9b6e7a0ad02 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Sat, 2 Dec 2017 22:39:01 +0300
Subject: [PATCH] squash! gnu: Add cava.

---
 gnu/packages/audio.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 347f379e3..e4481281f 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3105,7 +3105,7 @@ the Snd sources), Ruby, or Forth.")
     (native-inputs
      `(("autoconf" ,autoconf)
        ("automake" ,automake)
-       ("libtool" ,libtool)))
+       ("libtool"  ,libtool)))
     (inputs
      `(("fftw"       ,fftw)
        ("ncurses"    ,ncurses)
@@ -3114,7 +3114,7 @@ the Snd sources), Ruby, or Forth.")
      `(#:configure-flags
        (list (string-append "PREFIX=" %output)
              (string-append "FONT_DIR=" %output "/usr/share/consolefonts"))
-       #:make-flags ; Add $libdir to the RUNPATH of all the executables.
+       #:make-flags
        (let ((lib (string-append %output "/lib")))
          (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib)))
        #:phases
-- 
2.15.0

[bug#29536] [PATCH] gnu: Add cava.

[ng0]

[-- Attachment #1: Type: text/plain, Size: 3096 bytes --]

Hi,

which patch would someone review? Aren't they supposed to be one patch?
We don't have cava (as you are obviously adding it) and the 2nd patch
makes a change to cava.
We try to logically group patches, and this is a case where having it
in one patch makes sense, when a new package is getting added.

Oleg Pykhalov transcribed 2.4K bytes:
> From 972835bcf71b67d2bc12c3d7a6bb80f51f0d0efa Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Sat, 2 Dec 2017 22:36:36 +0300
> Subject: [PATCH] gnu: Add cava.
> 
> * gnu/packages/audio.scm (cava): New variable.
> ---
>  gnu/packages/audio.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index da9314392..347f379e3 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -3087,3 +3087,46 @@ mixers.")
>  customized and extended using either the s7 Scheme implementation (included in
>  the Snd sources), Ruby, or Forth.")
>      (license (license:non-copyleft "file://COPYING"))))
> +
> +(define-public cava
> +  (package
> +    (name "cava")
> +    (version "0.6.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/karlstav/cava/archive/"
> +                    version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1p24lz3h4d0h82ffylqr7mq8a8x1c66flm2r2bsv1liw51n1rma2"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)))
> +    (inputs
> +     `(("fftw"       ,fftw)
> +       ("ncurses"    ,ncurses)
> +       ("pulseaudio" ,pulseaudio)))
> +    (arguments
> +     `(#:configure-flags
> +       (list (string-append "PREFIX=" %output)
> +             (string-append "FONT_DIR=" %output "/usr/share/consolefonts"))
> +       #:make-flags ; Add $libdir to the RUNPATH of all the executables.
> +       (let ((lib (string-append %output "/lib")))
> +         (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib)))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'bootstrap
> +           (lambda _
> +             (setenv "HOME" (getcwd))
> +             (zero? (system* "sh" "autogen.sh"))))
> +         (add-before 'build 'make-cava-ldflags
> +           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/lib")))))))
> +    (home-page "https://karlstav.github.io/cava/")
> +    (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio")
> +    (description "@code{cava} provides a command line audio visualizer for
> +MPD, Alsa and Pulseaudio.")
> +    (license license:expat)))
> -- 
> 2.15.0
> 
> 
> 
> 
> 

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#29536] [PATCH] gnu: Add cava.

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

Hello ng0,

ng0 <ng0@n0.is> writes:

> which patch would someone review? Aren't they supposed to be one patch?
> We don't have cava (as you are obviously adding it) and the 2nd patch
> makes a change to cava.
> We try to logically group patches, and this is a case where having it
> in one patch makes sense, when a new package is getting added.

[...]

Sorry for that.  The second patch are just minor things (indent and
remove missleading comment).  It expected to be squashed as patch's
message says.


I also think about adding an example of configuration from origin
tarball as I did https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29535

cava unlike cli-visualizer creates a configuration file for the first
time, but it's empty and useless without example or documentation.


Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#29536] [PATCH] gnu: Add cava.

[Oleg Pykhalov]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH] gnu: Add cava. --]
[-- Type: text/x-patch, Size: 2720 bytes --]

From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Sat, 2 Dec 2017 22:36:36 +0300
Subject: [PATCH] gnu: Add cava.

* gnu/packages/audio.scm (cava): New variable.
---
 gnu/packages/audio.scm | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index da9314392..97de6b024 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3087,3 +3087,52 @@ mixers.")
 customized and extended using either the s7 Scheme implementation (included in
 the Snd sources), Ruby, or Forth.")
     (license (license:non-copyleft "file://COPYING"))))
+
+(define-public cava
+  (package
+    (name "cava")
+    (version "0.6.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/karlstav/cava/archive/"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1p24lz3h4d0h82ffylqr7mq8a8x1c66flm2r2bsv1liw51n1rma2"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool"  ,libtool)))
+    (inputs
+     `(("fftw"       ,fftw)
+       ("ncurses"    ,ncurses)
+       ("pulseaudio" ,pulseaudio)))
+    (arguments
+     `(#:configure-flags
+       (list (string-append "PREFIX=" %output)
+             (string-append "FONT_DIR=" %output "/usr/share/consolefonts"))
+       #:make-flags
+       (let ((lib (string-append %output "/lib")))
+         (list (string-append "cava_LDFLAGS = -L" lib " -Wl,-rpath " lib)))
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'bootstrap
+           (lambda _
+             (setenv "HOME" (getcwd))
+             (zero? (system* "sh" "autogen.sh"))))
+         (add-before 'build 'make-cava-ldflags
+           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/lib"))))
+         (add-after 'install 'data
+           (lambda _ (for-each (lambda (file)
+                            (install-file file (string-append
+                                                (assoc-ref %outputs "out")
+                                                "/share/doc/examples")))
+                          (find-files "example_files")))))))
+    (home-page "https://karlstav.github.io/cava/")
+    (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio")
+    (description "@code{cava} provides a command line audio visualizer for
+MPD, Alsa and Pulseaudio.")
+    (license license:expat)))
-- 
2.15.0

[bug#29536] [PATCH] gnu: Add cava.

[Ludovic Courtès]

Heya Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

>>From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Sat, 2 Dec 2017 22:36:36 +0300
> Subject: [PATCH] gnu: Add cava.
>
> * gnu/packages/audio.scm (cava): New variable.

[...]

> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'bootstrap
> +           (lambda _
> +             (setenv "HOME" (getcwd))
> +             (zero? (system* "sh" "autogen.sh"))))

Please use ‘invoke’ instead of ‘system*’.

> +         (add-before 'build 'make-cava-ldflags
> +           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/lib"))))

Please use:

  (lambda* (#:key outputs #:allow-other-keys)
    … outputs …)

> +         (add-after 'install 'data
> +           (lambda _ (for-each (lambda (file)
> +                            (install-file file (string-append
> +                                                (assoc-ref %outputs "out")
> +                                                "/share/doc/examples")))
> +                          (find-files "example_files")))))))

Likewise.

> +    (home-page "https://karlstav.github.io/cava/")
> +    (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio")

Rather: “Console audio visualizer for ALSA, MPD, and PulseAudio”.

> +    (description "@code{cava} provides a command line audio visualizer for
> +MPD, Alsa and Pulseaudio.")

Based on their README:

  C.A.V.A. is a bar audio spectrum visualizer for the terminal using
  ALSA, MPD, PulseAudio, or a FIFO buffer as its input.

OK with these changes, thank you!

Ludo’.

[bug#29536] [PATCH] gnu: Add cava.

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

Hello Ludovic,

Thank you for review!

ludo@gnu.org (Ludovic Courtès) writes:

>>>>From af48537fc5c6af11993db03004a937251d8d60e9 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Sat, 2 Dec 2017 22:36:36 +0300
>> Subject: [PATCH] gnu: Add cava.
>>
>> * gnu/packages/audio.scm (cava): New variable.
>
> [...]
>
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'bootstrap
>> +           (lambda _
>> +             (setenv "HOME" (getcwd))
>> +             (zero? (system* "sh" "autogen.sh"))))
>
> Please use ‘invoke’ instead of ‘system*’.

This is new.  OK, will use.  Thank you for notice!

>> +         (add-before 'build 'make-cava-ldflags
>> +           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/lib"))))
>
> Please use:
>
>   (lambda* (#:key outputs #:allow-other-keys)
>     … outputs …)

Should be this?

    (lambda* (#:key outputs #:allow-other-keys)
      … (assoc-ref outputs "out") …)

>> +         (add-after 'install 'data
>> +           (lambda _ (for-each (lambda (file)
>> +                            (install-file file (string-append
>> +                                                (assoc-ref %outputs "out")
>> +                                                "/share/doc/examples")))
>> +                          (find-files "example_files")))))))
> Likewise.

OK.

>> +    (home-page "https://karlstav.github.io/cava/")
>> +    (synopsis "CLI audio visualizer for Alsa, MPD and Pulseaudio")
>
> Rather: “Console audio visualizer for ALSA, MPD, and PulseAudio”.

OK.

>> +    (description "@code{cava} provides a command line audio visualizer for
>> +MPD, Alsa and Pulseaudio.")
>
> Based on their README:
>
>   C.A.V.A. is a bar audio spectrum visualizer for the terminal using
>   ALSA, MPD, PulseAudio, or a FIFO buffer as its input.

OK.

> OK with these changes, thank you!

Pushed as c2c0d66162152b05fc42fdd1be5f07b9eca3bc66

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]