From: Oleg Pykhalov <go.wigust@gmail.com>
To: ng0 <ng0@n0.is>
Cc: 29536@debbugs.gnu.org
Subject: [bug#29536] [PATCH] gnu: Add cava.
Date: Sun, 03 Dec 2017 10:16:18 +0300 [thread overview]
Message-ID: <871skcwabh.fsf@gmail.com> (raw)
In-Reply-To: <20171202220708.cg6xnqca7ovul5ng@abyayala> (ng0@n0.is's message of "Sat, 2 Dec 2017 22:07:08 +0000")
[-- Attachment #1: Type: text/plain, Size: 787 bytes --]
Hello ng0,
ng0 <ng0@n0.is> writes:
> which patch would someone review? Aren't they supposed to be one patch?
> We don't have cava (as you are obviously adding it) and the 2nd patch
> makes a change to cava.
> We try to logically group patches, and this is a case where having it
> in one patch makes sense, when a new package is getting added.
[...]
Sorry for that. The second patch are just minor things (indent and
remove missleading comment). It expected to be squashed as patch's
message says.
I also think about adding an example of configuration from origin
tarball as I did https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29535
cava unlike cli-visualizer creates a configuration file for the first
time, but it's empty and useless without example or documentation.
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-12-03 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 19:37 [bug#29536] [PATCH] gnu: Add cava Oleg Pykhalov
2017-12-02 19:40 ` [bug#29536] [PATCH] squash! " Oleg Pykhalov
2017-12-02 22:07 ` [bug#29536] [PATCH] " ng0
2017-12-03 7:16 ` Oleg Pykhalov [this message]
2017-12-03 7:34 ` Oleg Pykhalov
2018-01-19 23:51 ` Ludovic Courtès
2018-01-25 19:49 ` Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871skcwabh.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=29536@debbugs.gnu.org \
--cc=ng0@n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).