From: ludo@gnu.org (Ludovic Courtès)
To: Adam Van Ymeren <adam@vany.ca>
Cc: 28973@debbugs.gnu.org
Subject: [bug#28973] [PATCH 1/1] gnu: Add strongswan.
Date: Tue, 30 Jan 2018 22:22:57 +0100 [thread overview]
Message-ID: <871si7vy6m.fsf@gnu.org> (raw)
In-Reply-To: <87mv1eeu6i.fsf@vany.ca> (Adam Van Ymeren's message of "Mon, 15 Jan 2018 15:36:05 -0500")
Hi,
Adam Van Ymeren <adam@vany.ca> skribis:
> Okay updated patch below. I pulled all the copyright information from
> the debian package. Added configure arguments to avoid compiling source
> files which are 4-clause BSD licensed.
>
> There is one file who's license I am not sure what to name.
>
> src/libstrongswan/plugins/pkcs11.h
>
> The text of the license is:
>
> "This file is free software; as a special exception the author gives
> unlimited permission to copy and/or distribute it, with or without
> modifications, as long as this notice is preserved."
>
> Debian listed this as "MIT" but I don't believe that is correct. I
> can't find text of any "MIT" license like this, and it doesn't match the
> expat license either.
Like you wrote it’s like what short GNU helper files have, so you could
use ‘non-copyleft’ like Tobias mentions.
To me the only remaining issue is:
> --- /dev/null
> +++ b/gnu/packages/patches/strongswan-test_process-disable-all.patch
> @@ -0,0 +1,48 @@
> +
For both patches please add two or three lines explaining what the patch
does and why.
The first one can probably be called ‘strongswan-skip-tests.patch’.
> +diff -Naur strongswan-5.6.0-original/src/libstrongswan/tests/suites/test_process.c strongswan-5.6.0/src/libstrongswan/tests/suites/test_process.c
> +--- strongswan-5.6.0-original/src/libstrongswan/tests/suites/test_process.c 2016-04-22 16:01:35.000000000 -0400
> ++++ strongswan-5.6.0/src/libstrongswan/tests/suites/test_process.c 2017-10-23 15:10:12.753837342 -0400
> +@@ -201,27 +201,27 @@
> +
> + s = suite_create("process");
> +
> +- tc = tcase_create("return values");
> +- tcase_add_test(tc, test_retval_true);
> +- tcase_add_test(tc, test_retval_false);
> +- suite_add_tcase(s, tc);
> ++ /* tc = tcase_create("return values"); */
> ++ /* tcase_add_test(tc, test_retval_true); */
> ++ /* tcase_add_test(tc, test_retval_false); */
> ++ /* suite_add_tcase(s, tc); */
As a bonus, it’s better if you remove the lines instead of commenting
them out: it makes the patch shorter and easier to read.
Could you send an updated patch? We’re pretty much done. :-)
Thank you!
Ludo’.
next prev parent reply other threads:[~2018-01-30 21:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 18:58 [bug#28973] [PATCH 1/1] gnu: Add strongswan Adam Van Ymeren
2017-10-24 20:05 ` [bug#28973] [PATCH] Add the patches necessary to build strongswan Adam Van Ymeren
2017-10-24 20:11 ` [bug#28973] [PATCH 1/1] gnu: Add strongswan Tobias Geerinckx-Rice
2017-10-24 23:08 ` Adam Van Ymeren
2017-11-19 22:43 ` Ludovic Courtès
2017-11-19 23:20 ` Adam Van Ymeren
2018-01-11 21:48 ` Ludovic Courtès
2018-01-12 17:15 ` Adam Van Ymeren
2018-01-13 13:52 ` Ludovic Courtès
2018-01-13 14:00 ` Tobias Geerinckx-Rice
2018-01-15 20:36 ` Adam Van Ymeren
2018-01-15 21:50 ` Tobias Geerinckx-Rice
2018-01-15 22:32 ` Adam Van Ymeren
2018-01-30 21:22 ` Ludovic Courtès [this message]
2018-01-31 19:46 ` Adam Van Ymeren
2018-01-31 22:33 ` bug#28973: " Ludovic Courtès
2017-10-24 20:13 ` [bug#28973] " Tobias Geerinckx-Rice
2018-01-23 20:43 ` [bug#28973] Updated: " Adam Van Ymeren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871si7vy6m.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=28973@debbugs.gnu.org \
--cc=adam@vany.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).