From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49582)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eigvL-0002dL-5M
	for guix-patches@gnu.org; Mon, 05 Feb 2018 08:35:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eigvG-0005y5-LV
	for guix-patches@gnu.org; Mon, 05 Feb 2018 08:35:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:49899)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eigvG-0005xs-Hg
	for guix-patches@gnu.org; Mon, 05 Feb 2018 08:35:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eigvG-0007lV-By
	for guix-patches@gnu.org; Mon, 05 Feb 2018 08:35:02 -0500
Subject: [bug#29359] [PATCH 13/31] gnu: Add java-joda-time.
Resent-Message-ID: <handler.29359.B29359.151783769429833@debbugs.gnu.org>
References: <handler.29359.B.151111429223890.ack@debbugs.gnu.org>
	<20171119175805.902-1-julien@lepiller.eu>
	<20171119175805.902-13-julien@lepiller.eu>
	<20180204072846.68571999@alma-ubu> <87372f7ea8.fsf@elephly.net>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <87372f7ea8.fsf@elephly.net>
Date: Mon, 05 Feb 2018 14:34:44 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-ID: <871shz7e6j.fsf@elephly.net>
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= <bjoern.hoefling@bjoernhoefling.de>
Cc: 29359@debbugs.gnu.org


Ricardo Wurmus <rekado@elephly.net> writes:

> Bj=C3=B6rn H=C3=B6fling <bjoern.hoefling@bjoernhoefling.de> writes:
>
>> * Finally, remove the (zero?..), as the result ignored, the result of
>> the sourrunding lambda will be the final statement, the #t.
>
> I agree with your other comments, but not with this one :)

Never mind, I just realized that the build phase you quoted was not
quoted in full.  It continued like this:

+             (for-each (lambda (f)
+                         (copy-file f (string-append
+                                        "build/classes/org/joda/time/forma=
t/"
+                                        (basename f))))
+               (find-files "src/main/java/org/joda/time/format" ".*.proper=
ties"))
+             #t))

Since =E2=80=9Czero?=E2=80=9D is not the last statement you are in fact rig=
ht that its
return value would be ignored.

> However, we should be using =E2=80=9Cinvoke=E2=80=9D instead of =E2=80=9C=
(zero? (system* =E2=80=A6))=E2=80=9D as
> we are slowly transitioning towards throwing exceptions upon errors in
> build phases.

This is still correct, though :)

--=20
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net