From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fK8XJ-0002ap-9t for guix-patches@gnu.org; Sat, 19 May 2018 16:33:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fK8XG-0008Im-4j for guix-patches@gnu.org; Sat, 19 May 2018 16:33:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:33465) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fK8XG-0008IZ-0E for guix-patches@gnu.org; Sat, 19 May 2018 16:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fK8XF-0000fR-NO for guix-patches@gnu.org; Sat, 19 May 2018 16:33:01 -0400 Subject: [bug#31485] [PATCH] gnu: Add uncrustify. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180517203706.10244-1-ambrevar@gmail.com> Date: Sat, 19 May 2018 22:32:13 +0200 In-Reply-To: <20180517203706.10244-1-ambrevar@gmail.com> (Pierre Neidhardt's message of "Thu, 17 May 2018 22:37:06 +0200") Message-ID: <871se7pesy.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 31485@debbugs.gnu.org Hi Pierre, Pierre Neidhardt skribis: > * gnu/packages/pretty-print.scm (uncrustify): New variable. Thanks for the patch! Perhaps indent.scm or code.scm would be a better match? > + (add-after 'unpack 'unpack-etc > + (lambda* (#:key inputs outputs #:allow-other-keys) > + ;; Configuration samples are not installed by default. > + (let* ((output (assoc-ref outputs "out")) > + (etcdir (string-append output "/etc"))) > + (begin You can omit =E2=80=98begin=E2=80=99. > + (mkdir-p etcdir) > + (for-each (lambda (l) > + (copy-file > + l (string-append etcdir "/" (basename l)))) Simply: (install-file l etcdir), and you can omit =E2=80=98mkdir-p=E2=80=99= as well. > + (home-page "http://uncrustify.sourceforge.net/") > + (synopsis "Source Code Beautifier for C, C++, C#, ObjectiveC, D, Jav= a, Pawn and VALA") Maybe: =E2=80=9CIndent source code written in C or related languages=E2=80= =9D? (I wasn=E2=80=99t sure what =E2=80=9Cbeautifier=E2=80=9D meant.) > + (description > + "A highly configurable, easily modifiable source code beautifier. = Features: > +- Indent code, aligning on parens, assignments, etc. > +- Align on @code{=3D} and variable definitions. > +- Align structure initializers. > +- Align #define stuff. > +- Align backslash-newline stuff. > +- Reformat comments (a little bit). > +- Fix inter-character spacing. > +- Add or remove parens on return statements. > +- Add or remove braces on single-statement if/do/while/for statements. > +- Supports embedded SQL @code{EXEC SQL} stuff. > +- Highly configurable - More than 600 configurable options.") Please use full sentences and Texinfo markup for lists (@enumerate, etc.): https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descripti= ons.html I=E2=80=99m not sure we need to least feature with this level of detail, th= ough. Your call! > + (license gpl2))) Should be =E2=80=98gpl2+=E2=80=99 (version 2 =E2=80=9Cor any later version= =E2=80=9D). Could you send an updated patch? Thanks, Ludo=E2=80=99.