[bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.

[bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.

[Oleg Pykhalov]

* gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable.
---
 gnu/packages/lisp.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 1f8e6ab42..4c10ec39a 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -987,6 +987,25 @@ productive, customizable lisp based systems.")
     (license license:gpl2+)
     (properties `((ecl-variant . ,(delay ecl-stumpwm))))))
 
+(define-public sbcl-stumpwm-checkout
+  (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947"))
+    (package
+      (inherit sbcl-stumpwm)
+      (version (git-version (package-version sbcl-stumpwm) "1" commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/stumpwm/stumpwm.git")
+               (commit commit)))
+         (file-name (git-file-name (package-name sbcl-stumpwm) version))
+         (sha256
+          (base32
+           "1qyvhw73dghs167hcds1k2021w2hakh99zfv0039w7lx259gazl9"))))
+      (inputs
+       `(("sbcl-alexandria" ,sbcl-alexandria)
+         ,@(package-inputs sbcl-stumpwm))))))
+
 (define-public cl-stumpwm
   (sbcl-package->cl-source-package sbcl-stumpwm))
 
-- 
2.17.0

[bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.

[Ludovic Courtès]

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> * gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable.

[...]

> +(define-public sbcl-stumpwm-checkout
> +  (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947"))
> +    (package
> +      (inherit sbcl-stumpwm)
> +      (version (git-version (package-version sbcl-stumpwm) "1" commit))

Could you explain the rationale and write that as a comment?  :-)

As you know we currently avoid packaging unreleased versions unless we
have a good reason to do so (info "(guix) Version Numbers").

TIA!

Ludo’.

[bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.

[Oleg Pykhalov]

[-- Attachment #1.1: Type: text/plain, Size: 1958 bytes --]

Hello Ludovic,

ludo@gnu.org (Ludovic Courtès) writes:

> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
>> * gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable.
>
> [...]
>
>> +(define-public sbcl-stumpwm-checkout
>> +  (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947"))
>> +    (package
>> +      (inherit sbcl-stumpwm)
>> +      (version (git-version (package-version sbcl-stumpwm) "1" commit))
>
> Could you explain the rationale and write that as a comment?  :-)
>
> As you know we currently avoid packaging unreleased versions unless we
> have a good reason to do so (info "(guix) Version Numbers").

The reason I want to be it in a Guix package collection is StumpWM
release version (not a release candidate) was published 1 year ago and
since this date there are 250 commits in master branch.

I was using StumpWM builded manually with Quicklisp, but then I switched
to Guix package, because I don't want to build StumpWM manually, but I
found that StumpWM command ‘toggle-always-on-top’ is missing and StumpWM
contrib modules failed to build.

It's a fast dirty solution to have StumpWM from Guix and StumpWM contrib
modules with some dependencies builded with Quicklisp.  :-)  E.g.:

~/.stumpwm.d/init.lisp
--8<---------------cut here---------------start------------->8---
(load "~/quicklisp/setup.lisp")

(set-module-dir "~/.stumpwm.d/modules/")

(ql:quickload "clx-truetype")
(load-module "ttf-fonts")
(xft:cache-fonts)
(set-font (make-instance 'xft:font
                         :family "DejaVu Sans Mono"
                         :subfamily "Book"
                         :size 14))
--8<---------------cut here---------------end--------------->8---

The best solution is to package all StumpWM contrib modules as separate
recipes, but I'm not sure how do it right now because for example
‘sbcl-winner-mode’ package recipe complains about STUMPWM not found.


[-- Attachment #1.2: sbcl-winner-mode package recipe --]
[-- Type: text/x-scheme, Size: 1180 bytes --]

(define-public sbcl-winner-mode
  (let ((commit "8fbed038e2e51d9034a9bb0273c10ae3e9221026"))
    (package
      (name "sbcl-winner-mode")
      (version (git-version "0.1" "1" commit))
      (source
       (origin
         (method git-fetch)
         (uri (git-reference
               (url "https://github.com/stumpwm/stumpwm-contrib.git")
               (commit commit)))
         (file-name (string-append name "-" version "-checkout"))
         (sha256
          (base32
           "1918axy82v7yj5j2igvp6220aibzk0yay6wdgqwgxf2b8mi13jmw"))))
      (inputs
       `(("sbcl-stumpwm" ,sbcl-stumpwm)))
      (arguments
       `(#:phases
         (modify-phases %standard-phases
           (add-after 'unpack 'chdir-elisp
             ;; ‘winner-mode’ directory is not in root of the source.
             (lambda _
               (chdir "util/winner-mode"))))))
      (build-system asdf-build-system/sbcl)
      (home-page "https://github.com/stumpwm/stumpwm-contrib")
      (synopsis "External modules for StumpWM window manager")
      (description
       "This package provides external modules for StumpWM window manager.")
      (license #f))))

[-- Attachment #1.3: Type: text/plain, Size: 200 bytes --]


--8<---------------cut here---------------start------------->8---
Component :STUMPWM not found, required by #<SYSTEM "winner-mode">
--8<---------------cut here---------------end--------------->8---


[-- Attachment #1.4: List of StumpWM contrib modules --]
[-- Type: text/plain, Size: 580 bytes --]

modules/media:

- amixer
- aumix

modules/minor-mode:

- mpd
- notifications

modules/modeline:

- battery-portable
- cpu
- disk
- hostname
- maildir
- mem
- net
- wifi

modules/util:

- alert-me
- app-menu
- clipboard-history
- command-history
- debian
- end-session
- globalwindows
- kbd-layouts
- logitech-g15-keysyms
- notify
- numpad-layouts
- pass
- passwd
- perwindowlayout
- pinentry
- productivity
- qubes
- sbclfix
- screenshot
- searchengines
- stumpish
- stumptray
- surfraw
- swm-emacs
- swm-gaps
- ttf-fonts
- undocumented
- urgentwindows
- windowtags
- winner-mode

[-- Attachment #1.5: Type: text/plain, Size: 16 bytes --]


Regards,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.

[Ludovic Courtès]

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> Hello Ludovic,
>
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>>
>>> * gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable.
>>
>> [...]
>>
>>> +(define-public sbcl-stumpwm-checkout
>>> +  (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947"))
>>> +    (package
>>> +      (inherit sbcl-stumpwm)
>>> +      (version (git-version (package-version sbcl-stumpwm) "1" commit))
>>
>> Could you explain the rationale and write that as a comment?  :-)
>>
>> As you know we currently avoid packaging unreleased versions unless we
>> have a good reason to do so (info "(guix) Version Numbers").
>
> The reason I want to be it in a Guix package collection is StumpWM
> release version (not a release candidate) was published 1 year ago and
> since this date there are 250 commits in master branch.
>
> I was using StumpWM builded manually with Quicklisp, but then I switched
> to Guix package, because I don't want to build StumpWM manually, but I
> found that StumpWM command ‘toggle-always-on-top’ is missing and StumpWM
> contrib modules failed to build.
>
> It's a fast dirty solution to have StumpWM from Guix and StumpWM contrib
> modules with some dependencies builded with Quicklisp.  :-)  E.g.:

OK, that sounds reasonable.

In that case, I’d suggest changing the “name” field to “stumpwm-next” as
we did a few times in the past, so that by default, people still get the
official release.  That and a comment summarizing what you wrote above
and you can go ahead!

Thanks,
Ludo’.

[bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.

[Ludovic Courtès]

Ping!  :-)

ludo@gnu.org (Ludovic Courtès) skribis:

> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
>> Hello Ludovic,
>>
>> ludo@gnu.org (Ludovic Courtès) writes:
>>
>>> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>>>
>>>> * gnu/packages/lisp.scm (sbcl-stumpwm-checkout): New public variable.
>>>
>>> [...]
>>>
>>>> +(define-public sbcl-stumpwm-checkout
>>>> +  (let ((commit "cec7fd9e963e5da59b05ba0ffbe292dc94fd2947"))
>>>> +    (package
>>>> +      (inherit sbcl-stumpwm)
>>>> +      (version (git-version (package-version sbcl-stumpwm) "1" commit))
>>>
>>> Could you explain the rationale and write that as a comment?  :-)
>>>
>>> As you know we currently avoid packaging unreleased versions unless we
>>> have a good reason to do so (info "(guix) Version Numbers").
>>
>> The reason I want to be it in a Guix package collection is StumpWM
>> release version (not a release candidate) was published 1 year ago and
>> since this date there are 250 commits in master branch.
>>
>> I was using StumpWM builded manually with Quicklisp, but then I switched
>> to Guix package, because I don't want to build StumpWM manually, but I
>> found that StumpWM command ‘toggle-always-on-top’ is missing and StumpWM
>> contrib modules failed to build.
>>
>> It's a fast dirty solution to have StumpWM from Guix and StumpWM contrib
>> modules with some dependencies builded with Quicklisp.  :-)  E.g.:
>
> OK, that sounds reasonable.
>
> In that case, I’d suggest changing the “name” field to “stumpwm-next” as
> we did a few times in the past, so that by default, people still get the
> official release.  That and a comment summarizing what you wrote above
> and you can go ahead!
>
> Thanks,
> Ludo’.

[bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hello Ludovic,

Apologies for a long reply.

ludo@gnu.org (Ludovic Courtès) writes:

[…]

>> In that case, I’d suggest changing the “name” field to “stumpwm-next” as
>> we did a few times in the past, so that by default, people still get the
>> official release.

Changing “name” field unfortunatelly breaks the build.  I didn't
investigate a reason yet and I don't want to push without changing
“name” field because users will install the “stumpwm-next” by default.

> That and a comment summarizing what you wrote above and you can go ahead!

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#31548] [PATCH] gnu: Add sbcl-stumpwm-checkout.

[Andy Patterson]

Hi Oleg,

On Sun, 17 Jun 2018 18:55:41 +0300
Oleg Pykhalov <go.wigust@gmail.com> wrote:

> Hello Ludovic,
> 
> Apologies for a long reply.
> 
> ludo@gnu.org (Ludovic Courtès) writes:
> 
> […]
> 
> >> In that case, I’d suggest changing the “name” field to
> >> “stumpwm-next” as we did a few times in the past, so that by
> >> default, people still get the official release.  
> 
> Changing “name” field unfortunatelly breaks the build.  I didn't
> investigate a reason yet and I don't want to push without changing
> “name” field because users will install the “stumpwm-next” by default.

I haven't looked much into your patch, but this might be because the
asdf build system uses the package name to guess where the system will
be defined. If the package name differs from the system name, this
behaviour can be overridden using the #:asd-system-name argument.

Hope that helps,

--
Andy

[bug#31548] [PATCH] gnu: sbcl-stumpwm: Update to 18.05.

[Oleg Pykhalov]

[-- Attachment #1.1: Type: text/plain, Size: 795 bytes --]

Hello Andy,

Andy Patterson <ajpatter@uwaterloo.ca> writes:

[…]

>> Changing “name” field unfortunatelly breaks the build.  I didn't
>> investigate a reason yet and I don't want to push without changing
>> “name” field because users will install the “stumpwm-next” by default.
>
> I haven't looked much into your patch, but this might be because the
> asdf build system uses the package name to guess where the system will
> be defined. If the package name differs from the system name, this
> behaviour can be overridden using the #:asd-system-name argument.
>
> Hope that helps

It does, thank you.  For the record ‘#:asd-system-name "stumpwm"’.

Upstream pushed a new release.  I'll test it during current week and
push the following patch probably.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: gnu: sbcl-stumpwm: Update to 18.05. --]
[-- Type: text/x-patch, Size: 1446 bytes --]

From 1e7ee0f57d46161cb655c3adcaf0f20ef12f9bdb Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Tue, 19 Jun 2018 00:27:30 +0300
Subject: [PATCH] gnu: sbcl-stumpwm: Update to 18.05.

* gnu/packages/lisp.scm (sbcl-stumpwm): Update to 18.05.
---
 gnu/packages/lisp.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 258e9827a..720ac070c 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -944,18 +944,19 @@ from other CLXes around the net.")
 (define-public sbcl-stumpwm
   (package
     (name "sbcl-stumpwm")
-    (version "1.0.0")
+    (version "18.05")
     (source (origin
               (method url-fetch)
               (uri (string-append
                     "https://github.com/stumpwm/stumpwm/archive/"
                     version ".tar.gz"))
               (sha256
-               (base32 "1maxp98gh64az3d9vz9br6zdd6rc9fmj2imvax4by85g6kxvdz1i"))
+               (base32 "1n2gaab3lwgf5r1hmwdcw13dkv9xdd7drn2shx28kfxvhdc9kbb9"))
               (file-name (string-append "stumpwm-" version ".tar.gz"))))
     (build-system asdf-build-system/sbcl)
     (inputs `(("cl-ppcre" ,sbcl-cl-ppcre)
-              ("clx" ,sbcl-clx)))
+              ("clx" ,sbcl-clx)
+              ("alexandria" ,sbcl-alexandria)))
     (outputs '("out" "lib"))
     (arguments
      '(#:phases
-- 
2.17.1


[-- Attachment #1.3: Type: text/plain, Size: 241 bytes --]


I don't know what to do with ‘sbcl-stumpwm-next’ package.  I think we
shouldn't push it because of our policy to stick with stable versions
for recipes.  But anybody fill free to ping me if you need next version.

Regards,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#31548] [PATCH] gnu: sbcl-stumpwm: Update to 18.05.

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

Oleg Pykhalov <go.wigust@gmail.com> writes:

[…]

> Upstream pushed a new release.  I'll test it during current week and
> push the following patch probably.

Pushed as abf818bcf59998ba62ae7bfb2d03c28d7cffaa42

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]