unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 31949@debbugs.gnu.org
Subject: [bug#31949] [PATCH] gnu: Add docx2txt.
Date: Mon, 25 Jun 2018 22:58:29 +0200	[thread overview]
Message-ID: <871scur3be.fsf@gnu.org> (raw)
In-Reply-To: <20180623133237.25427-1-ambrevar@gmail.com> (Pierre Neidhardt's message of "Sat, 23 Jun 2018 15:32:37 +0200")

Hi,

Pierre Neidhardt <ambrevar@gmail.com> skribis:

> * gnu/packages/textutils.scm (docx2txt): New variable.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://downloads.sourceforge.net/docx2txt/docx2txt-"
> +                    version ".tgz"))

Could you use mirror://sourceforge?

> +       #:make-flags (list (string-append "BINDIR=" (assoc-ref %outputs "out") "/bin")
> +                          (string-append "CONFIGDIR=" (assoc-ref %outputs "out") "/etc")

Lines are a bit long.  :-)

> +    (synopsis "Recover text from .docx files, with good formatting")

@file{.docx} please.

> +    (description
> +     "@command{docx2txt} is a perl based command line utility to convert

s/perl/Perl/

> +Microsoft Office™ .docx documents to equivalent text documents. Latest version

No need for the trademark sign; two spaces after period.

> +@itemize
> +@item Character conversions (\" ' < & > -, fractions and some mathematical
> +symbols, etc.); currency characters are converted to respective names like
> +Euro.

Maybe you remove what’s in parentheses?  Or use @code.

Could you send an updated patch?  Make sure ‘guix lint’ is happy.  :-)

Thanks,
Ludo’.

  reply	other threads:[~2018-06-25 20:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-23 13:32 [bug#31949] [PATCH] gnu: Add docx2txt Pierre Neidhardt
2018-06-25 20:58 ` Ludovic Courtès [this message]
2018-06-25 21:22   ` Pierre Neidhardt
2018-07-07 15:53     ` bug#31949: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871scur3be.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=31949@debbugs.gnu.org \
    --cc=ambrevar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).