unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 35935@debbugs.gnu.org
Subject: [bug#35935] [PATCH] guix: import: simplify recursive import
Date: Mon, 03 Jun 2019 22:56:21 +0300	[thread overview]
Message-ID: <871s0asasa.fsf@gmail.com> (raw)
In-Reply-To: <CBFF786D-3925-46D1-95AF-D676A7F0D8F2@vllmrt.net> (Robert Vollmert's message of "Sun, 2 Jun 2019 22:23:56 +0200")

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

Hello Robert,

Robert Vollmert <rob@vllmrt.net> writes:

[…]

>> I think Oleg worked on this part before; Oleg, could you comment
>> and/or apply?
>> 
>> ‘tests/import-utils.scm’ doesn’t seem to be testing this procedure,
>> perhaps that’s something we should fix eventually.
>
> Agreed. It does seem to be covered somewhat by tests/gem.scm.
> I also tested it a bit by hand, with some haskell packages.

True, ‘tests/gem.scm’ file tests ‘recursive-import’ procedure by
invoking ‘gem-recursive-import’.  I think this test is good enough for
our purpose - use ‘recursive-import’ in other package importers and make
sure it works. Thoughts?

I also added a copyright line if you don't mind:

    ;;; Copyright © 2019 Robert Vollmert <rob@vllmrt.net>

Is it OK, Robert?  I tested manually with ‘gem’ and ‘elpa’ recursive
importers and ready to push :-)

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-06-03 19:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 20:07 [bug#35935] [PATCH] guix: import: simplify recursive import Robert Vollmert
2019-06-02 19:52 ` Ludovic Courtès
2019-06-02 20:23   ` Robert Vollmert
2019-06-03 19:56     ` Oleg Pykhalov [this message]
2019-06-03 19:59       ` Robert Vollmert
2019-06-03 20:31         ` bug#35935: " Oleg Pykhalov
2019-06-02 20:19 ` [bug#35935] [PATCH] guix: import: Simplify " Robert Vollmert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s0asasa.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=35935@debbugs.gnu.org \
    --cc=rob@vllmrt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).