From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:50888)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiRCE-00037S-4w
 for guix-patches@gnu.org; Tue, 02 Jul 2019 18:24:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiRC5-0001WK-Uu
 for guix-patches@gnu.org; Tue, 02 Jul 2019 18:24:11 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39280)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hiRBz-0001S5-B7
 for guix-patches@gnu.org; Tue, 02 Jul 2019 18:24:05 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hiRBz-0004VK-4t
 for guix-patches@gnu.org; Tue, 02 Jul 2019 18:24:03 -0400
Subject: [bug#36303] [PATCH] gnu: Add qtpass.
Resent-Message-ID: <handler.36303.B36303.156210620017262@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87d0j81yls.fsf@zete.tk>
Date: Wed, 03 Jul 2019 00:23:06 +0200
In-Reply-To: <87d0j81yls.fsf@zete.tk> ("Jens
 \=\?utf-8\?Q\?M\=C3\=B8lgaard\=22's\?\= message of "Thu, 20
 Jun 2019 19:53:51 +1200")
Message-ID: <871rz85b5h.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jens =?UTF-8?Q?M=C3=B8lgaard?= <jens@zete.tk>
Cc: 36303@debbugs.gnu.org

Hi Jens,

Jens M=C3=B8lgaard <jens@zete.tk> skribis:

> Some notes:
>
> - Tests are currently disabled as they seem to need display set. Appears
> to be the case for a few qt packages.

Some packages have a pre-check phase that spawns Xvfb; others do:

  (setenv "QT_QPA_PLATFORM" "offscreen")

Would one of these method allow us to run the tests?

> - qmake looks for lrelease-qt5/lupdate-qt5 instead of lrelease/lupdate,
> and only seems to like the env vars given directly when invoked.
> lrelease/lupdate in turn need a variable to find qmake. There's possibly
> a more elegant way of doing this.

Sounds good.

> - Desktop file isn't currently set up; I'll need to look into that.

OK.

> From cf95cf3b851c09afe7904e512c4a2e6b373db4de Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Jens=3D20M=3DC3=3DB8lgaard?=3D <jens@zete.tk>
> Date: Thu, 20 Jun 2019 19:24:47 +1200
> Subject: [PATCH] gnu: Add qtpass.
>
> * gnu/packages/password-utils.scm (qtpass): New variable.

[...]

> +    (license license:gpl3)))

Source file headers don=E2=80=99t specify any version of the GPL, so it sho=
uld
be =E2=80=98gpl3+=E2=80=99 (meaning =E2=80=9Cor any later version=E2=80=9D).

Apart from these minor issues, it LGTM!

Could you send an updated patch that runs tests, if that works?
Otherwise we=E2=80=99re ready to go.

Thank you, and apologies for the delay!

Ludo=E2=80=99.