From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:48530)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iiQKX-0002o4-2o
 for guix-patches@gnu.org; Fri, 20 Dec 2019 17:01:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iiQKU-0000Rv-L7
 for guix-patches@gnu.org; Fri, 20 Dec 2019 17:01:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:41376)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iiQKU-0000Qz-Gh
 for guix-patches@gnu.org; Fri, 20 Dec 2019 17:01:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iiQKU-0001Me-ED
 for guix-patches@gnu.org; Fri, 20 Dec 2019 17:01:02 -0500
Subject: [bug#38662] [PATCH] gnu: Add emacs-next.
Resent-Message-ID: <handler.38662.B38662.15768792205189@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20191218200419.28836-1-bandali@gnu.org>
Date: Fri, 20 Dec 2019 22:59:56 +0100
In-Reply-To: <20191218200419.28836-1-bandali@gnu.org> (Amin Bandali's message
 of "Wed, 18 Dec 2019 15:04:19 -0500")
Message-ID: <871rsypsir.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Amin Bandali <bandali@gnu.org>
Cc: 38662@debbugs.gnu.org

Hi Amin,

Amin Bandali <bandali@gnu.org> skribis:

> Add `emacs-next' for building latest Emacs from git.
>
> * gnu/packages/emacs.scm (emacs-next): New variable.
> (emacs): make the autoload deletion snippet not fail when eshell/esh-grou=
ps.el
> does not exist.  This enables reuse of the entire snippet field of `emacs=
' for
> `emacs-next'.

Nice!  Please also mention the new patch file and add it to
gnu/local.mk.

It LGTM, but=E2=80=A6

>               (snippet
> -              ;; Delete the bundled byte-compiled elisp files and
> -              ;; generated autoloads.
>                '(with-directory-excursion "lisp"
> +                 ;; Delete the bundled byte-compiled elisp files and gen=
erated
> +                 ;; autoloads.
>                   (for-each delete-file
>                             (append (find-files "." "\\.elc$")
>                                     (find-files "." "loaddefs\\.el$")
>                                     ;; This is the only "autoloads" file =
that
>                                     ;; does not have "*loaddefs.el" name.
> -                                   '("eshell/esh-groups.el")))
> +                                   (find-files "." "eshell/esh-groups\\.=
el$")))

This change causes a rebuild of =E2=80=98emacs=E2=80=99, =E2=80=98emacs-min=
imal=E2=80=99, and everything
that depends on them (1K+ packages.)  Can it be avoided somehow?

One solution would be to duplicate the snippet for now in =E2=80=98emacs-ne=
xt=E2=80=99.

> --- /dev/null
> +++ b/gnu/packages/patches/emacs27-exec-path.patch

Please add a line or two at the top explaining what this patch does.

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.