From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:34536)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKMWK-0005YS-Ht
 for guix-patches@gnu.org; Fri, 03 Apr 2020 09:38:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKMWI-0002V9-Hh
 for guix-patches@gnu.org; Fri, 03 Apr 2020 09:38:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:58115)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jKMWI-0002V5-EM
 for guix-patches@gnu.org; Fri, 03 Apr 2020 09:38:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKMWI-0000fa-Bq
 for guix-patches@gnu.org; Fri, 03 Apr 2020 09:38:02 -0400
Subject: [bug#40320] [PATCH v2 1/2] gnu: Add libqalculate.
Resent-Message-ID: <handler.40320.B40320.15859210602503@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <c7ae76e80872ed303cbc0c8e8216f56ea7061d8e.1585545646.git.vkor@vkten.in>
 <20200401052320.21576-1-vkor@vkten.in>
Date: Fri, 03 Apr 2020 15:37:27 +0200
In-Reply-To: <20200401052320.21576-1-vkor@vkten.in> (R. Veera Kumar's message
 of "Wed, 1 Apr 2020 10:53:19 +0530")
Message-ID: <871rp4lmg8.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: R Veera Kumar <vkor@vkten.in>
Cc: Danny Milosavljevic <dannym@scratchpost.org>, 40320@debbugs.gnu.org

Hi Veera,

R Veera Kumar <vkor@vkten.in> skribis:

> * gnu/packages/maths.scm (libqalculate): New variable.
> * gnu/packages/maths.scm: Add missing modules.
> * gnu: maths: Add copyright line.
>
> Signed-off-by: R Veera Kumar <vkor@vkten.in>
> ---
> Changes in v2:
>  - Change commit msg as per changelog format
>  - Use git release tag instead of commit id
>  - Use 'bootstrap with setenv appropriately
>  - Correct inputs and native-inputs

Perfect, I=E2=80=99ve applied it and will push shortly, thank you!

I=E2=80=99ve kept only the first line of the commit message above, because =
we
don=E2=80=99t usually mention changes in the list of modules used and copyr=
ight
lines, and =E2=80=98Signed-off-by=E2=80=99 is for the person who applies th=
e patch on
your behalf.

Apart from this tiny issue it=E2=80=99s all good!

Ludo=E2=80=99.