From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CGV8ERFFzF5hbwAA0tVLHw (envelope-from ) for ; Mon, 25 May 2020 22:22:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uPkxDRFFzF5tIgAAbx9fmQ (envelope-from ) for ; Mon, 25 May 2020 22:22:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7950394042C for ; Mon, 25 May 2020 22:22:08 +0000 (UTC) Received: from localhost ([::1]:55012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdLTy-00053f-19 for larch@yhetil.org; Mon, 25 May 2020 18:22:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdLTu-00053L-Og for guix-patches@gnu.org; Mon, 25 May 2020 18:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdLTu-0000yi-F1 for guix-patches@gnu.org; Mon, 25 May 2020 18:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdLTu-0000ma-AJ for guix-patches@gnu.org; Mon, 25 May 2020 18:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41395] [PATCH 1/2] gnu: python-prompt-toolkit: Update to 3.0.5 Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 May 2020 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41395 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Edouard Klein , 41395@debbugs.gnu.org Received: via spool by 41395-submit@debbugs.gnu.org id=B41395.15904453062985 (code B ref 41395); Mon, 25 May 2020 22:22:02 +0000 Received: (at 41395) by debbugs.gnu.org; 25 May 2020 22:21:46 +0000 Received: from localhost ([127.0.0.1]:42727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdLTe-0000m5-Bq for submit@debbugs.gnu.org; Mon, 25 May 2020 18:21:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdLTc-0000lm-Ng for 41395@debbugs.gnu.org; Mon, 25 May 2020 18:21:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58789) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdLTX-0000xC-7C; Mon, 25 May 2020 18:21:39 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:39504 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jdLTT-0001k4-3z; Mon, 25 May 2020 18:21:39 -0400 From: Marius Bakke In-Reply-To: <87pnasi8w7.fsf@alice.lan> References: <87v9ksckt3.fsf@alice.lan> <87sgfwcklx.fsf@alice.lan> <87wo527b41.fsf@devup.no> <87pnasi8w7.fsf@alice.lan> Date: Tue, 26 May 2020 00:21:32 +0200 Message-ID: <871rn77j0z.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: 86lZNK/wvx3p --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Edouard Klein writes: >>> (synopsis "Interpretable Machine Learning (iML) package") >>> (description "Interpretable ML (iML) is a set of data type objects, >>> visualizations, and interfaces that can be used by any method designed= to >>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm >>> index b8a51570c3..5fd7e274e9 100644 >>> --- a/gnu/packages/python-xyz.scm >>> +++ b/gnu/packages/python-xyz.scm >>> @@ -8922,6 +8922,7 @@ interactive computing.") >>> (build-system python-build-system) >>> (propagated-inputs >>> `(("python-ipykernel" ,python-ipykernel) >>> + ("python-prompt-toolkit" ,python-prompt-toolkit-2) >>> ("python-notebook" ,python-notebook))) >>> (native-inputs >>> `(("python-certifi" ,python-certifi) >>> @@ -8950,6 +8951,7 @@ notebooks.") >>> (propagated-inputs >>> `(("python-ipython" ,python-ipython) >>> ("python-traitlets" ,python-traitlets) >>> + ("python-prompt-toolkit" ,python-prompt-toolkit-2) >>> ("python-widgetsnbextension" ,python-widgetsnbextension))) >>> (native-inputs >>> `(("python-nose" ,python-nose) >>> @@ -8980,7 +8982,7 @@ in the data.") >>> (propagated-inputs >>> `(("python-ipykernel" ,python-ipykernel) >>> ("python-jupyter-client" ,python-jupyter-client) >>> - ("python-prompt-toolkit" ,python-prompt-toolkit) >>> + ("python-prompt-toolkit" ,python-prompt-toolkit-2) >>> ("python-pygments" ,python-pygments))) >>> (native-inputs >>> `(("python-nose" ,python-nose))) >>> @@ -12049,6 +12051,44 @@ collections of data.") >>> (package-with-python2 python-backpack)) >> >> It would be great to update these packages instead of pinning to the old >> version. I won't blame you if you don't feel like embarking on that >> journey though. >> > > In the new patches I'm about to send, I updated them. Alas even their > latest versions still require python-prompt-toolkit <=3D2.1, so I had to > pin the dependencies. I did it in a cleaner way, though. Oh too bad that updating did not work. Terrible that these are so tied to the version of python-prompt-toolkit. Can you split those updates out to separate patches, preceding the prompt-toolkit patch? Then they can be reverted and tested individually without having to revert the whole thing in case there are problems. >>> +(define-public python-prompt-toolkit-2 >>> (package >>> (name "python-prompt-toolkit") >>> (version "2.0.7") >>> @@ -12077,7 +12117,7 @@ collections of data.") >>> ("python-pygments" ,python-pygments))) >>> (native-inputs >>> `(("python-pytest" ,python-pytest))) >>> - (home-page "https://github.com/jonathanslenders/python-prompt-tool= kit") >>> + (home-page "https://github.com/prompt-toolkit/python-prompt-toolki= t") >>> (synopsis "Library for building command line interfaces in Python") >>> (description >>> "Prompt-Toolkit is a library for building interactive command line >>> @@ -12104,6 +12144,10 @@ characters, mouse support, and auto suggestion= s.") >>> (define-public python2-prompt-toolkit-1 >>> (package-with-python2 python-prompt-toolkit-1)) >>>=20=20 >>> +(define-public prompt-toolkit-2-instead-of-prompt-toolkit >>> + (package-input-rewriting/spec >>> + `(("python-prompt-toolkit" . ,(const python-prompt-toolkit-2))))) >> >> Is this actually necessary? Just changing the inputs as you did above >> should be sufficient I think. > > If one dependency is OK with python-prompt-toolkit in version 3, but a > package has an implicit dependency on python-prompt-toolkit in version > 2, then we either have to pin them all to version 2, and the OK > dependency does not get to envoy the update, or we have to resort to this. > > I did it because python-ipython (19 dependents) is OK with > the update, and I did not want to pin it (and all its dependents) to pyth= on-prompt-toolkit-2. > > This is my first time making such an involved update, so I'm open to > suggestions as to alternative ways of doing this. Oh I see, makes sense. The new patch is much clearer. I will send a separate reply with further comments. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7MROwACgkQoqBt8qM6 VPprnQf7B8qd3Ggk+ne/nQc1i9W2SvmLEWF4FciDxFHv58BsOiMsp9Da0L5YVffj ZlvGm383qBAruxM3z/7nhZR8VB03PZ/VNLUfbCMdHNBBQ5cwAUw2b+/Ojo4pYZD6 PzGTZWDwR/s3eJ9oJ7Udl3c+HboPGmBY3y7y6ZlQKUQSFckzdAFH3I8S6/X1OaHP cWYYVJjEYVWqPlN6OHNOOgGBhhgTkmWNrGrIYj3/SEZqxdcuvmAGVIefSGoEaSQM teTWX1BJ+uw7eijhZB+pLqlmJcADs0EI7frQZb5g35VwZsgwYsyzgC5erSu6zGmQ jQCzu322z2F25vLzntuMTJ0TcKIR0w== =3MgV -----END PGP SIGNATURE----- --=-=-=--