From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kpm+I8nQ0F5fJwAA0tVLHw (envelope-from ) for ; Fri, 29 May 2020 09:07:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iJRpH8nQ0F7XZwAAB5/wlQ (envelope-from ) for ; Fri, 29 May 2020 09:07:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7E6B940538 for ; Fri, 29 May 2020 09:07:20 +0000 (UTC) Received: from localhost ([::1]:50048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeaz0-0006hU-8f for larch@yhetil.org; Fri, 29 May 2020 05:07:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeayk-0006hK-Mx for guix-patches@gnu.org; Fri, 29 May 2020 05:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jeayk-00075h-Cq for guix-patches@gnu.org; Fri, 29 May 2020 05:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jeayk-0002jk-3l for guix-patches@gnu.org; Fri, 29 May 2020 05:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41350] [PATCH v2 3/3] system: vm: Build vm-image using native qemu, for the Hurd. Resent-From: Jan Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 May 2020 09:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41350 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Mathieu Othacehe , 41350@debbugs.gnu.org Received: via spool by 41350-submit@debbugs.gnu.org id=B41350.159074317310462 (code B ref 41350); Fri, 29 May 2020 09:07:02 +0000 Received: (at 41350) by debbugs.gnu.org; 29 May 2020 09:06:13 +0000 Received: from localhost ([127.0.0.1]:53788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeaxx-0002if-9O for submit@debbugs.gnu.org; Fri, 29 May 2020 05:06:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeaxv-0002iP-30 for 41350@debbugs.gnu.org; Fri, 29 May 2020 05:06:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52195) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeaxo-00060P-ON; Fri, 29 May 2020 05:06:04 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=36398 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jeaxn-0005H7-7o; Fri, 29 May 2020 05:06:03 -0400 From: Jan Nieuwenhuizen Organization: AvatarAcademy.nl References: <20200519072302.9202-1-janneke@gnu.org> <20200519072302.9202-3-janneke@gnu.org> <87367ue09v.fsf@gnu.org> <87pnavu611.fsf@gnu.org> <87zh9tf0qa.fsf@gnu.org> <87d06o36sc.fsf@gnu.org> <87o8q8gs3w.fsf@gnu.org> <878shccblp.fsf@gnu.org> <87o8q8yohx.fsf@gnu.org> <87o8q75f2r.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Fri, 29 May 2020 11:06:01 +0200 In-Reply-To: <87o8q75f2r.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 29 May 2020 10:18:52 +0200") Message-ID: <871rn3rtza.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.49 X-TUID: QPBMvUATIdVb Ludovic Court=C3=A8s writes: > Hi, > > Mathieu Othacehe skribis: > >>> But maybe we can just rebase =E2=80=98system-qemu-image=E2=80=99 & co. = on top of (gnu >>> image)? What prevents us from doing that, Mathieu? >>> >>> If we can do that, then indeed, there=E2=80=99s no point in insisting o= n fixing >>> cross-compilation support in (gnu system vm). >> >> I think we could proceed that way: >> >> * Merge Ludo's serie on master. > > I think that can wait because on IRC Janneke explained that it doesn=E2= =80=99t > fix anything for GNU/Hurd (to my surprise). Well, that's too black/white. Of course this: - (linux (string-append #$linux "/" - #$(system-linux-image-file-na= me))) - (initrd #$initrd) - (loader #$loader) + (linux (string-append + #+linux "/" + #+(system-linux-image-file-name system))) + (initrd #+initrd) + (loader #+loader) is an essential fix. Only, that used to be on wip-hurd-vm -- so from that perspective this fix only got reviewed and moved. Pretty similarly for this + (define preserve-target + (if target + (lambda (obj) + (with-parameters ((%current-target-system target)) + obj)) + identity)) also an essential bit. So, seen from master it fixes quite some bits! What I meant to say is that I haven't seen /additional/ fixes to what we had on wip-hurd-vm... Because your fixes look clean and don't break anything, I think we should maybe apply them to master -- and that's why I kept them at the bottom of "wip-hurd-vm" for now. > So I=E2=80=99ll maybe check again once the relevant Hurd bits are on mast= er, > instead of checking ARM cross-compilation. > > Anyway it=E2=80=99s much less important now that (gnu image) can be used = for the > task! Yes, so from the Hurd perspective this patch set has shifted from top-priority to probably not going to be used for the Hurd ;) >> * Then we could review & merge Jan's wip-hurd-disk. > > Do I get it right that we first need > ? > > The =E2=80=98wip-hurd-vm=E2=80=99 branch contains many things: > > 1. (gnu system hurd) with the Hurd services etc. > > 2. The =E2=80=98hurd=E2=80=99 field of . > > 3. with multiboot support. Yes. > 4. Hacks to work around vm.scm defects: uses of =E2=80=98with-parameter= s=E2=80=99, Together with dropping qemu-image support for the Hurd, I have removed most of this; what remains is in --8<---------------cut here---------------start------------->8--- system: Add 'multiboot-modules' field to . + (mach (if (%current-target-system) + ;; A cross-built GNUmach does not work + (with-parameters ((%current-system "i686-linux") + (%current-target-system #f)) + mach) + mach))) [..] + (libc (if target + (with-parameters ((%current-target-system #f)) + (cross-libc target)) + glibc)) --8<---------------cut here---------------end--------------->8--- > =E2=80=98hurd-target?=E2=80=99, disabling sqlite3, and #~#$ tricks. I think this is mostly gone, two instances of hurd-target? remain. I'll look more sharply at that too! > I think part of the reason this cycle has been so long is that it=E2=80= =99s been > kind of a big bang; big bangs are great because they lead to something > new and exciting, but they=E2=80=99re also intimidating. :-) For me pers= onally, > looking at all these aspects at once was just too much. Yes... > For merging, I think it=E2=80=99d be great to see #1 and #2 as a first st= ep, and > then #3. Yes, that would be an amazing feat. > I do not want any of #4 :-), because I really think it could lead to > maintenance headaches down the road, which would make the kind of > changes we=E2=80=99re making today practically impossible in the future. > Thoughts? I fully agree, thanks! Greetings, Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com