From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QM4IIC2r7F4EOQAA0tVLHw (envelope-from ) for ; Fri, 19 Jun 2020 12:10:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SLAJHC2r7F51TgAA1q6Kng (envelope-from ) for ; Fri, 19 Jun 2020 12:10:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91758940AF6 for ; Fri, 19 Jun 2020 12:10:20 +0000 (UTC) Received: from localhost ([::1]:42572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmFqd-0001bu-Fm for larch@yhetil.org; Fri, 19 Jun 2020 08:10:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmFqM-0001TU-Tb for guix-patches@gnu.org; Fri, 19 Jun 2020 08:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jmFqM-0008DK-Ku for guix-patches@gnu.org; Fri, 19 Jun 2020 08:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jmFqM-0004RD-G8 for guix-patches@gnu.org; Fri, 19 Jun 2020 08:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40035] Add widelands game Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Jun 2020 12:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40035 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Goaziou Cc: albertoefg@posteo.mx, 40035@debbugs.gnu.org X-Debbugs-Original-Cc: Alberto EFG , guix-patches@gnu.org, 40035@debbugs.gnu.org Received: via spool by 40035-submit@debbugs.gnu.org id=B40035.159256858917009 (code B ref 40035); Fri, 19 Jun 2020 12:10:02 +0000 Received: (at 40035) by debbugs.gnu.org; 19 Jun 2020 12:09:49 +0000 Received: from localhost ([127.0.0.1]:55330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmFq9-0004QH-2Z for submit@debbugs.gnu.org; Fri, 19 Jun 2020 08:09:49 -0400 Received: from tobias.gr ([80.241.217.52]:42020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmFq5-0004Q6-K6 for 40035@debbugs.gnu.org; Fri, 19 Jun 2020 08:09:47 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 2ebb9510; Fri, 19 Jun 2020 12:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to:cc :subject:references:in-reply-to:date:message-id:mime-version :content-type; s=2018; i=me@tobias.gr; bh=p6ETRVOt9HntS37+rboJI5 C15H3xMt8QYAjWkXsPooA=; b=EfQZQtmwDBUcf23J3gqYTwTVZPMp/NdJTVrDdE 11Qz/aABgKREU8Gq3QOX5N5znnjf5vj5jX/DIftsqV2n7Ma1FntrzkER7561Ba3/ Lsud8SIOWPatolrpoe6i1aW/kUwycHCPqhuqE1yWfPjG72LBMVA9eDjizi4ciNRO RXbrwEIwZMRsqzqr1ZtWiO5ILVR08A9Kd65/VnpTObO1d8MRwm5LMG7L2LyFo1QN CvkHpvGgN79YFxVdiH7FpkpAl+i67KfknPpu9vqs+AIpgXuhCLwTDHgKjK1g518o qEyp3NJoPBErjvHRfOfOgmQNBTf8v7qwW69sZscAzkwjsQ5A== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 036d0a3f (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 19 Jun 2020 12:09:43 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; References: <87o8t2gpqx.fsf@posteo.mx> <87imj9skzr.fsf@nicolasgoaziou.fr> <87k13pkku4.fsf@posteo.mx> <874kussm8q.fsf@nicolasgoaziou.fr> <87lfkk83ws.fsf@nicolasgoaziou.fr> In-reply-to: <87lfkk83ws.fsf@nicolasgoaziou.fr> Date: Fri, 19 Jun 2020 14:09:42 +0200 Message-ID: <871rmbw92x.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=tobias.gr header.s=2018 header.b=EfQZQtmw; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.61 X-TUID: YpQHWIWlVWnj --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Alberto, Nicolas, Nicolas Goaziou =E5=86=99=E9=81=93=EF=BC=9A > I integrated the previous suggestions. I am not sure about the=20 > version > string. Upstream seems to use "build-20", and most distributions=20 > use > "20", some use "build20" or "b20". I used "build20" because it=20 > makes it > easier to build the download URL. Does =E2=80=98build=E2=80=99 mean beta or (stable) preview here? Then we s= hould=20 append =E2=80=980.0.0-=E2=80=99 or similar, like we do for git snapshots, t= o the=20 front in case upstream releases a 1.x at some point. Otherwise, =E2=80=9820=E2=80=99's fine, really. > I'm sending the updated patch for review. Thank you both! I'm building it now. > + (patches > + ;; Use system Minizip. This is discussed updstream at > + ;; . > + (search-patches=20 > "widelands-system-wide_minizip.patch")))) Minor typo (=E2=80=98embeeded=E2=80=99). Are you the =E2=80=98I=E2=80=99 i= n the patch? Is it=20 pending upstream application? If so, a link to the upstream bug=20 report/commit would be nice. > + (list "-DCMAKE_BUILD_TYPE=3DRelease" Why not the default RelWithDebInfo? Please note in a comment. > + ("DejaVu" ,font-dejavu) ;case matters in name [=E2=80=A6] > + ("MicroHei" ,font-wqy-microhei) ;case matters in name Mkay I guess. No point in a codebase chock-full of repetitive=20 alists if we're not going to take advantage of it once in a while=20 :-) I'd put both at the end with a single ;; Fonts for the =E2=80=98unbundle-fonts=E2=80=99 phase. Case matters in= name! comment. > + ("minizip" ,minizip) > + ("sdl" ,(sdl-union (list sdl2 sdl2-image sdl2-mixer=20 > sdl2-ttf))) > + ("zlib" ,zlib))) > + (home-page "https://www.widelands.org/") > + (synopsis "Fantasy real-time strategy game") > + (description > + "Widelands is a real-time strategy game with singleplayer=20 > campaigns and > +multiplayer mode, aiming for gameplay similar to Settlers II by=20 > BlueByte. > + > +In this game, you start out on a small piece of land with=20 > nothing more than > +a few of useful resources. Using those, you can build yourself=20 > an empire with > +many thousands of inhabitants. On your way towards this goal,=20 > you will have > +to build up an economic infrastructure, explore the lands=20 > around you and face > +enemies who are trying to rule the world just like you do.") I think Debian(-derived) descriptions are OK but I prefer=20 yours/upstream's anyway. > + ;; Game is released as GPL2+. Some parts, e.g., art, are=20 > released under > + ;; different licenses. At least Culmus and Sinhala are GPL2-only. The title screen also=20 says =E2=80=98GNU General Public License V2.0=E2=80=99. > + (license (list license:gpl2+ > + license:gpl3+ Which parts are gpl3+? That sounds problematic. > + license:expat > + license:zlib > + license:silofl1.1 > + license:asl2.0 > + license:cc-by-sa3.0)))) It's built now, I will test it extensively on the bus=E2=80=A6 Thanks! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXuyrBgAKCRANsP+IT1Vt ecEhAP4muwDmY7Vkhr2IIAPADA4lLBun/s2ecKfun0TYnX/8yQD/euV4qHVwDXxL SZAVAtCzSuY2EcH6YJyn6+XIrmQGtgc= =1cMl -----END PGP SIGNATURE----- --=-=-=--