From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yJIkIfwyEF81dwAA0tVLHw (envelope-from ) for ; Thu, 16 Jul 2020 10:59:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mDEPHfwyEF8CJQAAB5/wlQ (envelope-from ) for ; Thu, 16 Jul 2020 10:59:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7B639408E6 for ; Thu, 16 Jul 2020 10:59:07 +0000 (UTC) Received: from localhost ([::1]:50396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw1bW-0007fo-0L for larch@yhetil.org; Thu, 16 Jul 2020 06:59:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw1bS-0007fT-Aj for guix-patches@gnu.org; Thu, 16 Jul 2020 06:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jw1bS-0000j1-1t for guix-patches@gnu.org; Thu, 16 Jul 2020 06:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jw1bR-0007gq-Tr for guix-patches@gnu.org; Thu, 16 Jul 2020 06:59:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42387] [PATCH] gnu: emacs-exwm: Fix fullscreen states. Resent-From: Diego Nicola Barbato Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Jul 2020 10:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 42387 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 42387@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159489713129542 (code B ref -1); Thu, 16 Jul 2020 10:59:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jul 2020 10:58:51 +0000 Received: from localhost ([127.0.0.1]:54719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw1bD-0007gK-FL for submit@debbugs.gnu.org; Thu, 16 Jul 2020 06:58:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:37844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw1b8-0007gA-Eo for submit@debbugs.gnu.org; Thu, 16 Jul 2020 06:58:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw1b7-0007dp-TP for guix-patches@gnu.org; Thu, 16 Jul 2020 06:58:42 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33993) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw1b2-0000ac-Hm for guix-patches@gnu.org; Thu, 16 Jul 2020 06:58:41 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 687CC2400FD for ; Thu, 16 Jul 2020 12:58:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1594897113; bh=WB9b4j4YvvJKzTb4bJEObzRHriaOPq7zH75PTB+NdGU=; h=From:To:Subject:Date:From; b=MaqeLJophurzFUVBO744j4arQB44NwjvNyuvaz9KpdZ5i0HoYlN/LmpT3nc6DrvmY Ib+bgg9Wmn1tOUiv3czal/AbazPGJtMPOIY0xSwA2oCfFfi0pUHqD9K8lBlWYV+lyo l1wbVnOwxj45F12jXrgbczWt3MslpzA46A8nLUxdcb+Jzmh2wks6iizPzLtJxxoOfP 1v0BCAaWg6De5iZeFNUqUtixG1VDIwf1oegG0HjM+yspwgqKl5bj/as+2KQ0Kqlq3r VF6hXqbcdTfMhyxqUccHkqxV9841BDrfnYUtZzdjU4TRM5JUqj8BdH4f9/gMq5I8zo Medv1mEFkS48A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4B6rpJ5WCpz6tmQ for ; Thu, 16 Jul 2020 12:58:32 +0200 (CEST) From: Diego Nicola Barbato User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Thu, 16 Jul 2020 12:58:32 +0200 Message-ID: <871rlbbuav.fsf@GlaDOS.home> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=dnbarbato@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/16 06:58:33 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.3 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=posteo.de header.s=2017 header.b=MaqeLJop; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.de (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: mLi8wHZdax+e --=-=-= Content-Type: text/plain Hey Guix, Updating EXWM to 0.24 (commit: 2a56b2c) broke fullscreen mode. The following patch applies the upstream fix. Regards, Diego --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-exwm-Fix-fullscreen-states.patch >From ae47fddd3ebafacf05b2150c8e9627e86eb122a6 Mon Sep 17 00:00:00 2001 From: Diego Nicola Barbato Date: Thu, 16 Jul 2020 11:39:27 +0200 Subject: [PATCH] gnu: emacs-exwm: Fix fullscreen states. * gnu/packages/patches/emacs-exwm-fix-fullscreen-states.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/emacs-xyz.scm (emacs-exwm)[source]: Use it. --- gnu/local.mk | 1 + gnu/packages/emacs-xyz.scm | 4 +- .../emacs-exwm-fix-fullscreen-states.patch | 39 +++++++++++++++++++ 3 files changed, 43 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/emacs-exwm-fix-fullscreen-states.patch diff --git a/gnu/local.mk b/gnu/local.mk index ddd024677a..e016c2178a 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -905,6 +905,7 @@ dist_patch_DATA = \ %D%/packages/patches/elm-compiler-fix-map-key.patch \ %D%/packages/patches/emacs27-exec-path.patch \ %D%/packages/patches/emacs-exec-path.patch \ + %D%/packages/patches/emacs-exwm-fix-fullscreen-states.patch \ %D%/packages/patches/emacs-fix-scheme-indent-function.patch \ %D%/packages/patches/emacs-json-reformat-fix-tests.patch \ %D%/packages/patches/emacs-highlight-stages-add-gexp.patch \ diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 537638bd36..9a43a23010 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -10900,7 +10900,9 @@ It should enable you to implement low-level X11 applications.") (uri (string-append "https://elpa.gnu.org/packages/" "exwm-" version ".tar")) (sha256 - (base32 "0lj1a3cmbpf4h6x8k6x8cdm1qb51ca6filydnvi5zcda8zpl060s")))) + (base32 "0lj1a3cmbpf4h6x8k6x8cdm1qb51ca6filydnvi5zcda8zpl060s")) + (patches + (search-patches "emacs-exwm-fix-fullscreen-states.patch")))) (build-system emacs-build-system) (propagated-inputs `(("emacs-xelb" ,emacs-xelb))) diff --git a/gnu/packages/patches/emacs-exwm-fix-fullscreen-states.patch b/gnu/packages/patches/emacs-exwm-fix-fullscreen-states.patch new file mode 100644 index 0000000000..6d31021f67 --- /dev/null +++ b/gnu/packages/patches/emacs-exwm-fix-fullscreen-states.patch @@ -0,0 +1,39 @@ +From edb930005b0ba83051ca8a59b493e9a3c8ef580a Mon Sep 17 00:00:00 2001 +From: Chris Feng +Date: Sun, 14 Jun 2020 00:00:00 +0000 +Subject: [PATCH] Fix fullscreen states + +* exwm-layout.el (exwm-layout-set-fullscreen, +exwm-layout-unset-fullscreen): Use `exwm--id' for interactive use. +(exwm-layout-unset-fullscreen): Mandatorily clear fullscreen states. +--- + exwm-layout.el | 6 ++++-- + 1 file changed, 4 insertions(+), 2 deletions(-) + +diff --git a/exwm-layout.el b/exwm-layout.el +index 170c2be..79d0c95 100644 +--- a/exwm-layout.el ++++ b/exwm-layout.el +@@ -205,7 +205,7 @@ + :border-width 0 + :stack-mode xcb:StackMode:Above)) + (cl-pushnew xcb:Atom:_NET_WM_STATE_FULLSCREEN exwm--ewmh-state) +- (exwm-layout--set-ewmh-state id) ++ (exwm-layout--set-ewmh-state exwm--id) + (xcb:flush exwm--connection) + (set-window-dedicated-p (get-buffer-window) t) + (exwm-input--release-keyboard exwm--id))) +@@ -233,7 +233,9 @@ + (let ((window (get-buffer-window nil t))) + (when window + (exwm-layout--show exwm--id window)))) +- (exwm-layout--set-ewmh-state id) ++ (setq exwm--ewmh-state ++ (delq xcb:Atom:_NET_WM_STATE_FULLSCREEN exwm--ewmh-state)) ++ (exwm-layout--set-ewmh-state exwm--id) + (xcb:flush exwm--connection) + (set-window-dedicated-p (get-buffer-window) nil) + (when (eq 'line-mode exwm--selected-input-mode) +-- +2.26.2 + -- 2.26.2 --=-=-=--