From: Kei Kebreau <kkebreau@posteo.net>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 43161-done@debbugs.gnu.org
Subject: bug#43161: [PATCH] gnu: deluge: Update to 2.0.3.
Date: Sat, 05 Sep 2020 15:59:04 -0400 [thread overview]
Message-ID: <871rjgov07.fsf@posteo.net> (raw)
In-Reply-To: <87ft7xq2sn.fsf@gnu.org> (Mathieu Othacehe's message of "Fri, 04 Sep 2020 12:00:56 +0200")
Mathieu Othacehe <othacehe@gnu.org> writes:
> Hey,
>
>> * gnu/packages/bittorrent.scm (deluge): Update to 2.0.3.
>> [source]: Update URL.
>> [inputs]: Remove libtorrent, python2-chardet, python2-pygtk,
>> python2-pyopenssl,
>> python2-pyxdg, python2-service-identity, python2-twisted.
>> [propagated-inputs]: Add gobject-introspection, gtk+, librsvg, libtorrent,
>> python-pycairo, python-chardet, python-dbus, python-mako, python-pygobject,
>> python-pillow, python-pyopenssl, python-pyxdg, python-rencode,
>> python-service-identity, python-setproctitle, python-six, python-twisted, and
>> python-zope-interface.
>> [native-inputs]: Add python-wheel.
>> [arguments]: Disable tests. Add 'wrap phase.
>
> That's a major update!
>
>> + ;; After "pytest-twisted" is packaged, HOME is set, and an X server is
>> + ;; started, some of the tests still fail. There are likely some
>> tests that
>> + ;; require a network connection.
>
> Besides wrapping this comment to stay under the 78 columns limit, it all
> looks fine.
>
Alright, I was under the impression that the column limit was 80 based
on the note in guix/lint.scm.
> Thanks,
>
> Mathieu
Pushed with size-reducing and bug-fixing changes to master as commit
01d5eec92d!
Thanks for reviewing,
Kei
prev parent reply other threads:[~2020-09-05 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 21:22 [bug#43161] [PATCH] gnu: deluge: Update to 2.0.3 Kei Kebreau
2020-09-04 10:00 ` Mathieu Othacehe
2020-09-05 19:59 ` Kei Kebreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rjgov07.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=43161-done@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).