From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id k9HSMYoafl/SOgAA0tVLHw (envelope-from ) for ; Wed, 07 Oct 2020 19:44:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id izAILYoafl/ESwAAB5/wlQ (envelope-from ) for ; Wed, 07 Oct 2020 19:44:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3769E9402A6 for ; Wed, 7 Oct 2020 19:44:10 +0000 (UTC) Received: from localhost ([::1]:50860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQFM8-00084x-6p for larch@yhetil.org; Wed, 07 Oct 2020 15:44:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQFM2-00084V-14 for guix-patches@gnu.org; Wed, 07 Oct 2020 15:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46591) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQFM1-0001af-Mm for guix-patches@gnu.org; Wed, 07 Oct 2020 15:44:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQFM1-0002Bi-KJ for guix-patches@gnu.org; Wed, 07 Oct 2020 15:44:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43809] [PATCH 1/1] gnu: emacs-tuareg: Update to 2.2.0-0.ccde45b. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Oct 2020 19:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43809 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 43809@debbugs.gnu.org Received: via spool by 43809-submit@debbugs.gnu.org id=B43809.16020998088362 (code B ref 43809); Wed, 07 Oct 2020 19:44:01 +0000 Received: (at 43809) by debbugs.gnu.org; 7 Oct 2020 19:43:28 +0000 Received: from localhost ([127.0.0.1]:58137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQFLU-0002An-F6 for submit@debbugs.gnu.org; Wed, 07 Oct 2020 15:43:28 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:39701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQFLS-0002AZ-DU for 43809@debbugs.gnu.org; Wed, 07 Oct 2020 15:43:27 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 21D121BF204; Wed, 7 Oct 2020 19:43:18 +0000 (UTC) From: Nicolas Goaziou References: <20201005072342.17369-1-zimon.toutoune@gmail.com> <20201005072501.17848-1-zimon.toutoune@gmail.com> Date: Wed, 07 Oct 2020 21:43:18 +0200 In-Reply-To: <20201005072501.17848-1-zimon.toutoune@gmail.com> (zimoun's message of "Mon, 5 Oct 2020 09:25:01 +0200") Message-ID: <871ri9bz55.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 7Lf+yFZLLdwz Hello, zimoun writes: > * gnu/packages/ocaml.scm (emacs-tuareg): Update to 2.2.0-0.ccde45b. Thank you. Some minor comments follow. > + (let ((commit "ccde45bbc292123ec20617f1af7f7e19f7481545")) I suggest to add a comment explaining why we do not use regular release. > + (package > + (name "emacs-tuareg") > + (version (git-version "2.2.0" "0" commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ocaml/tuareg") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1yxv4bnqarilnpg5j7wywall8170hwvm0q4xx06yqjgcn8pq1lac")))) > + (build-system gnu-build-system) > + (native-inputs `(("emacs" ,emacs-minimal) > + ("opam" ,opam))) Nitpick: Please move these inputs below `native-inputs'. Otherwise, LGTM. Regards, -- Nicolas Goaziou