unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Tomás Ortín Fernández" <tomasortin@mailbox.org>
Cc: 43781@debbugs.gnu.org
Subject: [bug#43781] [PATCH 2/2] gnu: Add cgoban
Date: Thu, 22 Oct 2020 16:55:38 +0200	[thread overview]
Message-ID: <871rhqtimt.fsf@gnu.org> (raw)
In-Reply-To: <9f324abb-f935-b748-526b-467113e87670@mailbox.org> ("Tomás Ortín Fernández"'s message of "Sat, 3 Oct 2020 21:05:46 +0200")

Hi,

Tomás Ortín Fernández <tomasortin@mailbox.org> skribis:

> Sorry, I see I should have sent it all in one email.
>
> * gnu/packages/games.scm (cgoban): New variable.

Sorry for the delay!  Some comments:

> +    (arguments
> +     `(#:tests? #t))

Please add a short comment explaining why tests are disabled.

> --- /dev/null
> +++ b/gnu/packages/patches/cgoban-1.9.14-cflags.patch
> @@ -0,0 +1,40 @@
> +--- a/configure.in
> ++++ b/configure.in

Patches should start with a couple lines stating the origin, their
upstream status, and what they do.

Patches also need to be listed in ‘gnu/local.mk’ and mentioned in the
commit log.

However, I suspect this patch has no effect: since ‘autoconf’ is not an
input of the package, its ‘configure’ script cannot be rebuilt to take
those changes into account.

Perhaps you can just remove it?

Could you send a second version?

Thanks!

Ludo’.




  reply	other threads:[~2020-10-22 14:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-03 17:50 [bug#43781] [PATCH 0/2] gnu: Add cgoban Tomás Ortín Fernández via Guix-patches via
2020-10-03 19:05 ` [bug#43781] [PATCH 2/2] " Tomás Ortín Fernández via Guix-patches via
2020-10-22 14:55   ` Ludovic Courtès [this message]
2020-10-22 15:07     ` Tomás Ortín via Guix-patches
2020-10-26 10:44       ` Ludovic Courtès
2020-11-18 22:06         ` Ludovic Courtès
2020-11-26  8:56 ` [bug#43781] (no subject) Tomás Ortín Fernández via Guix-patches via
2020-11-29 19:19   ` bug#43781: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rhqtimt.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=43781@debbugs.gnu.org \
    --cc=tomasortin@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).